Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp115326ybg; Tue, 2 Jun 2020 18:14:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxO9nGb+3zaPK+tnBha+MKtoxF5OnQRJKoZGw9nTZ0zsup50IZYtXOVT9ddzgZWO/+wEMB X-Received: by 2002:a17:906:48d8:: with SMTP id d24mr25729292ejt.369.1591146853473; Tue, 02 Jun 2020 18:14:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591146853; cv=none; d=google.com; s=arc-20160816; b=Jm5XfLluclucIr1l8QSxuD62KThqC3MaV4CHTJG8VzQa/F6DX9cudUwpd3YM5eZlrb yNAWdz8mFgdqgtgs8caf5Da1jTZBkXghRC2TtY71jjv839DIH9h57UMAehuOU2Rh1z1v dawAH8Y9KZspVJzc/Xz/JleHSL96jjtI/hmJtDnhsCk/FqoC68z/1fZrbQSZxHf8GWmp sUDPfLsqulL2q91jRsapDwT3Pj26+mh5lK+hF0y8msjpXH4up2k0JdCx7SqKKCjvKC5A cdk/TTLWrZPYvs9SRMFaO3VcCvMvBLFNPxcshH+6fOxyiPDUQbGI4wxatL97W6SuohIn sGSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=3/STZ1SexWREBvXya0wbTc4mMqOFMgMJt3fHBvJ6Xvk=; b=etmPW9qKO0EV2PWtG2NndA+9qEFJcNZ//E/SLroA0ecYG8SoUg+1Rf/aL+ueBxWCHn QNPjDfJvyv81SCp0DbpPYVl6lU2lfl6uJ0o7lohZXp7E4Lt4bg6FhikYnaKuM2eqtIEb r9HuC2XE4gLjcwI7Wo7kuO/xIGLTaTkgyMsQGBsnsOJX+auXDF5wbJFAzVO861YagqTG UvCuqL8wdGVvbak1l4K+TD77S1p9iKHXwur0+VRmuozkvrAKhHymhdsJvoRolUJLzAKq HtvlGi+F2ssEczA4m8/J6b8LoqPa8R/82hhJzSKq6TZKSq9ELuy0s+IsPFAhdQcjmt9z bRAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=AWJlgZGz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b22si239705edr.89.2020.06.02.18.13.20; Tue, 02 Jun 2020 18:14:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=AWJlgZGz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727826AbgFCBC0 (ORCPT + 99 others); Tue, 2 Jun 2020 21:02:26 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:39590 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726112AbgFCBC0 (ORCPT ); Tue, 2 Jun 2020 21:02:26 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0530sTUS051785; Wed, 3 Jun 2020 01:01:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=3/STZ1SexWREBvXya0wbTc4mMqOFMgMJt3fHBvJ6Xvk=; b=AWJlgZGzySIv3D62CcQ4wK42T3+MtmHtpOEMbBF4Bey50Hdrx3qiu367Hol1Xdo8oy85 2XLAPbnSclJzz53AjoGAyz2fubguWcpV6ydiJK7H15esEEKRp0SFlRkzwjTHOqoFkoeD oM9Vaz9N0dBHVX2iOrS30OXo4uIUSM9VfT52r3R4xgqdnecvNMDghKg0Ri2nIDVwYK3S q7j6D3YXSVm8kwyistCNsQ6NbQEAIzbZBajp/HiOSOBFSsLWbrXyGt7XTslswNFX8At6 tuNKKpMAg4XaUXjTE/Iuk5YuM1R77o89/T+yi5b1h6oWRh+wmkN6URQ8qQOmAg0gBJS2 4g== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 31bfem6kfw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 03 Jun 2020 01:01:49 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0530w0kp182355; Wed, 3 Jun 2020 01:01:49 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 31dju2c62d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Jun 2020 01:01:49 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 05311fRO017194; Wed, 3 Jun 2020 01:01:46 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 02 Jun 2020 18:01:41 -0700 To: Chris Boot Cc: Bart Van Assche , Chuhong Yuan , "Martin K . Petersen" , Nicholas Bellinger , Stefan Richter , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sbp-target: add the missed kfree() in an error path From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20200528102056.911825-1-hslester96@gmail.com> <475e4f50-6d20-d653-8288-0676bc708bcc@acm.org> Date: Tue, 02 Jun 2020 21:01:38 -0400 In-Reply-To: (Chris Boot's message of "Thu, 28 May 2020 16:16:51 +0100") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9640 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=885 phishscore=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=1 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006030004 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9640 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=1 mlxlogscore=927 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1011 impostorscore=0 adultscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 cotscore=-2147483648 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006030003 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chris, > I think you might be right. I also don't have much time to maintain it > these days and the hardware I had is long dead. In that case I'd appreciate a patch to remove it. Thanks! -- Martin K. Petersen Oracle Linux Engineering