Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp165749ybg; Tue, 2 Jun 2020 20:06:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/coouLTjFd9Uvy+ugogdSHNp8TrxDSgmufXkoRjyMVGCFV8Q9eN8HqOys9iHaMnsm+QJP X-Received: by 2002:a17:906:48d8:: with SMTP id d24mr25970789ejt.369.1591153606556; Tue, 02 Jun 2020 20:06:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591153606; cv=none; d=google.com; s=arc-20160816; b=y6LztIfe6NIZsBPJEpbVoEvQjY8Y668Mg1U5l3375Wa3fB6r5uYTPHJMj53GewVsj4 l0YRKguIfyygz06ojly6tz6SYc0GW1KMtDddYjCjELNbM68cZUYQFgWMuMBJbodywaBD WFi09sZKtBd6eZ/GQQJTXznfOMlHv2oggFn6YoPKX8+7zVQ2Y8VypZTLd5D+UH9zinLZ 2/EqiySW0I+FVqdDshcI0qtUPUt3pMZKTzRbK6iNS+voX3XjII4tUDJ5suHUBJtRHiPO 1C6qsLtuz2Oa27zdK9vlftYjR0081jWX7pu7cDpXClCDQ1/ODD9ks0xGVCTo/qxc1L3O 3Y+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=1W2HEfGfiOq6i5eZz1WzgBAvpOpa4eeTPzMw2kcW2ns=; b=Lt8n7GPPieToB3uVDtcrz4v+JDfICCSrtfexYb10mmJnvZaLAdvPb3gUUK6yN1u2f7 JU3lpEHW7xWgAbpiID99DttB8vguu+of7dh2d/+o/fi4SXSqFy4TZ9kY8Z8JDI61SNCr P6hUTqsmpQua5glz07XnsGf7dl1oZZ+5HyBNTsX4b6HepiEyZgYvEkiaZkJdBzOg8h9o QEJKG6CDhylNZt2KrLC+b1j4rGx4cz8c9LXOheTR4unLhWdgdWb7ShTCM50vusj6E47D qpMBHrVfPrz4PLNzOQa9Znrvw3EWKDcK1mHAO/Z1P+0vyNfWWtmdET9wVyJZTohpX/ue S3bg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k26si446688ejv.109.2020.06.02.20.06.23; Tue, 02 Jun 2020 20:06:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725910AbgFCDCb (ORCPT + 99 others); Tue, 2 Jun 2020 23:02:31 -0400 Received: from mail5.windriver.com ([192.103.53.11]:51676 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgFCDCa (ORCPT ); Tue, 2 Jun 2020 23:02:30 -0400 Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id 05331agd009646 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 2 Jun 2020 20:01:46 -0700 Received: from pek-lpg-core1-vm1.wrs.com (128.224.156.106) by ALA-HCB.corp.ad.wrs.com (147.11.189.41) with Microsoft SMTP Server id 14.3.487.0; Tue, 2 Jun 2020 20:01:07 -0700 From: To: CC: , , Subject: [PATCH] usb: usbtest: fix missing kfree(dev->buf) in usbtest_disconnect Date: Wed, 3 Jun 2020 11:09:58 +0800 Message-ID: <20200603030958.31666-1-qiang.zhang@windriver.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zqiang BUG: memory leak unreferenced object 0xffff888055046e00 (size 256): comm "kworker/2:9", pid 2570, jiffies 4294942129 (age 1095.500s) hex dump (first 32 bytes): 00 70 04 55 80 88 ff ff 18 bb 5a 81 ff ff ff ff .p.U......Z..... f5 96 78 81 ff ff ff ff 37 de 8e 81 ff ff ff ff ..x.....7....... backtrace: [<00000000d121dccf>] kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline] [<00000000d121dccf>] slab_post_alloc_hook mm/slab.h:586 [inline] [<00000000d121dccf>] slab_alloc_node mm/slub.c:2786 [inline] [<00000000d121dccf>] slab_alloc mm/slub.c:2794 [inline] [<00000000d121dccf>] kmem_cache_alloc_trace+0x15e/0x2d0 mm/slub.c:2811 [<000000005c3c3381>] kmalloc include/linux/slab.h:555 [inline] [<000000005c3c3381>] usbtest_probe+0x286/0x19d0 drivers/usb/misc/usbtest.c:2790 [<000000001cec6910>] usb_probe_interface+0x2bd/0x870 drivers/usb/core/driver.c:361 [<000000007806c118>] really_probe+0x48d/0x8f0 drivers/base/dd.c:551 [<00000000a3308c3e>] driver_probe_device+0xfc/0x2a0 drivers/base/dd.c:724 [<000000003ef66004>] __device_attach_driver+0x1b6/0x240 drivers/base/dd.c:831 [<00000000eee53e97>] bus_for_each_drv+0x14e/0x1e0 drivers/base/bus.c:431 [<00000000bb0648d0>] __device_attach+0x1f9/0x350 drivers/base/dd.c:897 [<00000000838b324a>] device_initial_probe+0x1a/0x20 drivers/base/dd.c:944 [<0000000030d501c1>] bus_probe_device+0x1e1/0x280 drivers/base/bus.c:491 [<000000005bd7adef>] device_add+0x131d/0x1c40 drivers/base/core.c:2504 [<00000000a0937814>] usb_set_configuration+0xe84/0x1ab0 drivers/usb/core/message.c:2030 [<00000000e3934741>] generic_probe+0x6a/0xe0 drivers/usb/core/generic.c:210 [<0000000098ade0f1>] usb_probe_device+0x90/0xd0 drivers/usb/core/driver.c:266 [<000000007806c118>] really_probe+0x48d/0x8f0 drivers/base/dd.c:551 [<00000000a3308c3e>] driver_probe_device+0xfc/0x2a0 drivers/base/dd.c:724 Fixes: fabbf2196d0d ("USB: usbtest fix coding style") Reported-by: Kyungtae Kim Signed-off-by: Zqiang --- drivers/usb/misc/usbtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c index 98ada1a3425c..bae88893ee8e 100644 --- a/drivers/usb/misc/usbtest.c +++ b/drivers/usb/misc/usbtest.c @@ -2873,6 +2873,7 @@ static void usbtest_disconnect(struct usb_interface *intf) usb_set_intfdata(intf, NULL); dev_dbg(&intf->dev, "disconnect\n"); + kfree(dev->buf); kfree(dev); } -- 2.24.1