Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Jun 2020 08:19:46 +0300
From:   Petteri Aimonen <jpa@git.mail.kapsi.fi>
To:     Shuah Khan <skhan@linuxfoundation.org>
Cc:     Andy Lutomirski <luto@amacapital.net>,
        Andy Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>, Shuah Khan <shuah@kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86-ml <x86@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch/x86: reset MXCSR to default in kernel_fpu_begin()
Message-ID: <20200603051946.GF17423@lakka.kapsi.fi>
References: <8b1f0bfa-79b0-74e4-0241-8b2a94491807@linuxfoundation.org>
 <C6F6F6E4-CBD8-4E72-812B-99F008ECAA4F@amacapital.net>
 <b4629042-21c7-2b38-4c3f-44f9be469cca@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b4629042-21c7-2b38-4c3f-44f9be469cca@linuxfoundation.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

> Is it correct to assume the stuff checked differs from test to test
> and done in user-space.
> 
> > undo_evil_state();
> 
> Is it correct to assume undoing evil differs from test to test
> and done in user-space, provide it can be done from userspace.

Yes, currently the test works like:

do_test_setup();
read_from_debugfs_file();
check_results();

and the middle step stays the same. But of course in general case there 
could be argument passing etc, even though the test for this issue 
doesn't need them.

Myself I don't see the problem with just adding a file under debugfs and 
bind to its read.

--
Petteri