Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964982AbWCTVjv (ORCPT ); Mon, 20 Mar 2006 16:39:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964988AbWCTVjv (ORCPT ); Mon, 20 Mar 2006 16:39:51 -0500 Received: from linux01.gwdg.de ([134.76.13.21]:59548 "EHLO linux01.gwdg.de") by vger.kernel.org with ESMTP id S964982AbWCTVju (ORCPT ); Mon, 20 Mar 2006 16:39:50 -0500 Date: Mon, 20 Mar 2006 22:39:45 +0100 (MET) From: Jan Engelhardt To: Nathan Scott cc: linux-xfs@oss.sgi.com, Linux Kernel Mailing List Subject: Re: Parenthesize macros in xfs In-Reply-To: <20060321082327.B653275@wobbly.melbourne.sgi.com> Message-ID: References: <20060321082327.B653275@wobbly.melbourne.sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 25 >> Hello xfs list, > >Hi Jan, > >> while browsing through the xfs/linux source, I noticed that many macros do >> not do proper bracing. I have started to cook up a patch, but would like >> feedback first before I continue for nothing. >> It goes like this: >> ... > >That looks fine. Please be sure to work on the -mm tree or on >CVS on oss.sgi.com, so as to reduce your level of patch conflict. > Hm, would not it even be better to make them 'static inline' functions? Jan Engelhardt -- | Software Engineer and Linux/Unix Network Administrator - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/