Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200601030347.112984-1-daeho43@gmail.com> <daed6176-fb7d-bd4d-9662-735cc3cda2e0@huawei.com>
In-Reply-To: <daed6176-fb7d-bd4d-9662-735cc3cda2e0@huawei.com>
From:   Daeho Jeong <daeho43@gmail.com>
Date:   Wed, 3 Jun 2020 16:06:15 +0900
Message-ID: <CACOAw_xgcevW9-xKHq-siDa-1i-Nap+rQQOpZ9LWyfbGkEmV=g@mail.gmail.com>
Subject: Re: [PATCH] f2fs: protect new segment allocation in expand_inode_data
To:     Chao Yu <yuchao0@huawei.com>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
        Daeho Jeong <daehojeong@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Oh, thanks for notification!

2020=EB=85=84 6=EC=9B=94 3=EC=9D=BC (=EC=88=98) =EC=98=A4=ED=9B=84 3:59, Ch=
ao Yu <yuchao0@huawei.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On 2020/6/1 11:03, Daeho Jeong wrote:
> > From: Daeho Jeong <daehojeong@google.com>
> >
> > Found a new segemnt allocation without f2fs_lock_op() in
> > expand_inode_data(). So, when we do fallocate() for a pinned file
> > and trigger checkpoint very frequently and simultaneously. F2FS gets
> > stuck in the below code of do_checkpoint() forever.
> >
> >   f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_CP_META_IO);
> >   /* Wait for all dirty meta pages to be submitted for IO */
> >                                                 <=3D if fallocate() her=
e,
> >   f2fs_wait_on_all_pages(sbi, F2FS_DIRTY_META); <=3D it'll wait forever=
.
> >
> > Signed-off-by: Daeho Jeong <daehojeong@google.com>
> > Reviewed-by: Chao Yu <yuchao0@huawei.com>
>
> Daeho,
>
> I guess Jaegeuk could add the tag when merging this patch, we don't have
> to resend the patch if there is no updates on code and message.
>
> Thanks,
>
> > ---
> >  fs/f2fs/file.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index f7de2a1da528..14ace885baa9 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -1660,7 +1660,11 @@ static int expand_inode_data(struct inode *inode=
, loff_t offset,
> >
> >               down_write(&sbi->pin_sem);
> >               map.m_seg_type =3D CURSEG_COLD_DATA_PINNED;
> > +
> > +             f2fs_lock_op(sbi);
> >               f2fs_allocate_new_segments(sbi, CURSEG_COLD_DATA);
> > +             f2fs_unlock_op(sbi);
> > +
> >               err =3D f2fs_map_blocks(inode, &map, 1, F2FS_GET_BLOCK_PR=
E_DIO);
> >               up_write(&sbi->pin_sem);
> >
> >