Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 03 Jun 2020 14:00:08 +0530
User-Agent: K-9 Mail for Android
In-Reply-To: <1591119192-18538-7-git-send-email-amittomer25@gmail.com>
References: <1591119192-18538-1-git-send-email-amittomer25@gmail.com> <1591119192-18538-7-git-send-email-amittomer25@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v3 06/10] arm64: dts: actions: Add DMA Controller for S700
To:     Amit Singh Tomar <amittomer25@gmail.com>, andre.przywara@arm.com,
        afaerber@suse.de, vkoul@kernel.org, robh+dt@kernel.org
CC:     dan.j.williams@intel.com, cristian.ciocaltea@gmail.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-actions@lists.infradead.org, devicetree@vger.kernel.org
From:   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Message-ID: <5B0DBC8E-36C3-4DC9-A5A4-043313C4C7FD@linaro.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2 June 2020 11:03:08 PM IST, Amit Singh Tomar <amittomer25@gmail=2Ecom>=
 wrote:
>This commit adds DAM controller present on Actions S700, it differs

DMA

>from
>S900 in terms of number of dma channels and requests=2E
>
>Signed-off-by: Amit Singh Tomar <amittomer25@gmail=2Ecom>
>---
>Changes since v2:
>	* added power-domain property as sps
>          is enabled now and DMA needs it=2E
>Changes since v1:
>        * No Change=2E
>Changes since RFC:
>        * No Change=2E
>---
> arch/arm64/boot/dts/actions/s700=2Edtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/actions/s700=2Edtsi
>b/arch/arm64/boot/dts/actions/s700=2Edtsi
>index f8eb72bb4125=2E=2E605594dd7a0e 100644
>--- a/arch/arm64/boot/dts/actions/s700=2Edtsi
>+++ b/arch/arm64/boot/dts/actions/s700=2Edtsi
>@@ -6,6 +6,7 @@
> #include <dt-bindings/clock/actions,s700-cmu=2Eh>
> #include <dt-bindings/interrupt-controller/arm-gic=2Eh>
> #include <dt-bindings/reset/actions,s700-reset=2Eh>
>+#include <dt-bindings/power/owl-s700-powergate=2Eh>

Sort this alphabetically=2E=20

Thanks,=20
Mani

>=20
> / {
> 	compatible =3D "actions,s700";
>@@ -244,5 +245,19 @@
> 				     <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
> 				     <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> 		};
>+
>+		dma: dma-controller@e0230000 {
>+			compatible =3D "actions,s700-dma";
>+			reg =3D <0x0 0xe0230000 0x0 0x1000>;
>+			interrupts =3D <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
>+				     <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
>+				     <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
>+				     <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
>+			#dma-cells =3D <1>;
>+			dma-channels =3D <10>;
>+			dma-requests =3D <44>;
>+			clocks =3D <&cmu CLK_DMAC>;
>+			power-domains =3D <&sps S700_PD_DMA>;
>+		};
> 	};
> };

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E