Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp362085ybg; Wed, 3 Jun 2020 02:44:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLLRm0cykduD45WRSd6RoJXFHnYwJMDmFfPKX17Uad26v0p62oWtfhAdvEJizP6A94ibaV X-Received: by 2002:a05:6402:8d1:: with SMTP id d17mr29259272edz.38.1591177452905; Wed, 03 Jun 2020 02:44:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591177452; cv=none; d=google.com; s=arc-20160816; b=sXqI2X56gUT8OOs3O3wsL74z5l4DAWvGxKpbviF5OZxefTWGe4awO22aC8p0HHMccS JbcUaJ7wdupBKqM+AAw7c6cf239qpK4j4fEO9wsNq751LE6TfPgr7z6Fp/+/9aRnqvLT krcLm3q0a6WRVH3IMWLXnhWY4ZUNGPC0mEk3IYu2ypPRQBZWD81eq8pj/oUcW3KHAHZu H1e4qX7NNmoEIgJzD1+muci59fSNazS4ZPKcVPVmWr9uVaE7uJZUVwyXru00UIskAEnU rqXGsNc8H1z1DEJ3XxIyTnoKAgOHDjI/6TZqMw4t15UCHHw7ooVrTdwh6LM/L4jQbZ/1 jsnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date; bh=V9tybK+SLmU7mLpYrPMvDPriHcXSCOtqZWDPTB+QJZw=; b=irIEWLbGj56gwhuMptq4kMMDcvpkGHcBr5ZmEQdUvUUoMpJeGRgt7uxFIJ+z+udcEM g/oRcP23UcwHpDhYoRuYr8BmUez8W185Y/tKEzkF5eE2dNqPSOTo47As29E5eFJgRaPA 2o9F67ETipc5V9gBMWkzL0aUlm0lalA32QktK+wfDj/L8MEm5br+JsEYzBd2ddh+t9uo hizRvS+R1NGTpRWuoOz50RVB3niHAtIYejxBfw2iChSDiYvqPzdt1HweeuXUw8+TX2mP GnBRnMFc2jrY6Vq37F+HQpgZS0nd6CSgF6yQTO7dauYDvvIxTeuNKNqtE7i8cu/ScXVs uT0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p31si800077edb.296.2020.06.03.02.43.49; Wed, 03 Jun 2020 02:44:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726312AbgFCJlQ (ORCPT + 99 others); Wed, 3 Jun 2020 05:41:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:59202 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbgFCJlQ (ORCPT ); Wed, 3 Jun 2020 05:41:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4F378ACC5; Wed, 3 Jun 2020 09:41:18 +0000 (UTC) Date: Wed, 03 Jun 2020 11:41:14 +0200 Message-ID: From: Takashi Iwai To: Chuhong Yuan Cc: Jaroslav Kysela , Takashi Iwai , Krzysztof Helt , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: es1688: Add the missed snd_card_free() In-Reply-To: <20200603092459.1424093-1-hslester96@gmail.com> References: <20200603092459.1424093-1-hslester96@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 03 Jun 2020 11:24:59 +0200, Chuhong Yuan wrote: > > snd_es968_pnp_detect() misses a snd_card_free() in a failed path. > Add the missed function call to fix it. > > Fixes: a20971b201ac ("ALSA: Merge es1688 and es968 drivers") > Signed-off-by: Chuhong Yuan Thanks, applied now with Cc-to-stable. Takashi