Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 3 Jun 2020 14:15:30 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     vincent.donnefort@arm.com, mingo@redhat.com,
        vincent.guittot@linaro.org, linux-kernel@vger.kernel.org,
        patrick.bellasi@matbug.net, dietmar.eggemann@arm.com,
        qais.yousef@arm.com
Subject: Re: [PATCH] sched/debug: Add new tracepoints to track util_est
Message-ID: <20200603121530.GB2570@hirez.programming.kicks-ass.net>
References: <1590597554-370150-1-git-send-email-vincent.donnefort@arm.com>
 <jhjlfl4icdx.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <jhjlfl4icdx.mognet@arm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 03, 2020 at 01:04:26PM +0100, Valentin Schneider wrote:
> 
> On 27/05/20 17:39, vincent.donnefort@arm.com wrote:
> > From: Vincent Donnefort <vincent.donnefort@arm.com>
> >
> > The util_est signals are key elements for EAS task placement and
> > frequency selection. Having tracepoints to track these signals enables
> > load-tracking and schedutil testing and/or debugging by a toolkit.
> >
> > Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
> >
> 
> To put it more bluntly, we can't really do task placement / load tracking
> testing if util_est is enabled (which reminds me we may want to get rid of
> the SCHED_FEAT at some point, it's been default on since ~v4.17), since
> there can be noticeable gaps between util_avg and util_est.
> 
> Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>

Thanks!