Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp468430ybg; Wed, 3 Jun 2020 05:39:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1Va/6jUpMwfS5NWoZrB4cp4BIWFnDpYCBnb9xXwszzsyZzN8+GW5lyxEbv3ie8wnUKdZr X-Received: by 2002:a17:906:695a:: with SMTP id c26mr11330670ejs.214.1591187959051; Wed, 03 Jun 2020 05:39:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591187959; cv=none; d=google.com; s=arc-20160816; b=YJNHLc3G/V8ljiq0os22U23sPjbJBtZqsk/c1RcVJypSURmKjidgZSbu0vvRmAR0D4 MQ+uQneShHEwzQ84fekFpFPOdpobw8tRAJV1ZLSXMdyIBOiYpuZgP4qXify515CbwTFS BsM2whG81PQcaG8uyVar6Zh7Q8+bha84lRZQ+iyB31Y6uXORWG3URLeOoOBItOQ/FKv2 tUjxHl+lwvn9OebhpStIVicxaUllC2HdFmPW0iaGIvdT0ZIacYCoUev/IDcXTV+KrTGi Dzbh96L3qS3KcXEwv2vrXAzmoqibbm/j9EvuDVU5Mcf8gsKndNQrzlySB345TsRaVnY2 px6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=PI7pydsdlkyMsOD6xUcLp/qzxqU4rnGyfjXgCb9CfWA=; b=HbSSkH0y1vm8vJDC9c6xbIxxngDsKdpeMtIC8bRTPKQJhdDrZmE1x45dR/s9CVzTXE BEaMpmN7PHzgkKPLO2D05/ap3hIjuyn2pQrXbrnh2v6yBgQR6iegWu7bCk1nNdo64bOG KZ7frlre7HCSxWo2/7/Evdj3t/AFisCzOiAD9tZtSkRTSov9ecyyWBFltR+1Lvs6o2my Rvk3wZu4PWDIoH2pfTn0P8DyJ/08+SNDrVTlFqsNKQf7rC5slIfMc4PV+42WN93WqT25 7MuLcI5xk0sFQ3FcqS9fWc3vCDOI9eSdZSAyuavpIDr3D2TK2iaToeqD0O8WoIsvF7PO syNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xfnWQd9o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oj22si1042968ejb.115.2020.06.03.05.38.55; Wed, 03 Jun 2020 05:39:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xfnWQd9o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726066AbgFCMe6 (ORCPT + 99 others); Wed, 3 Jun 2020 08:34:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725859AbgFCMe5 (ORCPT ); Wed, 3 Jun 2020 08:34:57 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 357FFC08C5C0 for ; Wed, 3 Jun 2020 05:34:57 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id c17so2460432lji.11 for ; Wed, 03 Jun 2020 05:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PI7pydsdlkyMsOD6xUcLp/qzxqU4rnGyfjXgCb9CfWA=; b=xfnWQd9oEyAsFzOPGt1mBJdArDRnh2rm2HZKJiiufZ4G3XU4PfqVW12McDu5EdvBVb qyfCex95T6C8Tcy86/IPyXEU3S80ASk+HARGYDiI6ViBZrc8pU4AWMn1Jqp8fW1s8W1g rRcyu95uIpQjRNQ0t7A8VWRPB0Gjrr7ZjNixzNhSgX334YRru7RYUn5hqcPerbW9I/vk IUaQ8XN78CUAtwSMO7xGQaeSOXYyu8EoTuCMR15KHfh8nAVjRMCqTcvKmwNbafE99vnv TaEjAvcLgbbAIs3kQ8rZcHoQPOI3s29vSI6VHexaAO6k29daJjUDM2GVsCcOKfV0FEES j8/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PI7pydsdlkyMsOD6xUcLp/qzxqU4rnGyfjXgCb9CfWA=; b=nCUFZOxXmnq6MQTUXVrXw6zxE/7nAMK/2x3eNcCBTtwC8QUK/1E5WViiKhNlaSFhAM tzzsMMiAPl6l5qMljQkwdDxl20uqdKpAHrXB1Ruq18qocWKr3napFzzwiC1giTnBlbPU 8zqyrmk3QP74jSP+vkpq3+mntZwhpUnpjW1bbNLiqGYYy5XsC/pHBBBCvD8D/Y/nc95N SZr0qeO03QSYsXl+RvzMr3HsgbpGS0V/v4Q4hQ7ug7XwhEQKvB8ilNqCaJx5DjEgl6pv OCdlKaVPY+Mx472yZTnFTl5K3jwnTSrioPFhYDmGj7Dd+2+INUw3hrWyDQSTSf/RP+Ai Zo4w== X-Gm-Message-State: AOAM533K68nU93WxlW/u1fOChLowEhQerMHHQQtq82R3snNzDNtFckzV Ko/vaHgubo2ppUikA7O3fzC02Yy0MC+nKOtz+D+9EQ== X-Received: by 2002:a2e:350a:: with SMTP id z10mr1926898ljz.104.1591187695709; Wed, 03 Jun 2020 05:34:55 -0700 (PDT) MIME-Version: 1.0 References: <20200530204955.588962-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200530204955.588962-1-christophe.jaillet@wanadoo.fr> From: Linus Walleij Date: Wed, 3 Jun 2020 14:34:44 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()' To: Christophe JAILLET Cc: Dong Aisheng , Fabio Estevam , Shawn Guo , Stefan Agner , Sascha Hauer , Sascha Hauer , NXP Linux Team , Gary Bisson , "open list:GPIO SUBSYSTEM" , Linux ARM , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 30, 2020 at 10:49 PM Christophe JAILLET wrote: > 'pinctrl_unregister()' should not be called to undo > 'devm_pinctrl_register_and_init()', it is already handled by the framework. > > This simplifies the error handling paths of the probe function. > The 'imx_free_resources()' can be removed as well. > > Fixes: a51c158bf0f7 ("pinctrl: imx: use radix trees for groups and functions") > Signed-off-by: Christophe JAILLET Patch applied! Yours, Linus Walleij