Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 93f2LNvkSLiXOoFGYy9qUAv5uCF0UJjimojlaMwD7+znkrZQuQc+aT66vXP0Tmure/XAoIWyTx
 ro/QNXA3wctw==
IronPort-SDR: wg2lZMeSDkJDKKAVordjaIC9RTwBFkDGoSR12cngbqwemtBlm8s5re3DgpMkp6kS2d4KJZPptv
 WTZ5S4qa0H7A==
Date:   Wed, 3 Jun 2020 15:41:43 +0300
From:   Sakari Ailus <sakari.ailus@linux.intel.com>
To:     Chuhong Yuan <hslester96@gmail.com>
Cc:     Jonathan Corbet <corbet@lwn.net>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Lubomir Rintel <lkundrak@v3.sk>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: marvell-ccic: Add missed
 v4l2_async_notifier_cleanup()
Message-ID: <20200603124143.GF16711@paasikivi.fi.intel.com>
References: <20200603115605.1428636-1-hslester96@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200603115605.1428636-1-hslester96@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Chuhong,

Thanks for the patch.

On Wed, Jun 03, 2020 at 07:56:05PM +0800, Chuhong Yuan wrote:
> mccic_register() forgets to cleanup the notifier in its error handler.
> Add the missed call to fix it.
> 
> Fixes: 3eefe36cc00c ("media: marvell-ccic: use async notifier to get the sensor")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
>  drivers/media/platform/marvell-ccic/mcam-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c
> index 09775b6624c6..cf2a0119e679 100644
> --- a/drivers/media/platform/marvell-ccic/mcam-core.c
> +++ b/drivers/media/platform/marvell-ccic/mcam-core.c
> @@ -1940,6 +1940,7 @@ int mccic_register(struct mcam_camera *cam)
>  out:
>  	v4l2_async_notifier_unregister(&cam->notifier);
>  	v4l2_device_unregister(&cam->v4l2_dev);
> +	v4l2_async_notifier_cleanup(&cam->notifier);
>  	return ret;
>  }
>  EXPORT_SYMBOL_GPL(mccic_register);

The same issue appears to be present in the mcam_shutdown(), could you fix
that one as well?

-- 
Regards,

Sakari Ailus