Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp563269ybg; Wed, 3 Jun 2020 07:56:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8F1lcmDUw4sv8mzMcvXKwlqR7KFQJLAyZyfLd3zfDBN21C3uBjFO7YHTr9naf+FdEF4eD X-Received: by 2002:a17:906:33ce:: with SMTP id w14mr26256248eja.35.1591196216703; Wed, 03 Jun 2020 07:56:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591196216; cv=none; d=google.com; s=arc-20160816; b=F3sni771NMd4JMuhVZdriyQUXTtjyXuvsIT4tum6KcXiXca5VDLSPNM/djiTF0czD7 EFS/PglbR6i0OungthTCrVmj4VT7CS9pMELSO/eVvcNYThR5GBJZPs7GLohIyUkgjEcb 7z1oft4RA+NKQX/vYyZb1y3pP73wZSe67im7S/me26sfYPr26Yf5qFJ1V23qUn1srroQ CTuAGkqPoViTHu58rysCye+Azraib3ljj6NWviP+DqzpbrrgJYQSGkUcI0hBHzuvena7 HH5qpJXBH/LCl0fuX9BW50VwwallMzPSI5JnvpyJEuFJiAqRgfv/+DOLEDEATiUsvyWr sqKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=cB4YH1U6ylX9+z3eo/94D9m2FP8BrDWh5sGUbee6Zdw=; b=OobYJPSMyDm7AEQ75STZJKruRGTkSVBX//g9KpDLl6dvAMPg822mTjgO3omwwOCmIY ye/zY+XYJekytpz1Dz+HaLOe9vIYFsJzg1sibuL9XFtomNXbvemgJLJRwS0fPH0CmwUJ aIkhlv3e9mdw3shwceBthBlBWvmQRtEifNEJ7lySAFtTJfYIkJ0O746KWejK+5zkwpLt nBcrNGaNnEFIV9J2mlKpwV4CJY+HjAn1so7bd+erAF4oLH2t3CORDwTyRt7XP0RsuLs/ RkZ1ZtaFeHHqJkouOAsoQJ4spqJAF77V6DtV4r1XCIfUab3Qu3arsU0zjuXzIqxwZx4c Qv1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n1si1217989edv.442.2020.06.03.07.56.33; Wed, 03 Jun 2020 07:56:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726021AbgFCOyz (ORCPT + 99 others); Wed, 3 Jun 2020 10:54:55 -0400 Received: from mga05.intel.com ([192.55.52.43]:13341 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbgFCOyy (ORCPT ); Wed, 3 Jun 2020 10:54:54 -0400 IronPort-SDR: yYEa+ODQTv4e0MaGzm3NmUrLxnLvbUAs6C8zJ75bo7lt2mMdw1uKVsfb3EpsIU0qMb2djOl399 3ytsxGIq4Emw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2020 07:54:54 -0700 IronPort-SDR: Na/zi5dWpOxM01SPF1+rbTUPlBzY0vjHthSG6Ni6xBFD3i9x1SJi0Ajc5fM/USa4TUtX5uaSRy xDQzcNFyX0iA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,467,1583222400"; d="scan'208";a="378127274" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 03 Jun 2020 07:54:49 -0700 Received: by lahna (sSMTP sendmail emulation); Wed, 03 Jun 2020 17:54:48 +0300 Date: Wed, 3 Jun 2020 17:54:48 +0300 From: Mika Westerberg To: Rajat Jain Cc: David Woodhouse , Lu Baolu , Joerg Roedel , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Ashok Raj , lalithambika.krishnakumar@intel.com, rajatxjain@gmail.com, pmalani@google.com, bleung@google.com, levinale@google.com, zsm@google.com, mnissler@google.com, tbroch@google.com Subject: Re: [PATCH v4] iommu/vt-d: Don't apply gfx quirks to untrusted devices Message-ID: <20200603145448.GU247495@lahna.fi.intel.com> References: <20200603130317.94672-1-rajatja@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200603130317.94672-1-rajatja@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2020 at 06:03:17AM -0700, Rajat Jain wrote: > Currently, an external malicious PCI device can masquerade the VID:PID > of faulty gfx devices, and thus apply iommu quirks to effectively > disable the IOMMU restrictions for itself. > > Thus we need to ensure that the device we are applying quirks to, is > indeed an internal trusted device. > > Signed-off-by: Rajat Jain > Acked-by: Lu Baolu > Reviewed-by: Ashok Raj Looks good now, thanks! Reviewed-by: Mika Westerberg