Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751381AbWCUANn (ORCPT ); Mon, 20 Mar 2006 19:13:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751383AbWCUANn (ORCPT ); Mon, 20 Mar 2006 19:13:43 -0500 Received: from dspnet.fr.eu.org ([213.186.44.138]:11022 "EHLO dspnet.fr.eu.org") by vger.kernel.org with ESMTP id S1751381AbWCUANm (ORCPT ); Mon, 20 Mar 2006 19:13:42 -0500 Date: Tue, 21 Mar 2006 01:13:36 +0100 From: Olivier Galibert To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, David Vrabel Subject: Re: [PATCH 04/23] driver core: platform_get_irq*(): return -ENXIO on error Message-ID: <20060321001336.GB84147@dspnet.fr.eu.org> Mail-Followup-To: Olivier Galibert , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, David Vrabel References: <11428920373568-git-send-email-gregkh@suse.de> <11428920383013-git-send-email-gregkh@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11428920383013-git-send-email-gregkh@suse.de> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 589 Lines: 16 On Mon, Mar 20, 2006 at 02:00:38PM -0800, Greg Kroah-Hartman wrote: > platform_get_irq*() cannot return 0 on error as 0 is a valid IRQ on some > platforms, return -ENXIO instead. 0 is NO_IRQ, and can not be a valid IRQ number, ever. A platform_get_irq*() returning 0 as a valid irq is buggy. Check http://lkml.org/lkml/2005/11/21/211 OG. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/