Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp626542ybg; Wed, 3 Jun 2020 09:24:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy70tr4IoHC0reTPTbbnFG+gfLDEvaLPuHekRhATQT/mmf3+FXmVpr9O5dmJdJ/CTrFOYCu X-Received: by 2002:a17:906:e0c:: with SMTP id l12mr61011eji.435.1591201484814; Wed, 03 Jun 2020 09:24:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591201484; cv=none; d=google.com; s=arc-20160816; b=vnjfNdh7MOAZuwN+2VrPb4FDzf461Q2dNNTgOdalgVHOq2nG2GcOtpd5n3xXp/AHxx DZRcebRF/c+w1RB+VnxfXX7GEcJUHtViDI5YnJvM2pEGjKAR4MD12S9FNOjikqUXRxey gnaClEcX5wIAsKQsP5MV7Is+vOoEsJxFYWNuXlUrp03i0OxU1zU3I5SDd5GqeSohV+xx vsDHADt9U7NFRI6PMCUCLRjZ6JKgGUg9LK3GltH8XvCWPp9pbwsFg2IVJrru+pJLG+yf p2+qzr7g+shlc1TrNFKpDTKmiLgPs/8oNp0K/srkcDp7P+Q9vzg/dW6RPskAYukBZ2aJ VROw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Ap0HrE1yyAHm1/rpPi75EQ4+ZazeVU8zI4zzPaFZsTY=; b=ZN3EtJ9g1DxSxWtDv2L344e3Kz7TWBEN2CneMOhdu2sdGWQ8sxCYUL9r/22NxZA3Si K05ejLT9rft+0Ki8E+MvpYO59OEuwcqn0Z4r57pV/6Jttqr4IVA/m4Hz9jaz/WnSoGac XeSHv7MnrzLkTSqd82TQIqzw5UKagn+1s5Us91zNmWPWOWXsEQOwamsj6AxTrdmUL2FS FM8Re/dy9xJo9WQvUeAaku4bcQh6r2hVlxjHXAoJiaAI/Igrrd8Zezrp3rZrN49LhF5I EJDcvKwOZLJ5TkwP1WZNfBqm2dHfrrbroLGX8eY4ZAbi0WABYcPSjyfbSeCxORSTn2oY lmgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=z09PZN4G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z9si19820ejm.47.2020.06.03.09.24.21; Wed, 03 Jun 2020 09:24:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=z09PZN4G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726109AbgFCQT6 (ORCPT + 99 others); Wed, 3 Jun 2020 12:19:58 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35174 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbgFCQT6 (ORCPT ); Wed, 3 Jun 2020 12:19:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ap0HrE1yyAHm1/rpPi75EQ4+ZazeVU8zI4zzPaFZsTY=; b=z09PZN4GoJwNNubifeP1bOW3zw GWst+QSWTOzlPMCUnvI72TiABITKfR6LzS2kTE7xHd4gOE3vy21QS3VuYJ4bEYwgSuYt6BZkE3uHz XX206M9IJnD2CPGImAOzZCkqE+719sjnPNHNXjPw5xLi5REKliykc2aq+wwTDSVwvg7E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jgW6b-0044LQ-FY; Wed, 03 Jun 2020 18:19:05 +0200 Date: Wed, 3 Jun 2020 18:19:05 +0200 From: Andrew Lunn To: "Ahmed S. Darwish" Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Thomas Gleixner , "Paul E. McKenney" , "Sebastian A. Siewior" , Steven Rostedt , LKML , Florian Fainelli , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Subject: Re: [PATCH v2 2/6] net: phy: fixed_phy: Remove unused seqcount Message-ID: <20200603161905.GE869823@lunn.ch> References: <20200603144949.1122421-1-a.darwish@linutronix.de> <20200603144949.1122421-3-a.darwish@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200603144949.1122421-3-a.darwish@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2020 at 04:49:45PM +0200, Ahmed S. Darwish wrote: > Commit bf7afb29d545 ("phy: improve safety of fixed-phy MII register > reading") protected the fixed PHY status with a sequence counter. > > Two years later, commit d2b977939b18 ("net: phy: fixed-phy: remove > fixed_phy_update_state()") removed the sequence counter's write side > critical section -- neutralizing its read side retry loop. > > Remove the unused seqcount. > > Signed-off-by: Ahmed S. Darwish > Reviewed-by: Sebastian Andrzej Siewior Reviewed-by: Andrew Lunn Andrew