Subject: Re: [PATCH] Check for online cpus before bringing them up
From: Shaohua Li <shaohua.li@intel.com>
To: Ashok Raj <ashok.raj@intel.com>
Cc: Srivatsa Vaddagiri <vatsa@in.ibm.com>, Andrew Morton <akpm@osdl.org>,
       torvalds@osdl.org, linux-kernel@vger.kernel.org, bryce@osdl.org
In-Reply-To: <20060320172551.A16743@unix-os.sc.intel.com>
References: <20060316174447.GA8184@in.ibm.com>
	 <20060316170814.02fa55a1.akpm@osdl.org> <20060317084653.GA4515@in.ibm.com>
	 <20060317010412.3243364c.akpm@osdl.org> <20060317141322.GB27325@in.ibm.com>
	 <20060318060958.A31112@unix-os.sc.intel.com>
	 <1142903285.11430.1.camel@sli10-desk.sh.intel.com>
	 <20060320172551.A16743@unix-os.sc.intel.com>
Content-Type: text/plain
Date: Tue, 21 Mar 2006 09:36:17 +0800
Message-Id: <1142904977.11430.4.camel@sli10-desk.sh.intel.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1085
Lines: 30

On Mon, 2006-03-20 at 17:25 -0800, Ashok Raj wrote:
> On Tue, Mar 21, 2006 at 09:08:05AM +0800, Shaohua Li wrote:
> > > +
> > > +#ifdef CONFIG_HOTPLUG_CPU
> > > +	/*
> > > +	 * We do warm boot only on cpus that had booted earlier
> > > +	 * Otherwise cold boot is all handled from smp_boot_cpus().
> > > +	 * cpu_callin_map is set during AP kickstart process. Its reset
> > > +	 * when a cpu is taken offline from cpu_exit_clear().
> > > +	 */
> > > +	if (!cpu_isset(cpu, cpu_callin_map))
> > > +		ret = __smp_prepare_cpu(cpu);
> > Does this work for boot time? cpu_callin_map isn't set at boot time for
> > APs.
> > 
> Yes,
> 
> I tested on a 2 way system and it booted fine. This is set durng the kickstart process
> when smp_callin() is called after AP receives boot ipi.
Ok, thanks! It should work for suspend/resume.

Thanks,
Shaohua


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/