Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp897890ybg; Wed, 3 Jun 2020 17:12:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwlApY0UBCe5Db5/YjNkmF5/4TlSUAQkUUy2mdgQLKUym8u8J0GbCJEutjbsDQZvORZv8k4 X-Received: by 2002:a50:f18f:: with SMTP id x15mr1932318edl.228.1591229523703; Wed, 03 Jun 2020 17:12:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591229523; cv=none; d=google.com; s=arc-20160816; b=mPToh/wRaDew1ecWj0Kl2lV0ETCCdJQR7PN+7qTEwkPnD4vQyZWhcqUsPXJBU2m3Ka 0/oHmPrQhBJr/M1oAzdwbicXCtiJ1YO05bouKE1URd2glGPqQqSWkermT4U/6TsUm5t1 QKs6lxau10dvz/PxQaqMCWR/r0LK+BaD/KeM8KOC+Wo0BoRFlDZPDrbtVLzjRFnk/n+3 IFGXdZok+W7LmRhKPzgUx3GUyHdqj1hMRG04Z3EH2R5OCdKYnf6tzcF2OBsvwoOVHRMC TIBgKL5ceKbwrfp0GwKkTk+9VLAqSy1iS90KNlcSxDZQSQl+P4CWIgAY4rM39ClSxETB BVWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=EIihF6kmSDb1N8JHlL5jkFxMKqpdOYk74dHy+uyth5s=; b=lIeWHWajkkSKfaStYCGzlF50lfa+FiFHjjSwsFjnzpUzv0JTNfwA3eq9xuSXP7sy4n XpFVVMhhLbDnkdP4/7VKnC4nx8KPV3KIW4LFTIuO6JiFi5BoztUcNhwrtVQxq/eylbrS GFG0G6Fmv0VW18qYwMZz6dI6KC/yJ4EX+CtJOn+rPd3a5nRxPpuSa3HrDQ0S+EX1lojK qSUeRuD842oxrxm3S7I7kIovILjnTrvyf3GXYOiztJNIWw59oBB5uRRMF5+GdKUiEpAB DAW5DNTNBUeAvdPk0w7gzkQFiQ/WOMJM7HdI6giioUkTSrsT4GYmevBT/FjB4RyvkFCE kz5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l19si606287edq.428.2020.06.03.17.11.40; Wed, 03 Jun 2020 17:12:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726212AbgFDAJN (ORCPT + 99 others); Wed, 3 Jun 2020 20:09:13 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40230 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbgFDAJN (ORCPT ); Wed, 3 Jun 2020 20:09:13 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 054026HM172397; Wed, 3 Jun 2020 20:08:59 -0400 Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 31ek5qvp2p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Jun 2020 20:08:59 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05406YuF018151; Thu, 4 Jun 2020 00:08:57 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma04ams.nl.ibm.com with ESMTP id 31bf480xyr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Jun 2020 00:08:57 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05408s4863111548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 4 Jun 2020 00:08:54 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 974E8A4055; Thu, 4 Jun 2020 00:08:54 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4BA3AA404D; Thu, 4 Jun 2020 00:08:54 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 4 Jun 2020 00:08:54 +0000 (GMT) Received: from [9.206.169.223] (unknown [9.206.169.223]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id DC13FA01A8; Thu, 4 Jun 2020 10:08:52 +1000 (AEST) Subject: Re: [PATCH] cxl: Fix kobject memleak To: "wanghai (M)" , fbarrat@linux.ibm.com, arnd@arndb.de, gregkh@linuxfoundation.org Cc: mpe@ellerman.id.au, imunsie@au1.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20200602120733.5943-1-wanghai38@huawei.com> <72e2df75-b74b-cbd4-4cbe-c0f994d4c4f7@linux.ibm.com> From: Andrew Donnellan Message-ID: Date: Thu, 4 Jun 2020 10:08:52 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-03_13:2020-06-02,2020-06-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 clxscore=1015 cotscore=-2147483648 phishscore=0 mlxlogscore=767 impostorscore=0 suspectscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006030179 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/6/20 9:57 pm, wanghai (M) wrote: > kfree(cr) can be called when > kobject_put()-->kobject_release()-->kobject_cleanup()-->kobj_type->release() > is called.  The kobj_type here is afu_config_record_type Of course, I missed that. In that case Acked-by: Andrew Donnellan Thanks for the fix! -- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited