Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
From:   youling 257 <youling257@gmail.com>
Date:   Thu, 4 Jun 2020 12:35:06 +0800
Message-ID: <CAOzgRdZQjuDfA1wa9AGYjRa-mNWbTNQNCOS60eHzDLeW9WCXpg@mail.gmail.com>
Subject: Re: [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock
To:     walken@google.com
Cc:     Liam.Howlett@oracle.com, akpm@linux-foundation.org,
        daniel.m.jordan@oracle.com, dave@stgolabs.net, hughd@google.com,
        jgg@ziepe.ca, jglisse@redhat.com, jhubbard@nvidia.com,
        ldufour@linux.ibm.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, peterz@infradead.org, rientjes@google.com,
        vbabka@suse.cz, willy@infradead.org, yinghan@google.com,
        youling257 <youling257@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

I have build error about kernel/sys.c,


kernel/sys.c: In function =E2=80=98prctl_set_vma=E2=80=99:

kernel/sys.c:2392:18: error:

=E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem=E2=
=80=99; did you mean

=E2=80=98mmap_base=E2=80=99?

  2392 |  down_write(&mm->mmap_sem);

       |                  ^~~~~~~~

       |                  mmap_base

kernel/sys.c:2402:16: error:

=E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem=E2=
=80=99; did you mean

=E2=80=98mmap_base=E2=80=99?

  2402 |  up_write(&mm->mmap_sem);

       |                ^~~~~~~~

       |                mmap_base


why not rename kernel/sys.c mmap_sem to mmap_lock?


diff --git a/kernel/sys.c b/kernel/sys.c

index 113955fe1c6b..043c04a745a9 100644

--- a/kernel/sys.c

+++ b/kernel/sys.c

@@ -2389,7 +2389,7 @@ static int prctl_set_vma(unsigned long opt,
unsigned long start,

      if (end =3D=3D start)

          return 0;

-    down_write(&mm->mmap_sem);

+    down_write(&mm->mmap_lock);

      switch (opt) {

      case PR_SET_VMA_ANON_NAME:

@@ -2399,7 +2399,7 @@ static int prctl_set_vma(unsigned long opt,
unsigned long start,

          error =3D -EINVAL;

      }

-    up_write(&mm->mmap_sem);

+    up_write(&mm->mmap_lock);

      return error;

  }