Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: i7DgDgNievU0AX3bTaBZfH7X3R0E29bKykT571zLDAmWZ2wXiZ1V3AKWBbBBNh259WCkRNcQUe
 bwPvRX/XPuHPA2HnGnzJRKsWo4MMZcBY4EGqw/Uv1t+qSl47Xujr3Jk52DcETphll3Z6UfBGdj
 TV6xQihKU4xt38XIWiV9ptHHnoSNuqgIHG707JH6IoZnd8iOppHj/hRn8T+Z0F1wx2IHVqwQkI
 Qtm9v9gURfD09g8AefUk8U/0oqXSrey3mYA8pTYnbX+Sk00GRkbEM+sQ/mVwdNy/HgrFkgAj3c
 Lrs=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Dongli Zhang <dongli.zhang@oracle.com>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "james.smart@broadcom.com" <james.smart@broadcom.com>
CC:     "hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format
Thread-Topic: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format
Thread-Index: AQHWMxYvcSawy1rsD0W643/8Q572ww==
Date:   Thu, 4 Jun 2020 06:54:10 +0000
Message-ID: <BYAPR04MB49650D649A53B89DBFE1461286890@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <20200526042118.17836-1-dongli.zhang@oracle.com>
 <38a2cfb9-df2a-c5cb-6797-2b96ef049c7c@oracle.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 67381f92-666e-48b2-e59c-08d8085415b4
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2020 06:54:10.5648
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UpnAyOx9yPQCva99EUNUBpF3uk+kBq9RD45I5MhAsdh1xXtdn2LURtFWrGKAXsAIYW7o2c1yy6dlW3o1Wm1X5lAsWa3gY2jFUN7wEBkNlCk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5911
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/3/20 11:46 PM, Dongli Zhang wrote:=0A=
> May I get feedback for this?=0A=
> =0A=
> For the first time I use fcloop, I set:=0A=
> =0A=
> # echo "wwnn=3D0x3,wwpn=3D0x1" > /sys/class/fcloop/ctl/add_target_port=0A=
> =0A=
> However, I would not be able to move forward if I use "0x3" or "0x1" for =
nvme-fc=0A=
> target or host further. Instead, the address and port should be=0A=
> 0x0000000000000003 and 0x0000000000000001.=0A=
> =0A=
> This patch would sync the requirements of input format for nvme-fc and=0A=
> nvme-fcloop, unless this would break existing test suite (e.g., blktest).=
=0A=
If I remember correctly I don't think we have fc-loop testcases (correct =
=0A=
me if I'm wrong).=0A=
=0A=
Not an fc expert, but having uniform format for the input make sense to =0A=
me (unless there is an explicit reason). I'll let James have a final say.=
=0A=