Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1094836ybg; Thu, 4 Jun 2020 00:27:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAfkV9v6CPAidlDQQNAxWomwlLChHeW1gDQk9+hWXdHDq3P8gF2PgSD/Xbg/5RhAWEKV3Z X-Received: by 2002:a17:906:200a:: with SMTP id 10mr2670033ejo.294.1591255642178; Thu, 04 Jun 2020 00:27:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591255642; cv=none; d=google.com; s=arc-20160816; b=zE1VaRUP8PPecDpILFD9KAGfbQrmTcxnvg3v63CD0DvWoFsoIP627lIZHaF9XeW8sC vp2a4ni2ZeEblbre0HiAUoo47xgiMKbeBpq+ax2ovR2n3Bk/0H/oBcyP3MPRU3zuXj/5 mfk+CIa0mLIH+td4XId/4B6MEJ+sgp7vQYm9ueKYpkc3PbLnshA2uGEglLyzMoeGvai6 8gedSTXNYCT/F8ueMoYdyQQusl1mhseyKAByKIREf/g6TLn/s3jM7JRB1zhq5Et+c/xK IXuD9cqTdj6QACFB5LbK/jYcOuZI9Jl69akO0cS/xiW8gBAyrFpCa7Ad0MNo2vKoE4Aq J4NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=ddfpbOu2It2I92MjYeTIVc4BkhycH5WYxz6j8SXtKfg=; b=XpKUxPYwj7EBq51ZLPN+YojA3C2kcVdmd6r3vXAnNku/6j9f1I5yiuzlCGlJPLAGs2 NDenGt6w5puJCNJWYwmX0ljZXueAFbKZncPNi8nlds8YrmoRYbbuQtb3wx/y4UcEktjo 1FQggFtaK4iQlDrMb5mwerZolcUX84NvU+h1kM6HtwFPyrh3KfqQpb+Nk1GDMyfkvSw7 9ah+AxiXqK8LxaVUoxLGYwEoiTwiySUNPbQIp5CSUo0Bny8tSaq9v1mQ4vvLBrJRjCVC /Drn5ay2qF9XxMi8X/wefFbPRWIEEEievJ6YSHWdh1AS2EzYoEb7Emx+wbrhGqKIEKqu zZPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H73Y6Xwq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d18si1124574edr.366.2020.06.04.00.26.58; Thu, 04 Jun 2020 00:27:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H73Y6Xwq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727105AbgFDHWN (ORCPT + 99 others); Thu, 4 Jun 2020 03:22:13 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53673 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726246AbgFDHWN (ORCPT ); Thu, 4 Jun 2020 03:22:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591255331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ddfpbOu2It2I92MjYeTIVc4BkhycH5WYxz6j8SXtKfg=; b=H73Y6Xwqe3Sylxrs+bZFXtNhIt+5ImrATNpssxXjSsWf9PwJNuHAkRK0Pd6vMO6emj1vij nc8hf2SBHkpkJgb9PoKY6C9Hz+Izk4t+ejy5/noUEClw7gB2Z9Q7B070OVDEaOKitw+yaM dKwzBVMzLeHz5Uvxveq9zTR8G888EqI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-XxyM30UEOh2Iue_W36sjVA-1; Thu, 04 Jun 2020 03:22:09 -0400 X-MC-Unique: XxyM30UEOh2Iue_W36sjVA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79A051005510; Thu, 4 Jun 2020 07:22:07 +0000 (UTC) Received: from [10.36.114.20] (ovpn-114-20.ams2.redhat.com [10.36.114.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57C3A10013D2; Thu, 4 Jun 2020 07:22:04 +0000 (UTC) Subject: Re: [PATCH] x86/mm: use max memory block size with unaligned memory end To: Daniel Jordan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , Andy Lutomirski , Dave Hansen , Michal Hocko , Pavel Tatashin , Peter Zijlstra , Steven Sistare References: <20200604035443.3267046-1-daniel.m.jordan@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: <5827baaf-0eb5-bcea-5d98-727485683512@redhat.com> Date: Thu, 4 Jun 2020 09:22:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200604035443.3267046-1-daniel.m.jordan@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.06.20 05:54, Daniel Jordan wrote: > Some of our servers spend 14 out of the 21 seconds of kernel boot > initializing memory block sysfs directories and then creating symlinks > between them and the corresponding nodes. The slowness happens because > the machines get stuck with the smallest supported memory block size on > x86 (128M), which results in 16,288 directories to cover the 2T of > installed RAM, and each of these paths does a linear search of the > memory blocks for every block id, with atomic ops at each step. With 4fb6eabf1037 ("drivers/base/memory.c: cache memory blocks in xarray to accelerate lookup") merged by Linus' today (strange, I thought this would be long upstream) all linear searches should be gone and at least the performance observation in this patch no longer applies. The memmap init should nowadays consume most time. -- Thanks, David / dhildenb