Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1099483ybg; Thu, 4 Jun 2020 00:36:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRIZoZOIWOLRNDqZy1SXc9KgnsR+mzEiR5DsfX819arS74ak96SMfrXF40KyMRquROAzYa X-Received: by 2002:a17:906:39b:: with SMTP id b27mr2629690eja.421.1591256210200; Thu, 04 Jun 2020 00:36:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591256210; cv=none; d=google.com; s=arc-20160816; b=jbJ7hGXiFz/dGKfDpKkyUzJtpHxPaT9yLAcLeZ7ROAKRWZKaSD8xlSmfOOmiMwMjYv tL7Yk5JSVu/Fa/6UZnErqn26A+NHUlafcjkPveRrr42syGjyS2vQ7//Sa9o6dNSlg41U g5z8vS6hSwiRYio/IGIkQ3vdNUulgwG5kUry32axOKAs7rrstEtOKgswKEW3onowq69y 3wvSN6+e8PA39wP1yjLU/klQs+MfmWpCu2UpDkCP5iDy8caV6itnq652v+ZqLzSQ1F3B 1PtkXq8ZgjYjWfRn1xvdE+Llmlc/QsQAcOS39FTJMYiizI8ghiJSJeWbGx/Ugj2QFfPv Wq5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=baZbUjDWa/MHUTrRpbWl96NZMrQQFXDHB+WEL+0ihJI=; b=reTfvQH2QMJhTAltJKtCmncq+T9L5+QOEym5izl1k/7zuzosyl6ovMl0jR0Ta5qOu4 LRUf+WG+mqx7EhvHu5hcexU/Ne05c2Q6zD7spmbs6NLrceY3ZPxigiVFbyUiAx2cZqnp se/EFRvWt//eLQMPUOD6Eeyo7oEElGcPtr+FbGjQp95SrTy3rVbI9z40zUA+TfA5en7w KdJ/3Wi/7nSLc38awaVOoWio45vLbyqG290hHzxq1p0JTgSZPmCEPgO6H2NlM1U9N6eC /vk6qJXrHSopSBr49B83ElZAZfSs7/9wl7A+J/5wBG4QXFkAnjZs+45rSahqc1Nifk7z wjhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e9si1145282edn.18.2020.06.04.00.36.27; Thu, 04 Jun 2020 00:36:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728043AbgFDHek (ORCPT + 99 others); Thu, 4 Jun 2020 03:34:40 -0400 Received: from mga11.intel.com ([192.55.52.93]:54773 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbgFDHek (ORCPT ); Thu, 4 Jun 2020 03:34:40 -0400 IronPort-SDR: yioJl2FqHoISPIU3vUn+K7IUay0VHQVY+qwFEPGl7pJr0UnXqqb6iEYKZ4GOzDoRdnma9eogdk mwTk5S2D36gA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 00:34:38 -0700 IronPort-SDR: RxY9F998L7LxdaV5tLYQ9VS8rwntKgLWJKUDMupTFuK7X3+7E1qvpjhrUR+DTpy9mfAEbpz3Cw GFerA06WeBfw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,471,1583222400"; d="scan'208";a="348021468" Received: from pg-nxl3.altera.com ([10.142.129.93]) by orsmga001.jf.intel.com with ESMTP; 04 Jun 2020 00:34:35 -0700 From: "Ooi, Joyce" To: Thor Thayer , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dalon Westergreen , Joyce Ooi , Tan Ley Foon , See Chin Liang , Dinh Nguyen , Dalon Westergreen Subject: [PATCH v3 03/10] net: eth: altera: fix altera_dmaops declaration Date: Thu, 4 Jun 2020 15:32:49 +0800 Message-Id: <20200604073256.25702-4-joyce.ooi@intel.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20200604073256.25702-1-joyce.ooi@intel.com> References: <20200604073256.25702-1-joyce.ooi@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dalon Westergreen The declaration of struct altera_dmaops does not have identifier names. Add identifier names to confrom with required coding styles. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi --- v2: no change v3: no change --- drivers/net/ethernet/altera/altera_tse.h | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h index f17acfb579a0..7d0c98fc103e 100644 --- a/drivers/net/ethernet/altera/altera_tse.h +++ b/drivers/net/ethernet/altera/altera_tse.h @@ -385,20 +385,22 @@ struct altera_tse_private; struct altera_dmaops { int altera_dtype; int dmamask; - void (*reset_dma)(struct altera_tse_private *); - void (*enable_txirq)(struct altera_tse_private *); - void (*enable_rxirq)(struct altera_tse_private *); - void (*disable_txirq)(struct altera_tse_private *); - void (*disable_rxirq)(struct altera_tse_private *); - void (*clear_txirq)(struct altera_tse_private *); - void (*clear_rxirq)(struct altera_tse_private *); - int (*tx_buffer)(struct altera_tse_private *, struct tse_buffer *); - u32 (*tx_completions)(struct altera_tse_private *); - void (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *); - u32 (*get_rx_status)(struct altera_tse_private *); - int (*init_dma)(struct altera_tse_private *); - void (*uninit_dma)(struct altera_tse_private *); - void (*start_rxdma)(struct altera_tse_private *); + void (*reset_dma)(struct altera_tse_private *priv); + void (*enable_txirq)(struct altera_tse_private *priv); + void (*enable_rxirq)(struct altera_tse_private *priv); + void (*disable_txirq)(struct altera_tse_private *priv); + void (*disable_rxirq)(struct altera_tse_private *priv); + void (*clear_txirq)(struct altera_tse_private *priv); + void (*clear_rxirq)(struct altera_tse_private *priv); + int (*tx_buffer)(struct altera_tse_private *priv, + struct tse_buffer *buffer); + u32 (*tx_completions)(struct altera_tse_private *priv); + void (*add_rx_desc)(struct altera_tse_private *priv, + struct tse_buffer *buffer); + u32 (*get_rx_status)(struct altera_tse_private *priv); + int (*init_dma)(struct altera_tse_private *priv); + void (*uninit_dma)(struct altera_tse_private *priv); + void (*start_rxdma)(struct altera_tse_private *priv); }; /* This structure is private to each device. -- 2.13.0