Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1100923ybg; Thu, 4 Jun 2020 00:40:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmmeY4qj0H5FnQDFPyU+YjuEVBp/1em+v3qfN0D1HZqaWTSpXEaDeaPZ4RBKeQMBg2U2p5 X-Received: by 2002:a17:906:f8c2:: with SMTP id lh2mr2698536ejb.112.1591256404183; Thu, 04 Jun 2020 00:40:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591256404; cv=none; d=google.com; s=arc-20160816; b=ov8wXHZCNH/ROD6FJPEz0qxln9XUiY964fngZxEDn7Lzv/2n1fopqyCRt2Ud8h2fHa qw3HP6Rv6MwbRf/ulFO/pycK9PCvRI/Io3SY4O7Sc4Nee900bK/DcRHrXKn4BfbSD0Z3 4OBYnAANB7+o5xL/xbm2o8W6l9/qgPQWo6YVjnSvMsH/4mnsTEQWOHIUEdvQJhMsXNvd /AsnRLpO8mRdF7ZeOgZ6rJCI9svwU1d1F8EjBzyg96oyTu/1fEqnn3R2Loa91M2kyDIf Peop0j016H98qRkJV2ptTAAi6UMulOsZaGPczf2Mq1WtAsYFTcz4H45HDyq1I/yIGZRX Op5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=XxgiCmlwU1ptESLZYhJKjGSfvustNCZRKU9NXD+I5i8=; b=GvrC0vNhS9z7ILcDkMoZufOqs5BGyBUX3DrRyYslZXzd99cKr581J1tJPDb+e5m3BU lhVErebroZcyPJxncamddeShVYUjUYOoQMZj+i3NACVS09Vzu95JE35vUrKhaHcSB7iY UuYmNYj9KmCVBYpj+3/kIr7cJaHuzQ+gsFI6yTc7HDEzvU/QbF7P8AAMIcD9BmrVSOCI D26x7LX1nljxFH8w3gkyg0TrlZxYADItIY3C1Elk/EcHslsb5I1OCxU3wrR6AAYqxYWJ g29ye0jJ4hXlWCQjemB3TCzDaFT19DjW5s9zUdfdCmn64W6rA9f4Ccg5DCSHu+CwbxIL yTaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si1216074edf.484.2020.06.04.00.39.40; Thu, 04 Jun 2020 00:40:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728267AbgFDHfK (ORCPT + 99 others); Thu, 4 Jun 2020 03:35:10 -0400 Received: from mga17.intel.com ([192.55.52.151]:32251 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727944AbgFDHfH (ORCPT ); Thu, 4 Jun 2020 03:35:07 -0400 IronPort-SDR: vUq4SSJXPYtf/j85XCR1wccfiEOgm7F00BMvCuwfyZeOzpY7HIh3uPXNSJw6j3Sj/cDOGzy65L GGMOdrW40LYw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 00:34:57 -0700 IronPort-SDR: esa9Ypk3UmCQcpph61KBDknHwtXEW3LOYZMSUOrO0HQaAq7JixmgHhhl9b+tMxNRKA28EEPHaP LluybsG8ezKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,471,1583222400"; d="scan'208";a="348021574" Received: from pg-nxl3.altera.com ([10.142.129.93]) by orsmga001.jf.intel.com with ESMTP; 04 Jun 2020 00:34:53 -0700 From: "Ooi, Joyce" To: Thor Thayer , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dalon Westergreen , Joyce Ooi , Tan Ley Foon , See Chin Liang , Dinh Nguyen Subject: [PATCH v3 06/10] net: eth: altera: Add missing identifier names to function declarations Date: Thu, 4 Jun 2020 15:32:52 +0800 Message-Id: <20200604073256.25702-7-joyce.ooi@intel.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20200604073256.25702-1-joyce.ooi@intel.com> References: <20200604073256.25702-1-joyce.ooi@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dalon Westergreen The sgdma and msgdma header files included function declarations without identifier names for pointers. Add appropriate identifier names. Signed-off-by: Dalon Westergreen Signed-off-by: Joyce Ooi --- v2: this patch is added in patch version 2 v3: no change --- drivers/net/ethernet/altera/altera_msgdma.h | 30 ++++++++++++++------------- drivers/net/ethernet/altera/altera_sgdma.h | 32 +++++++++++++++-------------- 2 files changed, 33 insertions(+), 29 deletions(-) diff --git a/drivers/net/ethernet/altera/altera_msgdma.h b/drivers/net/ethernet/altera/altera_msgdma.h index 9813fbfff4d3..23f5b2a13898 100644 --- a/drivers/net/ethernet/altera/altera_msgdma.h +++ b/drivers/net/ethernet/altera/altera_msgdma.h @@ -6,19 +6,21 @@ #ifndef __ALTERA_MSGDMA_H__ #define __ALTERA_MSGDMA_H__ -void msgdma_reset(struct altera_tse_private *); -void msgdma_enable_txirq(struct altera_tse_private *); -void msgdma_enable_rxirq(struct altera_tse_private *); -void msgdma_disable_rxirq(struct altera_tse_private *); -void msgdma_disable_txirq(struct altera_tse_private *); -void msgdma_clear_rxirq(struct altera_tse_private *); -void msgdma_clear_txirq(struct altera_tse_private *); -u32 msgdma_tx_completions(struct altera_tse_private *); -void msgdma_add_rx_desc(struct altera_tse_private *, struct tse_buffer *); -int msgdma_tx_buffer(struct altera_tse_private *, struct tse_buffer *); -u32 msgdma_rx_status(struct altera_tse_private *); -int msgdma_initialize(struct altera_tse_private *); -void msgdma_uninitialize(struct altera_tse_private *); -void msgdma_start_rxdma(struct altera_tse_private *); +void msgdma_reset(struct altera_tse_private *priv); +void msgdma_enable_txirq(struct altera_tse_private *priv); +void msgdma_enable_rxirq(struct altera_tse_private *priv); +void msgdma_disable_rxirq(struct altera_tse_private *priv); +void msgdma_disable_txirq(struct altera_tse_private *priv); +void msgdma_clear_rxirq(struct altera_tse_private *priv); +void msgdma_clear_txirq(struct altera_tse_private *priv); +u32 msgdma_tx_completions(struct altera_tse_private *priv); +void msgdma_add_rx_desc(struct altera_tse_private *priv, + struct tse_buffer *buffer); +int msgdma_tx_buffer(struct altera_tse_private *priv, + struct tse_buffer *buffer); +u32 msgdma_rx_status(struct altera_tse_private *priv); +int msgdma_initialize(struct altera_tse_private *priv); +void msgdma_uninitialize(struct altera_tse_private *priv); +void msgdma_start_rxdma(struct altera_tse_private *priv); #endif /* __ALTERA_MSGDMA_H__ */ diff --git a/drivers/net/ethernet/altera/altera_sgdma.h b/drivers/net/ethernet/altera/altera_sgdma.h index 08afe1c9994f..3fb201417820 100644 --- a/drivers/net/ethernet/altera/altera_sgdma.h +++ b/drivers/net/ethernet/altera/altera_sgdma.h @@ -6,20 +6,22 @@ #ifndef __ALTERA_SGDMA_H__ #define __ALTERA_SGDMA_H__ -void sgdma_reset(struct altera_tse_private *); -void sgdma_enable_txirq(struct altera_tse_private *); -void sgdma_enable_rxirq(struct altera_tse_private *); -void sgdma_disable_rxirq(struct altera_tse_private *); -void sgdma_disable_txirq(struct altera_tse_private *); -void sgdma_clear_rxirq(struct altera_tse_private *); -void sgdma_clear_txirq(struct altera_tse_private *); -int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *); -u32 sgdma_tx_completions(struct altera_tse_private *); -void sgdma_add_rx_desc(struct altera_tse_private *priv, struct tse_buffer *); -void sgdma_status(struct altera_tse_private *); -u32 sgdma_rx_status(struct altera_tse_private *); -int sgdma_initialize(struct altera_tse_private *); -void sgdma_uninitialize(struct altera_tse_private *); -void sgdma_start_rxdma(struct altera_tse_private *); +void sgdma_reset(struct altera_tse_private *priv); +void sgdma_enable_txirq(struct altera_tse_private *priv); +void sgdma_enable_rxirq(struct altera_tse_private *priv); +void sgdma_disable_rxirq(struct altera_tse_private *priv); +void sgdma_disable_txirq(struct altera_tse_private *priv); +void sgdma_clear_rxirq(struct altera_tse_private *priv); +void sgdma_clear_txirq(struct altera_tse_private *priv); +int sgdma_tx_buffer(struct altera_tse_private *priv, + struct tse_buffer *buffer); +u32 sgdma_tx_completions(struct altera_tse_private *priv); +void sgdma_add_rx_desc(struct altera_tse_private *priv, + struct tse_buffer *buffer); +void sgdma_status(struct altera_tse_private *priv); +u32 sgdma_rx_status(struct altera_tse_private *priv); +int sgdma_initialize(struct altera_tse_private *priv); +void sgdma_uninitialize(struct altera_tse_private *priv); +void sgdma_start_rxdma(struct altera_tse_private *priv); #endif /* __ALTERA_SGDMA_H__ */ -- 2.13.0