Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1109046ybg; Thu, 4 Jun 2020 00:58:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoG8AGqS+7/ypXQ1hB/IJm5wyJx0ZUaaI8hvUGF+l4SSCa/qoyxaDh/RCTJrN3Wta7VPRp X-Received: by 2002:a50:8b05:: with SMTP id l5mr3009928edl.276.1591257509282; Thu, 04 Jun 2020 00:58:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1591257509; cv=pass; d=google.com; s=arc-20160816; b=PcCCUlplffgpvmw6j5MnMmuSdg9+eTLWgRkUfFFigmRP//Iif97kV4teEh6wQjRlXF ropZtKWEgWQildrIIq65v1bA2ri7C278SvTzoWXomlE2pfWAE4/hoQDuL9yxbnZk74v1 xPehkvSFNN8RIQG3e3TcOHM0jeZBzLYrZVdBB+Jj3uCogrfLsvjv0/JRKm9GVUETno2N zc04siNzPylNT1Ag0MpegTSorAnJsw8WnGkJ2JqK+U/dPMo41vlq5HDctOimCosuOfV9 RuGW4uiAVP+xqzEmjPEEUL2bj+JlzAJ1cwLnQFIaUdLL4VQIVnGa4FhG4o+Mb0Hp+aCF hUEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:in-reply-to :content-disposition:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+3mVKoW7JkzpuVgFoR2zPA3o8TzAU16P0Y+IhmTyAYI=; b=Z4+4WPhVLtJRZV6BPz2uQ44DCT/sqr1SIfwo9+SQQF82OiBBqPMJOAgD4aAQ1cX+zD PhKa6uX6H9gAhPIcJqWDd7Nd0lO8edbpammPIcIuba723VBCWOs4E4N+qenPFLrpxM93 zz/97TTJfZpvaxVs7fOa1auXOwoYs1Y7keR+OW1/XpuAliieRPePrPwDC9mZdPcckJ1P whykhc44EU+RAYrUmjGSetPM7/UNMmu8F8OEPn860JGFxoBQAtw+hKcGiDQ12MeHqiKW 3kFK6an8VuwIIn+qaCSebrMaRitaJNKm/CUEx930egtnyoo7yZQ5P1oisyTDgPnlZeML zWCw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Analogixsemi.onmicrosoft.com header.s=selector2-Analogixsemi-onmicrosoft-com header.b=wHU4dNYL; arc=pass (i=1 spf=pass spfdomain=analogixsemi.com dkim=pass dkdomain=analogixsemi.com dmarc=pass fromdomain=analogixsemi.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analogixsemi.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i16si1176415ejh.449.2020.06.04.00.58.06; Thu, 04 Jun 2020 00:58:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@Analogixsemi.onmicrosoft.com header.s=selector2-Analogixsemi-onmicrosoft-com header.b=wHU4dNYL; arc=pass (i=1 spf=pass spfdomain=analogixsemi.com dkim=pass dkdomain=analogixsemi.com dmarc=pass fromdomain=analogixsemi.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analogixsemi.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbgFDHvm (ORCPT + 99 others); Thu, 4 Jun 2020 03:51:42 -0400 Received: from mail-mw2nam10on2111.outbound.protection.outlook.com ([40.107.94.111]:47712 "EHLO NAM10-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725950AbgFDHvm (ORCPT ); Thu, 4 Jun 2020 03:51:42 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kHjHpy6OAynVIlk4r0ci5Q+Do/R9TmtjAk5tg656tCNYw5pf7aT3KxowsPB3vOWzNtikFE6FBktZQgx+25+yjWwncgzzSZ3XUOvLgckAH5Fkdik3XKXutBK2YQT3MmB3SYrzcZSO4KSw60AuNhu6KnR9h2JfFYASflsJvgTUoXRnhSP5cWVfDvx/tSRhGw0O+BWYochYlYgFSYAS6vaOsoiGyps5QC/J+WPMIprg7Vumi7xNB832a5YaELe5CDLRT5IorSlMbirlTqUfRBAr21+hcivk4oKfpqWDIriNJ7X0vmRAUgqtq8qHZYVvKpioVjNzbqZrQMcP8fgKjWdq2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+3mVKoW7JkzpuVgFoR2zPA3o8TzAU16P0Y+IhmTyAYI=; b=cHfaKtLwAlVD4UcTDSvkip4zQxFStt8PLfJ/Ou0hnn8nx0oFB4xUcHUkHA/aSVacHeS9u8PqBquezbXkd7NWAk2zF2z1m5FLoAucy4F9aQun6nd54Xw6nkJ4CPJSB/DIhZXOqOlOHqJoW5Nej7yTkV3+DNymSxLj1gM7zxf8FU6h6NtY5/LPrWs2k9CeQXWL5SCP729Ezd9LhFKRAU9y+hLlRsIf9WUGmYxE3V8zAXD9/gioQXjGPcfGRwPrDT+KFrimeblO/UYIsHCBWcSx5Rj4jWw0CQ+OXzb5nqO20ePuJNnudA085gOsMbX0E0bru5mAc4I4jdoJySVpssZf6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=analogixsemi.com; dmarc=pass action=none header.from=analogixsemi.com; dkim=pass header.d=analogixsemi.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Analogixsemi.onmicrosoft.com; s=selector2-Analogixsemi-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+3mVKoW7JkzpuVgFoR2zPA3o8TzAU16P0Y+IhmTyAYI=; b=wHU4dNYL3PFDBeY9DX3HgQzdb2zTMvcXasu82Rq8jJEQJOKqEujEXgBC/7T8Hv3gjsHZw7suqzF0etkgIALDZUvyJ6XcdwDHsK27ac5ZGa5fQjCH91cRZCPQLZ4cB1qRdnGSM9S8d/wZvcoan7mH2IqC3Net5veHRwKBvT8h8ts= Authentication-Results: analogixsemi.com; dkim=none (message not signed) header.d=none;analogixsemi.com; dmarc=none action=none header.from=analogixsemi.com; Received: from BY5PR04MB6739.namprd04.prod.outlook.com (2603:10b6:a03:229::8) by BY5PR04MB6818.namprd04.prod.outlook.com (2603:10b6:a03:224::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.20; Thu, 4 Jun 2020 07:51:39 +0000 Received: from BY5PR04MB6739.namprd04.prod.outlook.com ([fe80::844e:398b:2165:631b]) by BY5PR04MB6739.namprd04.prod.outlook.com ([fe80::844e:398b:2165:631b%7]) with mapi id 15.20.3066.018; Thu, 4 Jun 2020 07:51:38 +0000 Date: Thu, 4 Jun 2020 15:51:28 +0800 From: Xin Ji To: Hsin-Yi Wang Cc: devel@driverdev.osuosl.org, Laurent Pinchart , Dan Carpenter , Nicolas Boichat , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Pi-Hsun Shih , Sheng Pan Subject: Re: [PATCH v11 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver Message-ID: <20200604075128.GA2581@xin-VirtualBox> References: <3946984ac1024b53b72c2eb39ee41967a2bf9c3d.1589511894.git.xji@analogixsemi.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: HK0PR01CA0055.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::19) To BY5PR04MB6739.namprd04.prod.outlook.com (2603:10b6:a03:229::8) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from xin-VirtualBox (114.247.245.254) by HK0PR01CA0055.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::19) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.3066.18 via Frontend Transport; Thu, 4 Jun 2020 07:51:38 +0000 X-Originating-IP: [114.247.245.254] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 269944bd-f3dc-4bf8-0a26-08d8085c1ccb X-MS-TrafficTypeDiagnostic: BY5PR04MB6818: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 04244E0DC5 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CKZXna2MjkOzc8n5Aw9zUSid2oOvTbN0AniWspBtlQ0o+2l0Sj8EJpnUalzCGtv91leco6Fjkln2YindeOgtyng5DXcTk9jchNoktBJxX8lem1dR2M+i979uQwh90RnLwPYiApgpOa1W5o4Qih6+OtrPbWc+DfK5iI2RpcKdWFsED94MfB1x+WR3eJGR9LCiLVcJGAJKiD61RjxKzhzcAytcj3QgxhNXWnc9Q2kyQsoyogDbJkXl8kN9/AAcT27rLe4sdqvfGotKU+75i60TW18p/nuiyY+BHGI3t6hYSo7ly5NSvbitS3zeAbqeH9TTZiR0OqdzMu3NIaB4EIKG7VaER3HyLPZRXD3T7d7NcJDpyM0HiWNmk6TCP7WwXAiVUABklS+OfNf/SYWZhwF1vA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR04MB6739.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(366004)(136003)(39840400004)(376002)(346002)(186003)(16526019)(86362001)(8676002)(956004)(66476007)(8936002)(966005)(66946007)(6916009)(7416002)(6666004)(33716001)(316002)(6496006)(52116002)(66556008)(54906003)(478600001)(33656002)(26005)(9686003)(53546011)(107886003)(4326008)(4744005)(2906002)(55016002)(5660300002)(1076003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: ZJPaVOMUxtE7pVMYNFmVe866UPB0dQ8Iaa2MCgb7+b44Uv9J4c6iATCfxUGtWiuLWm7k9KC7kebjXn5f85hyXacAcI6uEmLcncuFH6/Kfg8wfiW7mq+l4yXkvSGXl98qg49TpsgirHyAWMtWKimDOK3W+tkI0R0/whY43tehHhdDqMmI3KyW453IQBVEHajJq+SnNj35yI/3R1s8xUtLehTm023/YMOySjuivunYW4FrQEB60bdx0YaAzRNxJsoil76uFznP6raNAfCm4cchT0rRHrebkdITCKH8DofhjgmqbdyW8ohk9utpUHk3d0ORR1AWrrOcG1Xnj/PkejCX7mK5o3qjRfa+Cm6sq9LiuDBSLBR74XzFaGJfmrvV9oYQoCs7H4f/uif6XA7DRksOhq47SuSBhQu/cLiepjudATQjfyR5hVLntxqFvPSbnNGl6BqpUu9AVfNk3qUDVxqjdvGk/hxVsQspMcGCPAoyJnI= X-OriginatorOrg: analogixsemi.com X-MS-Exchange-CrossTenant-Network-Message-Id: 269944bd-f3dc-4bf8-0a26-08d8085c1ccb X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2020 07:51:38.8267 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8/psuGyIkh7DAAI/DwZFO6hmfJEijtD4YtwxsKTKCgMylid2XmP2hbi4MJ7OJs/MC1baj2H86KsvK7LDto1EBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6818 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 01, 2020 at 12:14:09PM +0800, Hsin-Yi Wang wrote: > On Fri, May 15, 2020 at 2:53 PM Xin Ji wrote: > > > + > > +static int anx7625_bridge_attach(struct drm_bridge *bridge) > > Latest drm_bridge api: > > int (*attach)(struct drm_bridge *bridge, > enum drm_bridge_attach_flags flags); > > https://elixir.bootlin.com/linux/v5.7-rc7/source/include/drm/drm_bridge.h#L70 > > > +{ > > + struct anx7625_data *ctx = bridge_to_anx7625(bridge); > > + int err; Hi Hsin-Yi, thanks for the comment, I'll fix it in the version v12 Thanks, Xin