Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
In-Reply-To: <CANN689Gy2aUgF7oE2UE3miHf7fah=9zM3KZ512Mj6kJTiRz3Xg@mail.gmail.com>
References: <CAOzgRdZQjuDfA1wa9AGYjRa-mNWbTNQNCOS60eHzDLeW9WCXpg@mail.gmail.com>
 <CANN689Gy2aUgF7oE2UE3miHf7fah=9zM3KZ512Mj6kJTiRz3Xg@mail.gmail.com>
From:   youling 257 <youling257@gmail.com>
Date:   Thu, 4 Jun 2020 16:16:08 +0800
Message-ID: <CAOzgRdZejnB+ruxhZhKBBw9rgnfNbiLSensa-2+20FTkSxrwwA@mail.gmail.com>
Subject: Re: [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock
To:     Michel Lespinasse <walken@google.com>
Cc:     "Liam R . Howlett" <Liam.Howlett@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Daniel Jordan <daniel.m.jordan@oracle.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Hugh Dickins <hughd@google.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Jerome Glisse <jglisse@redhat.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Laurent Dufour <ldufour@linux.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-mm <linux-mm@kvack.org>,
        Peter Zijlstra <peterz@infradead.org>,
        David Rientjes <rientjes@google.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Matthew Wilcox <willy@infradead.org>,
        Ying Han <yinghan@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2020-06-04 13:57 GMT+08:00, Michel Lespinasse <walken@google.com>:
> On Wed, Jun 3, 2020 at 9:35 PM youling 257 <youling257@gmail.com> wrote:
>> I have build error about kernel/sys.c,
>>
>> kernel/sys.c: In function =E2=80=98prctl_set_vma=E2=80=99:
>> kernel/sys.c:2392:18: error:
>> =E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem=
=E2=80=99; did you mean
>> =E2=80=98mmap_base=E2=80=99?
>>   2392 |  down_write(&mm->mmap_sem);
>>        |                  ^~~~~~~~
>>        |                  mmap_base
>> kernel/sys.c:2402:16: error:
>> =E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem=
=E2=80=99; did you mean
>> =E2=80=98mmap_base=E2=80=99?
>>   2402 |  up_write(&mm->mmap_sem);
>>        |                ^~~~~~~~
>>        |                mmap_base
>>
>> why not rename kernel/sys.c mmap_sem to mmap_lock?
>
> The proper fix would be to use the mmap locking apis defined in
> include/linux/mmap_lock.h instead.
>
> However I would like more information about your report. Did you apply
> the series yourself ? If so, what base tree did you apply it onto ? If
> not, what tree did you use that already included the series ?

I build linux next-20200603 tree have the kernel/sys.c error.

> Thanks,
>
> --
> Michel "Walken" Lespinasse
> A program is never fully debugged until the last user dies.
>