Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Jun 2020 10:29:01 +0100
From:   Russell King - ARM Linux admin <linux@armlinux.org.uk>
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     Thara Gopinath <thara.gopinath@linaro.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: v5.7: new core kernel option missing help text
Message-ID: <20200604092901.GE1551@shell.armlinux.org.uk>
References: <20200603173150.GB1551@shell.armlinux.org.uk>
 <jhjh7vshvwl.mognet@arm.com>
 <20200603184500.GC1551@shell.armlinux.org.uk>
 <CAKfTPtBdN30ChMgFqqT1bzeU6HExXEQFrQjxbCK-hRT4HEiQkQ@mail.gmail.com>
 <20200603195853.GD1551@shell.armlinux.org.uk>
 <jhjftbbj3qi.mognet@arm.com>
 <a34fcb9a-ba4b-0c9e-328f-1244c2720ed2@linaro.org>
 <jhjeeqvi3m1.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <jhjeeqvi3m1.mognet@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 04, 2020 at 10:26:27AM +0100, Valentin Schneider wrote:
> 
> On 04/06/20 01:48, Thara Gopinath wrote:
> > Hi Russel/Valentin
> >
> > The feature itself like Valentin explained below allows scheduler to be
> > aware of cpu capacity reduced due to thermal throttling.
> > arch_set_thermal_pressure feeds the capped capacity to the scheduler and
> > hence the feature makes sense only if arch_set_thermal_pressure is
> > implemented. Having said that arch_set_thermal_pressure is implemented
> > in arch_topology driver for arm and arm64 platforms. But the feature
> > itself is not bound to arm/arm64 platforms. So it would make it wrong to
> > add a "depends on (ARM || ARM64) option."
> >
> > I agree with Vincent that allowing user to choose this option is
> > probably not the best. IMO, this should be enabled by default in arm64
> > defconfig considering both GENERIC_ARCH_TOPOLOGY and CPU_FREQ_THERMAL
> > are enabled by default.
> 
> Right, I had skimmed over that but it probably does make more sense not
> to bother users with it.
> 
> > So if it is acceptable three things to be done are:
> > 1. Add the help text.
> > 2. Don't allow SCHED_THERMAL_PRESSURE configurable by user
> > 3. Enable it by default in arm64 defconfig
> 
> ... and arm as well, I suppose?

If it's not a user visible option, then there's no point it being in
defconfig.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up