Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1240310ybg; Thu, 4 Jun 2020 04:55:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybStqqHosrXvwuD4DAgETDyHyDeQBLOgd8own9IswzWKhHMY5tY3STuovUTUUoa+edWXaL X-Received: by 2002:a17:906:e05:: with SMTP id l5mr3810738eji.318.1591271746772; Thu, 04 Jun 2020 04:55:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591271746; cv=none; d=google.com; s=arc-20160816; b=CUkdXRtsuqDuX/NueYHTcTe6okEbuBAyx9WkVtksAd4N4E+xhMp3EKHsK4HtEKuW32 dA/PuD0xrOBVLvykMWvLC9c57yPJJ8tWNL6Jafmq2u6s1CMfwU2lOLndllVgHgKO2SfI 5/Y+4daHaZByCvPh+zkSlMng1/FEC4s1GEoQW3ThKLJM4S5To0JvqTl8iPVilGcT1tJp udrO0SwgUdAIYDH2zId8V0GshosGRlsTLa1jOq0MCd2alOiyK2UMfOHZX4KBZFuJJSTr +pRrFSvZXVUi4DcOtvXWVEDSaAwLtQ6rZ52056UVOpa10rTzUgNa1ug+66ak1UYJFMwQ Dd5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=PyngVfpfgoVzMd9sc/mEkuTaLbeh8Khsg6w6+v1SH/g=; b=GHiVUAFxoO2MVgVoLGOHpktZjgfaO9MVLAF+qr/HgrXECCihuN0G/bJJOGmzRyn4Nz a9DIBh6H+lQOspcg/xbDOJgMn6XJSZ/bKzK6L+6e3aZwvCBBCwN7QTJr50sS5VRFCjtS 8A7c+VM7bFcLsGvwsseMMoOt+msyKU8cttWJFKS8SfAuTD2nU/+0o7kKVWQDetEnlzBD vlN86+XRqBQWoqffqzQkltsepUCoH+kU6unZVspDhzS2IZVqMIBA6U9CnkS0V1Zf7tQo 0XuGjOqaRKVNTnQ47y7XZyb6aHpHcLrds7R1/FJ5SbBPf15ZIrC6IUIO7i3p2ZmdmIwC kCZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b27si1605224ejq.568.2020.06.04.04.55.22; Thu, 04 Jun 2020 04:55:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727988AbgFDLxJ (ORCPT + 99 others); Thu, 4 Jun 2020 07:53:09 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:53700 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727893AbgFDLxJ (ORCPT ); Thu, 4 Jun 2020 07:53:09 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49d40Y47TRz1rtM7; Thu, 4 Jun 2020 13:53:01 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49d40Y2Ddhz1r56D; Thu, 4 Jun 2020 13:53:01 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Q9mVzZMxjuGW; Thu, 4 Jun 2020 13:52:59 +0200 (CEST) X-Auth-Info: 5CjvBET+Il7a/uMAYVIacXVkxQpxbbjavGecvHXooG4= Received: from [127.0.0.1] (unknown [195.140.253.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 4 Jun 2020 13:52:59 +0200 (CEST) Subject: Re: [PATCH v3 0/2] usb: xhci: Load Raspberry Pi 4 VL805's firmware To: Nicolas Saenz Julienne , mbrugger@suse.com, u-boot@lists.denx.de, bmeng.cn@gmail.com, linux-kernel@vger.kernel.org Cc: sjg@chromium.org, m.szyprowski@samsung.com, s.nawrocki@samsung.com, mark.kettenis@xs4all.nl References: <20200505162607.334-1-nsaenzjulienne@suse.de> <2a8f0190c9d418cee89451c7dc3a227b9d0b5f45.camel@suse.de> <9aea19124817a3d9fa004ec495ea6d1036d2dc8d.camel@suse.de> From: Marek Vasut Message-ID: <6b7f6a54-56e4-8f62-4000-438b98deee06@denx.de> Date: Thu, 4 Jun 2020 13:52:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/4/20 1:18 PM, Nicolas Saenz Julienne wrote: > On Mon, 2020-06-01 at 17:27 +0200, Marek Vasut wrote: >> On 6/1/20 4:41 PM, Nicolas Saenz Julienne wrote: >>> On Mon, 2020-06-01 at 13:12 +0200, Marek Vasut wrote: >>>> On 6/1/20 1:09 PM, Nicolas Saenz Julienne wrote: >>>>> On Mon, 2020-06-01 at 12:53 +0200, Marek Vasut wrote: >>>>>> On 6/1/20 12:47 PM, Nicolas Saenz Julienne wrote: >>>>>>> On Tue, 2020-05-05 at 18:26 +0200, Nicolas Saenz Julienne wrote: >>>>>>>> Newer revisions of the RPi4 need their xHCI chip, VL805, firmware >>>>>>>> to >>>>>>>> be >>>>>>>> loaded explicitly. Earlier versions didn't need that as they where >>>>>>>> using >>>>>>>> an EEPROM for that purpose. This series takes care of setting up >>>>>>>> the >>>>>>>> relevant infrastructure and run the firmware loading routine at >>>>>>>> the >>>>>>>> right moment. >>>>>>>> >>>>>>>> Note that this builds on top of Sylwester Nawrocki's "USB host >>>>>>>> support >>>>>>>> for Raspberry Pi 4 board" series. >>>>>>>> >>>>>>>> --- >>>>>>> >>>>>>> Please don't forget about this series. The new 8GB RPi4 contains >>>>>>> this HW >>>>>>> design >>>>>>> change and USB will not work without it. See this discussion on the >>>>>>> downstream >>>>>>> kernel github, where other OS/bootloaders are hitting the issue: >>>>>>> >>>>>>> https://github.com/raspberrypi/firmware/issues/1402 >>>>>>> >>>>>>> Otherwise, the Linux version of this is already in linux-next: >>>>>>> >>>>>>> >>> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/usb/host/pci-quirks.c?h=next-20200529&id=c65822fef4adc0ba40c37a47337376ce75f7a7bc >>>>>> We're already at 2020.07-rc3 , so unless this is a bugfix (does not >>>>>> look >>>>>> that way), this will have to wait for next release cycle. >>>>> >>>>> Of course. As long as it eventually gets in I'm happy (not implying this >>>>> specific series is flawless, but the overall mechanism). I'm just >>>>> worried >>>>> this >>>>> gets lost. >>>>> >>>>>> Also, it seems >>>>>> there was a lengthy ongoing discussion, is that already sorted out ? >>>>> >>>>> Well, there was some discussion on how to incorporate the platform >>>>> specific >>>>> callback into XCHI's code. Which this revision of the series addresses. >>>>> But, >>>>> IIRC, that's pretty much it as far as discussion is concerned. >>>> >>>> Oh, right, since the firmware loading hook looks like a reset hook, why >>>> isn't that implemented via reset controller API instead ? >>> >>> That could be pretty clean, I hadn't though about it that way. Some >>> questions: >>> >>> - Being a PCIe device the XHCI controller doesn't show up in the device- >>> tree. I >>> guess it could be added as a child node of pcie-brcmstb, but is that even >>> acceptable? >> >> Yes, there are other such DTs . >> >>> - Same goes for xhci-pci being a consumer of the reset controller. Given the >>> reset scheme is board specific (the chip can be found all over the place, >>> but >>> the firmware loading scheme is 100% RPi specific), to what extent we can >>> introduce that as a binding? >> >> I'm not sure what you're asking me here, you'll just have some reset >> controller in a DT and a phandle from the xhci-controller to this reset >> controller. > > Sorry I wasn't clear, overall my concern here is that xhic-pci maintainers, > both in u-boot y linux (as I'd like to have the same solution on both sides, > since it involves changes in dt), might see it as too platform specific to add > it into an otherwise generic xhci-pci implmentation. > > But nevermind, I'll just post the series and see what happens :). I think it should be OK, thanks.