Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 4 Jun 2020 04:34:21 -0700
From:   Matthew Wilcox <willy@infradead.org>
To:     Anshuman Khandual <anshuman.khandual@arm.com>
Cc:     linux-mm@kvack.org, hughd@google.com, daniel.m.jordan@oracle.com,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Zi Yan <ziy@nvidia.com>, John Hubbard <jhubbard@nvidia.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] mm/vmstat: Add events for THP migration without split
Message-ID: <20200604113421.GU19604@bombadil.infradead.org>
References: <1591243245-23052-1-git-send-email-anshuman.khandual@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1591243245-23052-1-git-send-email-anshuman.khandual@arm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 04, 2020 at 09:30:45AM +0530, Anshuman Khandual wrote:
> Add the following new VM events which will help in validating THP migration
> without split. Statistics reported through these new events will help in
> performance debugging.
> 
> 1. THP_MIGRATION_SUCCESS
> 2. THP_MIGRATION_FAILURE
> 
> THP_MIGRATION_FAILURE in particular represents an event when a THP could
> not be migrated as a single entity following an allocation failure and
> ended up getting split into constituent normal pages before being retried.
> This event, along with PGMIGRATE_SUCCESS and PGMIGRATE_FAIL will help in
> quantifying and analyzing THP migration events including both success and
> failure cases.

> +Quantifying Migration
> +=====================
> +Following events can be used to quantify page migration.
> +
> +- PGMIGRATE_SUCCESS
> +- PGMIGRATE_FAIL
> +- THP_MIGRATION_SUCCESS
> +- THP_MIGRATION_FAILURE
> +
> +THP_MIGRATION_FAILURE in particular represents an event when a THP could not be
> +migrated as a single entity following an allocation failure and ended up getting
> +split into constituent normal pages before being retried. This event, along with
> +PGMIGRATE_SUCCESS and PGMIGRATE_FAIL will help in quantifying and analyzing THP
> +migration events including both success and failure cases.

First, I'd suggest running this paragraph through 'fmt'.  That way you
don't have to care about line lengths.

Second, this paragraph doesn't really explain what I need to know to
understand the meaning of these numbers.  When Linux attempts to migrate
a THP, one of three things can happen:

 - It is migrated as a single THP
 - It is migrated, but had to be split
 - Migration fails

How do I turn these four numbers into an understanding of how often each
of those three situations happen?  And why do we need four numbers to
report three situations?

Or is there something else that can happen?  If so, I'd like that explained
here too ;-)