Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932360AbWCUJdW (ORCPT ); Tue, 21 Mar 2006 04:33:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932361AbWCUJdW (ORCPT ); Tue, 21 Mar 2006 04:33:22 -0500 Received: from webapps.arcom.com ([194.200.159.168]:24844 "EHLO webapps.arcom.com") by vger.kernel.org with ESMTP id S932360AbWCUJdW (ORCPT ); Tue, 21 Mar 2006 04:33:22 -0500 Message-ID: <441FC856.90602@arcom.com> Date: Tue, 21 Mar 2006 09:33:10 +0000 From: David Vrabel User-Agent: Debian Thunderbird 1.0.7 (X11/20051017) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Olivier Galibert CC: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/23] driver core: platform_get_irq*(): return -ENXIO on error References: <11428920373568-git-send-email-gregkh@suse.de> <11428920383013-git-send-email-gregkh@suse.de> <20060321001336.GB84147@dspnet.fr.eu.org> In-Reply-To: <20060321001336.GB84147@dspnet.fr.eu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 21 Mar 2006 09:33:14.0910 (UTC) FILETIME=[7A8243E0:01C64CCA] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 26 Olivier Galibert wrote: > On Mon, Mar 20, 2006 at 02:00:38PM -0800, Greg Kroah-Hartman wrote: > >>platform_get_irq*() cannot return 0 on error as 0 is a valid IRQ on some >>platforms, return -ENXIO instead. > > > 0 is NO_IRQ, and can not be a valid IRQ number, ever. A > platform_get_irq*() returning 0 as a valid irq is buggy. > > Check http://lkml.org/lkml/2005/11/21/211 Regardless, it does make sense to make these functions to return a -ve error code as is standard. David Vrabel -- David Vrabel, Design Engineer Arcom, Clifton Road Tel: +44 (0)1223 411200 ext. 3233 Cambridge CB1 7EA, UK Web: http://www.arcom.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/