Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1518056ybg; Thu, 4 Jun 2020 11:41:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDzgeTxYIDW3cGyohFUB5Z994ga+9kd63fA4phKWPf9yNvd/o508WWfSrksiiQ3ZZif8sg X-Received: by 2002:a17:906:138b:: with SMTP id f11mr4962878ejc.288.1591296105514; Thu, 04 Jun 2020 11:41:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591296105; cv=none; d=google.com; s=arc-20160816; b=eDdDjiBeJzUEDZYdeV+WiwhL0g1aQT5g7QIlAXIE/ge+s1GBydcpbj6RZq3enO0w4T 1XL8m+PFIHUrnrpVyW4aH3OIbarBoJCy3ZRklk+7F3Z5u6gCnc4Y3QlBb8IMNp4Cbt1t DiyycmHsMAPkNfgFkbWe3tUQIvZszf0nbLXIXmeS1YHOz6Uj2OcFGi9VBcG79D3bMyQf JmKmhC4JufizYyuWVA7QQDPSOpRPal9tYeq3bb07BY7duFEzpZf8NBO07SAZ7mJLIIXD EwNF+K5vzsX+JcbH9bEG7QfUU9X/qUvF+Qqb34u6j2ciV7mohkT40cp2yz6znQHBKkKD 9GTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=v7x5eoVBNXrY/ubkH6GtMBW6ukJW7AyohP2tJCjpHIw=; b=r+2qBslUw3FV8Zpkz62RSu7y6U1qit/wLDQ2e0OYHiXdyYWI/mnwWYLoJ8upnB3kDd O/O5N6K+FBdfwbAoXm/1C6iM7Jimm8/0WVZ/gtUaj7kl0Vq6RNMvKid6xs2rCHCbnjAa oYnF5eVzVsYDXLxUcckEJ0RKNzTTbl6D2IvCMYgh2zVWUwbT6BtbfLiyE7URY4rU4DiT HQEqYfhLZlIOP0hi+NlULP/nOcz1ezsBWUPDpAgXs+Q2wNkeP7q+0OSGV7u0k4HY2dxh Uq0xaWPYYprZ/XK8Pt8Ao9mvdVaaMhiFklBQDrOeqD+4e16D4cHYBnfgCal6UYNYJ56k voJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e9si2085342eja.348.2020.06.04.11.41.22; Thu, 04 Jun 2020 11:41:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728515AbgFDNVG (ORCPT + 99 others); Thu, 4 Jun 2020 09:21:06 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:51864 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728450AbgFDNVE (ORCPT ); Thu, 4 Jun 2020 09:21:04 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 1EC851C0BD2; Thu, 4 Jun 2020 15:21:03 +0200 (CEST) Date: Thu, 4 Jun 2020 15:21:02 +0200 From: Pavel Machek To: Dan Murphy Cc: Jacek Anaszewski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Greg KH Subject: Re: [PATCH v18 4/4] leds: multicolor: Introduce a multicolor class definition Message-ID: <20200604132102.GC7222@duo.ucw.cz> References: <20200324181434.24721-1-dmurphy@ti.com> <20200324181434.24721-5-dmurphy@ti.com> <9a707fe6-31c6-da9e-9372-51ca21bf3c88@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sHrvAb52M6C8blB9" Content-Disposition: inline In-Reply-To: <9a707fe6-31c6-da9e-9372-51ca21bf3c88@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sHrvAb52M6C8blB9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > +Description: read > > > + Maximum intensity level for the LED color within the array. > > > + The max intensities for each color must be entered based on the > > > + color_index array. > > I wonder if we should mention here that each LED within a cluster should > > have the same maximum intensity for linear color lightness calculation > > via brightness file. >=20 > Does it really have to? Yes it does. Anything else is unneccessarily complex. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --sHrvAb52M6C8blB9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXtj1PgAKCRAw5/Bqldv6 8qatAJ4u6W8VQzR8pf32e+wX/xMXb1e10QCeOOW9iBoX3jcny6s21E32jzpK7jM= =DoKN -----END PGP SIGNATURE----- --sHrvAb52M6C8blB9--