Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200603232311.GA205619@roeck-us.net> <20200604083512.GN6857@suse.de>
 <CAHk-=wj2_YdxPaRFqBUUDZvtZKKG5To2KJhciJmDbchW2NFLnw@mail.gmail.com> <20200604140617.e340dd507ee68b0a05bd21cb@linux-foundation.org>
In-Reply-To: <20200604140617.e340dd507ee68b0a05bd21cb@linux-foundation.org>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu, 4 Jun 2020 14:12:14 -0700
Message-ID: <CAHk-=wjm+RrcTjB7KYCCsOouE2EyzRcwWUE9TVq6OCYYAt9Zyw@mail.gmail.com>
Subject: Re: [PATCH] mm/vmalloc: track which page-table levels were modified
To:     Andrew Morton <akpm@linux-foundation.org>,
        Mike Rapoport <rppt@linux.ibm.com>
Cc:     Joerg Roedel <jroedel@suse.de>, Guenter Roeck <linux@roeck-us.net>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 4, 2020 at 2:06 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> As discussed over in
> https://lore.kernel.org/linux-mm/20200604164814.GA7600@kernel.org/,
> Mike's "mm: remove __ARCH_HAS_5LEVEL_HACK" patchset
> (http://lkml.kernel.org/r/20200414153455.21744-1-rppt@kernel.org) is
> expected to fix this.  5level-fixup.h gets removed.

Ok, even better.

That said, the commentary about "why is p.._alloc_track() in such a
core header file, when it's only used by two special cases" is
probably still true regardless of the 5-level fixup header.. I assume
Mike didn't do those kinds of changes?

Yeah, I'm probably flailing at windmills, but I do dislike how we
often end up just growing the very core headers that get included by
everybody without ever trying to fix that uncontrolled growth..

               Linus