Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1611808ybg; Thu, 4 Jun 2020 14:24:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuB3iHv9at6JrG/5AbBt0j+jUeUO5zJvLg1+GaIHDZBqwkMr5U5FreaLpunxNr7Hc3wehW X-Received: by 2002:a17:906:8253:: with SMTP id f19mr5819741ejx.470.1591305862009; Thu, 04 Jun 2020 14:24:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591305862; cv=none; d=google.com; s=arc-20160816; b=nr0C42W3vPrLtezsxj+Dj1xT9l/k0zbqboM2XH9/2Ul0c2E/MKWqVYThZYaQQaFra8 JuUhCFsrQZb7wxXJ5v1WBy3jgWGayhK86NebnZcuPFVpBnevsKRXpuEA3WO8S2NptUzO daI4Bw9CzUpByX+gNKsGYNYK22HgejhE0K8cWvfk1JlcdOLluuwxdwpJ1zxCSbq4CJDL bqTyRlotdCczq+XO3N8O1WF37NbkSLFumGCUp+udVA5GKhpWD8JwRpI6wZfAoANhicFf uGba/cM2WH3KTn+STw8mYgtF8skkL+CWyL04UmuSURgT4udfbr7Dobs+pWBAW3aNAd0o IZ/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=Kk0oeQrHqTNinAfrahDoJthlIDzqfb/a+0X3Zq1wBxU=; b=MTVovxt6eF9jmUacfLVmzK2Vwo/3upryTlR9lsq0Hf+M4jJn7b+xJGM09nBQT+Ronv lybk6m5bG64w8lPNzOd5JIH2uTWoAY1Ws29Lp6GbLV6dRruQXUMc/S6tRRKUunAM2c+r 87D4SJWgYjJdkTQz7NTCwcdCIMxycRYVhbwZo+EMDEPe68JfP+7jBM8/yaScLZyY6V+m GWHFb/hv2/kziTj7YUh37iMDhDvVVrlvvKx3StEGsp7OtgVjNyz/wLQqWMqpo50rhfA/ P+bTVqQH96BC7AZQ/gqJy7jsQVTM+F4JKXTHhdPp8nQzymNHM2y2C6OHlDgSccEZni/k zwzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oz26si2374570ejb.252.2020.06.04.14.23.59; Thu, 04 Jun 2020 14:24:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729770AbgFDQOl (ORCPT + 99 others); Thu, 4 Jun 2020 12:14:41 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:30694 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728972AbgFDQOl (ORCPT ); Thu, 4 Jun 2020 12:14:41 -0400 Received: from [192.168.1.91] (unknown [77.207.133.132]) (Authenticated sender: marc.w.gonzalez) by smtp4-g21.free.fr (Postfix) with ESMTPSA id D6B3219F5E1; Thu, 4 Jun 2020 18:13:26 +0200 (CEST) Subject: Re: [PATCH v5 0/2] Small devm helper for devm implementations From: Marc Gonzalez To: Stephen Boyd , Michael Turquette , Kuninori Morimoto , Russell King , Sudip Mukherjee , Dmitry Torokhov , Guenter Roeck , Bjorn Andersson , Robin Murphy , Geert Uytterhoeven , Arnd Bergmann , Ard Biesheuvel , Greg Kroah-Hartman , Rafael Wysocki , Suzuki Poulose , Mark Rutland Cc: linux-clk , Linux ARM , LKML References: Message-ID: <217b892d-678f-8c32-b9ab-a3dd238c197a@free.fr> Date: Thu, 4 Jun 2020 18:13:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks like this series has fallen through the cracks :( Greg, you would be taking the drivers/base/devres.c changes? As mentioned in patch 2, "This patch needs testing on a platform with many clocks." (I've only tested using a trivial kernel module) On 10/03/2020 11:11, Marc Gonzalez wrote: > Differences from v4 to v5 > x Fix the grammar in devm_add comments [Geert] > x Undo an unrelated change in devm_clk_put [Geert] > > Differences from v3 to v4 > x Add a bunch of kerneldoc above devm_add() [Greg KH] > x Split patch in two [Greg KH] > > Differences from v2 to v3 > x Make devm_add() return an error-code rather than the raw data pointer > (in case devres_alloc ever returns an ERR_PTR) as suggested by Geert > x Provide a variadic version devm_vadd() to work with structs as suggested > by Geert > x Don't use nested ifs in clk_devm* implementations (hopefully simpler > code logic to follow) as suggested by Geert > > Marc Gonzalez (2): > devres: Provide new helper for devm functions > clk: Use devm_add in managed functions > > drivers/base/devres.c | 28 ++++++++++++ > drivers/clk/clk-devres.c | 97 +++++++++++++++------------------------- > include/linux/device.h | 3 ++ > 3 files changed, 67 insertions(+), 61 deletions(-)