Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1671085ybg; Thu, 4 Jun 2020 16:13:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPu7l2wXlFc9JTOMDFZsxrbLzdSODHJbUALy8y7sQ4JOOaEOM6cw0SceT1dN380VZzB9pE X-Received: by 2002:a17:906:7746:: with SMTP id o6mr6168079ejn.75.1591312417533; Thu, 04 Jun 2020 16:13:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591312417; cv=none; d=google.com; s=arc-20160816; b=hZbcUXmgpLAH3R0YHKAxpV788IO/E81cFIvsqWkfcmySGrpxgJcqhCIEqtsJolN7i5 ojRQ+8w3fA01NGfNFi8vMkMFO0eh9p35y9FLqVeMptk8BEOF3YZ1IjrG3mkTCV66CpQ1 jHdFiFlVGxSuU1Zl7gcWrHOF0qQPaQZhKWFW8dECd0pSJMkaabGnX7CjnGn6WCLcNvqx HByt1JYI6AysHVafBwapQfo2Y5rUWwtEfwtjulFj+WMf7qzK5g2/dIAUmD3qsK7drVPp OPS/aRSa4a2alWuZ0B+dauaNTtLwOYP5a8GPCzBSGVPt5TD8Vt9rpOFq0OjX/b3XSxlb t9fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:subject:autocrypt:from:references:cc:to:reply-to; bh=vHTgK20kdVzmm54e8GnMkcKHYCp77QqjCEndPPdZBrM=; b=kqqLv2JteJqIvocv/ukDA3IEO03B8GBa85I/cxCCplzhZCE2S+ebeycCULR8AWIyuy 1X7AXKVX17fNjIEpwB03v06kqyk78xuYUeKEp+zeMQzj195LRFyZ9VfrlsRFBcF+HPdN 5P5kHoXLQLTV4njgsa3q8whjjXLpeu4jXlPkcJQ7dhT91Ql2C12G7dsjYVDBkSgQqcBk ZIe2ySZjlANDfHDtrExURhTOjGO5aCLS6AXlcU1xG/gUwYFdxhmaCWPwG4N3h3FhGjmy IZ4m9xrtAMsIWFWSvNDd7OJ6eEtSyJWaFyQaEetmo1aVdhN12p6vuASdDpTYxdrxuyHZ gM5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b14si2325647eju.419.2020.06.04.16.13.14; Thu, 04 Jun 2020 16:13:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728187AbgFDVnN (ORCPT + 99 others); Thu, 4 Jun 2020 17:43:13 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:46228 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725943AbgFDVnM (ORCPT ); Thu, 4 Jun 2020 17:43:12 -0400 Received: by mail-lj1-f196.google.com with SMTP id z9so9172446ljh.13; Thu, 04 Jun 2020 14:43:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=vHTgK20kdVzmm54e8GnMkcKHYCp77QqjCEndPPdZBrM=; b=tgIeVp//9AV0k+cMCuFyvKjJPZkjSMLoPvLtW+MNq7D3P/sUnvv6/yZL+0PasyVBui WpZiP3PrbE3jz7IaIDIYQqOpZoF+natldL5QkSfFE2TEeFwtwpuBLv4MqWI9L/cOiBAy BZZZiF00yf0SPx8ARpiPSAaiwkF8OCEbmjZF7ORwvghSDeNtMl2vFLl7oTaiDnWX57MM EjhA1Y12KW9hlQScGmvpCdsBXTNXOWwR1W3Mur+mSlwPyURQlRzte4wvFE8NDMx5onyc wKMIVC/Ywyhzet8BIt5dO6qYQmexb5xf2utugsVaC+XOUqE4TcRluXPPRzWieISH1JSX yTrw== X-Gm-Message-State: AOAM533gss0c+lJUhWuoQPMWobOP7WB0m1l9tsIP08GrFZP9JmQScnVT 2cip/BRgyGPqyieTFUoK2MG9r3kz X-Received: by 2002:a2e:9dd8:: with SMTP id x24mr3361691ljj.304.1591306989329; Thu, 04 Jun 2020 14:43:09 -0700 (PDT) Received: from [10.68.32.147] (broadband-37-110-38-130.ip.moscow.rt.ru. [37.110.38.130]) by smtp.gmail.com with ESMTPSA id u16sm150340lji.58.2020.06.04.14.43.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2020 14:43:08 -0700 (PDT) Reply-To: efremov@linux.com To: Dexuan-Linux Cui , Dexuan Cui , Michael Kelley Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-hyperv@vger.kernel.org, Linux SCSI List , Linux Kernel Mailing List References: <20200604130406.108940-1-efremov@linux.com> From: Denis Efremov Autocrypt: addr=efremov@linux.com; keydata= mQINBFsJUXwBEADDnzbOGE/X5ZdHqpK/kNmR7AY39b/rR+2Wm/VbQHV+jpGk8ZL07iOWnVe1 ZInSp3Ze+scB4ZK+y48z0YDvKUU3L85Nb31UASB2bgWIV+8tmW4kV8a2PosqIc4wp4/Qa2A/ Ip6q+bWurxOOjyJkfzt51p6Th4FTUsuoxINKRMjHrs/0y5oEc7Wt/1qk2ljmnSocg3fMxo8+ y6IxmXt5tYvt+FfBqx/1XwXuOSd0WOku+/jscYmBPwyrLdk/pMSnnld6a2Fp1zxWIKz+4VJm QEIlCTe5SO3h5sozpXeWS916VwwCuf8oov6706yC4MlmAqsQpBdoihQEA7zgh+pk10sCvviX FYM4gIcoMkKRex/NSqmeh3VmvQunEv6P+hNMKnIlZ2eJGQpz/ezwqNtV/przO95FSMOQxvQY 11TbyNxudW4FBx6K3fzKjw5dY2PrAUGfHbpI3wtVUNxSjcE6iaJHWUA+8R6FLnTXyEObRzTS fAjfiqcta+iLPdGGkYtmW1muy/v0juldH9uLfD9OfYODsWia2Ve79RB9cHSgRv4nZcGhQmP2 wFpLqskh+qlibhAAqT3RQLRsGabiTjzUkdzO1gaNlwufwqMXjZNkLYu1KpTNUegx3MNEi2p9 CmmDxWMBSMFofgrcy8PJ0jUnn9vWmtn3gz10FgTgqC7B3UvARQARAQABtCFEZW5pcyBFZnJl bW92IDxlZnJlbW92QGxpbnV4LmNvbT6JAlcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQR2VAM2ApQN8ZIP5AO1IpWwM1AwHwUCXsQtuwUJB31DPwAKCRC1IpWwM1Aw H3dQD/9E/hFd2yPwWA5cJ5jmBeQt4lBi5wUXd2+9Y0mBIn40F17Xrjebo+D8E5y6S/wqfImW nSDYaMfIIljdjmUUanR9R7Cxd/Z548Qaa4F1AtB4XN3W1L49q21h942iu0yxSLZtq9ayeja6 flCB7a+gKjHMWFDB4nRi4gEJvZN897wdJp2tAtUfErXvvxR2/ymKsIf5L0FZBnIaGpqRbfgG Slu2RSpCkvxqlLaYGeYwGODs0QR7X2i70QGeEzznN1w1MGKLOFYw6lLeO8WPi05fHzpm5pK6 mTKkpZ53YsRfWL/HY3kLZPWm1cfAxa/rKvlhom+2V8cO4UoLYOzZLNW9HCFnNxo7zHoJ1shR gYcCq8XgiJBF6jfM2RZYkOAJd6E3mVUxctosNq6av3NOdsp1Au0CYdQ6Whi13azZ81pDlJQu Hdb0ZpDzysJKhORsf0Hr0PSlYKOdHuhl8fXKYOGQxpYrWpOnjrlEORl7NHILknXDfd8mccnf 4boKIZP7FbqSLw1RSaeoCnqH4/b+ntsIGvY3oJjzbQVq7iEpIhIoQLxeklFl1xvJAOuSQwII I9S0MsOm1uoT/mwq+wCYux4wQhALxSote/EcoUxK7DIW9ra4fCCo0bzaX7XJ+dJXBWb0Ixxm yLl39M+7gnhvZyU+wkTYERp1qBe9ngjd0QTZNVi7MbkCDQRbCVF8ARAA3ITFo8OvvzQJT2cY nPR718Npm+UL6uckm0Jr0IAFdstRZ3ZLW/R9e24nfF3A8Qga3VxJdhdEOzZKBbl1nadZ9kKU nq87te0eBJu+EbcuMv6+njT4CBdwCzJnBZ7ApFpvM8CxIUyFAvaz4EZZxkfEpxaPAivR1Sa2 2x7OMWH/78laB6KsPgwxV7fir45VjQEyJZ5ac5ydG9xndFmb76upD7HhV7fnygwf/uIPOzNZ YVElGVnqTBqisFRWg9w3Bqvqb/W6prJsoh7F0/THzCzp6PwbAnXDedN388RIuHtXJ+wTsPA0 oL0H4jQ+4XuAWvghD/+RXJI5wcsAHx7QkDcbTddrhhGdGcd06qbXe2hNVgdCtaoAgpCEetW8 /a8H+lEBBD4/iD2La39sfE+dt100cKgUP9MukDvOF2fT6GimdQ8TeEd1+RjYyG9SEJpVIxj6 H3CyGjFwtIwodfediU/ygmYfKXJIDmVpVQi598apSoWYT/ltv+NXTALjyNIVvh5cLRz8YxoF sFI2VpZ5PMrr1qo+DB1AbH00b0l2W7HGetSH8gcgpc7q3kCObmDSa3aTGTkawNHzbceEJrL6 mRD6GbjU4GPD06/dTRIhQatKgE4ekv5wnxBK6v9CVKViqpn7vIxiTI9/VtTKndzdnKE6C72+ jTwSYVa1vMxJABtOSg8AEQEAAYkCPAQYAQgAJgIbDBYhBHZUAzYClA3xkg/kA7UilbAzUDAf BQJexC4MBQkHfUOQAAoJELUilbAzUDAfPYoQAJdBGd9WZIid10FCoI30QXA82SHmxWe0Xy7h r4bbZobDPc7GbTHeDIYmUF24jI15NZ/Xy9ADAL0TpEg3fNVad2eslhCwiQViWfKOGOLLMe7v zod9dwxYdGXnNRlW+YOCdFNVPMvPDr08zgzXaZ2+QJjp44HSyzxgONmHAroFcqCFUlfAqUDO T30gV5bQ8BHqvfWyEhJT+CS3JJyP8BmmSgPa0Adlp6Do+pRsOO1YNNO78SYABhMi3fEa7X37 WxL31TrNCPnIauTgZtf/KCFQJpKaakC3ffEkPhyTjEl7oOE9xccNjccZraadi+2uHV0ULA1m ycHhb817A03n1I00QwLf2wOkckdqTqRbFFI/ik69hF9hemK/BmAHpShI+z1JsYT9cSs8D7wb aF/jQVy4URensgAPkgXsRiboqOj/rTz9F5mpd/gPU/IOUPFEMoo4TInt/+dEVECHioU3RRrW EahrGMfRngbdp/mKs9aBR56ECMfFFUPyI3VJsNbgpcIJjV/0N+JdJKQpJ/4uQ2zNm0wH/RU8 CRJvEwtKemX6fp/zLI36Gvz8zJIjSBIEqCb7vdgvWarksrhmi6/Jay5zRZ03+k6YwiqgX8t7 ANwvYa1h1dQ36OiTqm1cIxRCGl4wrypOVGx3OjCar7sBLD+NkwO4RaqFvdv0xuuy4x01VnOF Subject: Re: [PATCH] scsi: storvsc: Use kzfree() in storvsc_suspend() Message-ID: <696a6af8-744d-01b5-4a37-5320887e9108@linux.com> Date: Fri, 5 Jun 2020 00:43:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Hi Denis, > When I added the function storvsc_suspend() several months ago, somehow I forgot > to remove the unnecessary memset(). Sorry! > > The buffer is recreated in storvsc_resume() -> storvsc_connect_to_vsp() -> > storvsc_channel_init() -> stor_device->stor_chns = kcalloc(...), so I believe > the memset() can be safely removed. I'm not sure that I understand your description. As for me, memset with 0 before memory freeing is required only for sensitive information and it's completely unrelated to memory zeroing during allocation with kzalloc/kcalloc. If it's not a sensitive information then memset could be safely removed. > Can you please make a v2 patch for it and Cc my corporate email "decui" (in To)? Yes, of course. Could I add "Suggested-by"? Thanks, Denis