Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1682071ybg; Thu, 4 Jun 2020 16:33:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3P8IzlozVb/P9tlw8l8K+SqLjZVwP9hNZVBOno1T9TH1A6947t71iUL4Djp0yhxYT1x/f X-Received: by 2002:a17:906:470a:: with SMTP id y10mr6329146ejq.535.1591313635305; Thu, 04 Jun 2020 16:33:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591313635; cv=none; d=google.com; s=arc-20160816; b=GEK7ZLLiVw/7mWvv68Wrd0txYP8y5dKTz/Di1Q0acOWVQYoxCixlucO+4P7PY5vL10 GE0nDhwmE85yhUlM1CwtKnj6+vdPwmGNVza2+y7ykYemOdj9OVVxoMZ2PbWZrrK4Iaqa 9lfIKQsP4wX5kAJVD4lNhlNXHjg4JJOOJ6UOjl6t29MDjvVA7dJ+oZ6+Mlz3EvR/zo6R g3Zv2jx1jpjPZcOa2Hwi2zA6UjC3cP0D9s8UUjCcoyH5CMkX6Z1pcOE9Hqf2C9fsW9jC 2QLlY9r+dbLVmAo3iKBW1nNj8umj5Jx9qAQZlS3LPu8GPV7WcYY9W6pe4s+EfksES4Bx wd3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:dkim-signature:dkim-filter; bh=SZx4mnEbdx0jLMmcddD/XN81elbqYULWlDyY/auymck=; b=EDeC2yrCFLEnmpxhpJ33nGj1/S1V5X46tFjqi3ZgWOc8rLCRGMMJe5SljX12GFUY9G OVLjNY/UvQvyAIeGJmsRMyXeFjvBafH/l3m4RDgXHRI8jZ1UcXWYrHJzP9o/lNUvpXP1 flZ9Z7OJ3iXxQJO7O+YoseAZ3R00HzQRI0faVjFGdYaVxooi5Oxa8dPfRKzK7pYbUhvV 0IsDiHOzhmQFqi7rPlw7dDVI5yNWr2DrheFBIpbD7e1W69RBf742fQOpCo0GVBggNI02 dzK3Gh7KtEKVODm6pwqkUsINTqkE+FufEEnuesvvDVYQE5VIPgmnIWgw57NQSXDqWe4S niTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b="Q4bE/Ayl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n11si3057341ejl.677.2020.06.04.16.33.33; Thu, 04 Jun 2020 16:33:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b="Q4bE/Ayl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725961AbgFDX2p (ORCPT + 99 others); Thu, 4 Jun 2020 19:28:45 -0400 Received: from linux.microsoft.com ([13.77.154.182]:57494 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725863AbgFDX2p (ORCPT ); Thu, 4 Jun 2020 19:28:45 -0400 Received: from [192.168.1.14] (unknown [76.104.235.235]) by linux.microsoft.com (Postfix) with ESMTPSA id 711F420B7185; Thu, 4 Jun 2020 16:28:44 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 711F420B7185 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1591313324; bh=SZx4mnEbdx0jLMmcddD/XN81elbqYULWlDyY/auymck=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=Q4bE/AylBlX91O0u3WVMecvFQfigbf1uRWUFyUFkIlchLbAke0ZcQrCaCsSXSNVsw cFTQe3Jx9DvJPcyYSTrODJf30EJCcoiIhvV+tjVoqCUmcZ4E6xNYugNNGYgdkBM6y9 Wg/I8QdU9qF0hCTPjAQQUKmXUTuCUAKSjuSlf0og= Subject: Re: [PATCH] software node: recursively unregister child swnodes From: Jordan Hand To: Greg Kroah-Hartman Cc: Heikki Krogerus , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-next@vger.kernel.org References: <20200604193623.16946-1-jorhand@linux.microsoft.com> <20200604201523.GA1308830@kroah.com> Message-ID: <4f3020b9-b693-c8cc-ec3e-8df96da45f33@linux.microsoft.com> Date: Thu, 4 Jun 2020 16:28:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/4/20 1:57 PM, Jordan Hand wrote: > On 6/4/20 1:15 PM, Greg Kroah-Hartman wrote: >> On Thu, Jun 04, 2020 at 12:36:23PM -0700, jorhand@linux.microsoft.com > > That said, I suppose just ordering the nodes so that children come > before parents would also be fine. My thinking was just that accepting > any node ordering is simpler. > Oh, actually I just tried that out and software_node_register_nodes doesn't allow this (parents must be added before children). So I still think software_node_register_nodes and software_node_unregister_nodes are made more useful if children are removed recursively. I'll make some changes for v2 to make the change less far-reaching + better documentation. Thanks, Jordan