Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Jun 2020 02:25:41 +0200
From:   Stefano Brivio <sbrivio@redhat.com>
To:     Liu Yiding <yidingx.liu@intel.com>
Cc:     kernel test robot <lkp@intel.com>, Florian Westphal <fw@strlen.de>,
        Pablo Neira Ayuso <pablo@netfilter.org>,
        LKML <linux-kernel@vger.kernel.org>, lkp@lists.01.org
Subject: Re: [LKP] Re: [netfilter] e32a4dc651:
 BUG:using_smp_processor_id()in_preemptible
Message-ID: <20200605022541.3d702fe1@redhat.com>
In-Reply-To: <7dd4f0d2-34a7-8086-99cb-424ff2e039ca@intel.com>
References: <20200603084934.GF12456@shao2-debian>
        <20200605002323.501b1cc6@redhat.com>
        <7dd4f0d2-34a7-8086-99cb-424ff2e039ca@intel.com>
Organization: Red Hat
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 5 Jun 2020 08:15:07 +0800
Liu Yiding <yidingx.liu@intel.com> wrote:

> Hi,
>=20
> On 6/5/20 6:23 AM, Stefano Brivio wrote:
> > Hi,
> >
> > On Wed, 3 Jun 2020 16:49:34 +0800
> > kernel test robot <lkp@intel.com> wrote:
> > =20
> >> Greeting,
> >>
> >> FYI, we noticed the following commit (built with gcc-7):
> >>
> >> commit: e32a4dc6512ce3c1a1920531246e7037896e510a ("netfilter: nf_table=
s: make sets built-in")
> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> >>
> >> in testcase: kernel-selftests
> >> with following parameters:
> >>
> >> 	group: kselftests-netfilter =20
> > I couldn't find this information in the report. Would it be possible to
> > have here an indication of what kselftest specifically is failing?
> > There are a number of tests in that group. I have an obvious suspicion
> > here (nft_concat_range.sh), but it would be nice to know, in general. =
=20
>=20
> Yes, it's nft_concat_range.sh caused this error.
>=20
> ```
>=20
> [=C2=A0 165.249447] # selftests: netfilter: nft_concat_range.sh
> [=C2=A0 165.249453]
> [=C2=A0 165.295336] # TEST: reported issues
> [=C2=A0 165.295342]
> [=C2=A0 165.316525] BUG: using smp_processor_id() in preemptible [0000000=
0]=20
> code: nft/6247
> [=C2=A0 165.319547] caller is nft_pipapo_insert+0x464/0x610 [nf_tables]
> [=C2=A0 165.321846] CPU: 1 PID: 6247 Comm: nft Not tainted=20
> 5.6.0-rc5-01595-ge32a4dc6512ce3 #1
>=20
> ```

Thanks for confirming. I think it would really be helpful to have the
specific test name in the report, in the future.

> And i think this error is caused by some kconfigs.
>
> This test was passed until we enabled all kconfigs defined in=20
> netfilter/config. :-(

Then most likely this was CONFIG_NF_TABLES_SET not enabled, which goes
away with Florian's commit e32a4dc6512c as the whole feature is now
built in.

--=20
Stefano