Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1778415ybg; Thu, 4 Jun 2020 19:53:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy26hz2+l0ShoSTVCpV3jkeEN18UfZhwCxV+plsAwgq/xHaiQqlOJ+PvRQsZFk8oKGiFE12 X-Received: by 2002:a17:906:7e50:: with SMTP id z16mr6832594ejr.277.1591325614750; Thu, 04 Jun 2020 19:53:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591325614; cv=none; d=google.com; s=arc-20160816; b=whxcL32DWMQTO5NCGWRmbGFdis0ICU5jyRwtTFO3zrwCa3X3wPlpSYUNBiSIOM4B/S lk1TYLy3vH24ZHC4gyqVBB5A+6ewmd8f9P8bWPWxwha7JH3OJlM+g5osi3shtIvdq972 lDgbousnfPnw6xwgskCB4k8Ml0dS0iqBL38oHmfh9ZRdjyIYNLnfkUlBe2sFG+afhqa5 wJrfLAgaUHNtQdl0V2eI7uagYp4OQ/yFUlAw/wbWIW2BUPwScjMo35OvrTv9IuU55ob/ yTOivu+yCWks6KUlnMlEkjcf/HYA5+9yuztf9exprAd4obV+83LmEomwkDF5/PDax6ML a6zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=m4JBrQLU9j68jdVov8Re9jkn4rmu/LsHOY21OSp01uo=; b=MljIa9aFbYdReup7nEKj34E/bsma0+94ojZ0U8+FHxzNSkuxuxauBYQs4RUvTgYAJv cy9JGRioeNeBul1AjLSbvdLbJiRT8xGGA6jtBjugPq55Y45GX2rNwYlLFnYY54/o9pc/ pkduS/78DvNxD0YIhvqLRg0xhMhXdroH1XJB+Dy5o+FryKfnNfEbR/irfgPdtBZq4s/N ZPc2isYXkqr/OvODHchA2HyoCP/vU6sVBfv27wdtm5hbDt+WMrpx97Oj/sZsN1NuzPVj lb5oE4SRSFwPnKDFjstsaMju2NWtx+y+qfw4LNwm1qn7Tpi149hV04zbT6nxmF3S2DsG Uywg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CNlMs2qG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n4si2904207edy.244.2020.06.04.19.53.10; Thu, 04 Jun 2020 19:53:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CNlMs2qG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726054AbgFECt1 (ORCPT + 99 others); Thu, 4 Jun 2020 22:49:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbgFECt0 (ORCPT ); Thu, 4 Jun 2020 22:49:26 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D641C08C5C0; Thu, 4 Jun 2020 19:49:26 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id r2so8700655ioo.4; Thu, 04 Jun 2020 19:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=m4JBrQLU9j68jdVov8Re9jkn4rmu/LsHOY21OSp01uo=; b=CNlMs2qGApz3O6STGqKMu+TNa8kXVV+xawEo1JOHuC6p1h6nWG/JjrDynlohD+2L+6 O1MDMz2tcxItl4OeKS1SCCrXrLI8mUrRvXIpauENeO+SHg24riAKEwhPp/gNpAOc7ENm JqLAaijwUZa94yqXe2EmpcJb8ed4l/u2PAIk3pkUyBUZJwcVyc3jINZ0PnHo/EEupJXp 5ler2opm+MXjUFBtbjYzjWvAYAiIhJvAtCo26R5aJF0T2JJKQqnwRTMKpO7rj+hBBG+m tsnDFVnseXRrLjuy+oZXCz8RhVNLovx73zs3LZejXNOGUe+P7w9mLEiEhjG948BqHfTG fplA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=m4JBrQLU9j68jdVov8Re9jkn4rmu/LsHOY21OSp01uo=; b=ofEcOYE3OzQqrUHjk5dfE8CHyNnm6wQcZwUa8OPZhzka6YCVr+heIdhTtn+Mx8X/9h offGY2Q5JVjSOeyFJKu+9+p9eLrjQUrelArRAvbRrnUAftXyB8zy2lLcsSCw4baBzBX9 VHMTsYmQF5eGz0Cz9r120qiqy8o4W5AYqimsVrE2nYhis/Kw7o2S8tACMsjpbHsXdLYU vIvB4Ml5IwYHpi9Scn6ybeSxN2vHSIASK2jTynGLiCjVLqfoRZfXKV5B2PacB54eayjc ytIC1xr4AUCGJzJRXdfvcNxOfNsc7hMVKEj+X+6zTHaUcaRJF2CN0tKDvHFSW3iR0Nbk Piwg== X-Gm-Message-State: AOAM531mjsEk5O54b7ewnUt2Taw37HmimnpF7ZH2FW6bVUynuwAKJMqV t1a6NrZdcTaii2jrJjO6wP4= X-Received: by 2002:a02:6007:: with SMTP id i7mr6759168jac.1.1591325365617; Thu, 04 Jun 2020 19:49:25 -0700 (PDT) Received: from cs-u-kase.dtc.umn.edu (cs-u-kase.cs.umn.edu. [160.94.64.2]) by smtp.googlemail.com with ESMTPSA id w78sm2366272ilk.14.2020.06.04.19.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2020 19:49:25 -0700 (PDT) From: Navid Emamdoost To: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: emamd001@umn.edu, wu000273@umn.edu, kjlu@umn.edu, smccaman@umn.edu, Navid Emamdoost Subject: [PATCH] gpio: rcar: handle pm_runtime_get_sync failure case Date: Thu, 4 Jun 2020 21:49:19 -0500 Message-Id: <20200605024919.56177-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails. Signed-off-by: Navid Emamdoost --- drivers/gpio/gpio-rcar.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 7284473c9fe3..eac1582c70da 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -250,8 +250,10 @@ static int gpio_rcar_request(struct gpio_chip *chip, unsigned offset) int error; error = pm_runtime_get_sync(p->dev); - if (error < 0) + if (error < 0) { + pm_runtime_put(p->dev); return error; + } error = pinctrl_gpio_request(chip->base + offset); if (error) -- 2.17.1