Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200602045506.40574-1-navid.emamdoost@gmail.com> <f928fb02-47d7-b6f9-6198-bd549d6ac6b5@nvidia.com>
In-Reply-To: <f928fb02-47d7-b6f9-6198-bd549d6ac6b5@nvidia.com>
From:   Navid Emamdoost <navid.emamdoost@gmail.com>
Date:   Fri, 5 Jun 2020 01:13:35 -0500
Message-ID: <CAEkB2EREyXRS18Kq+6428MAJKtB3VoZdVqbJOODVJ7Pk9bzLLQ@mail.gmail.com>
Subject: Re: [PATCH] spi: tegra114: missing put on pm_runtime_get_sync failure
To:     Jon Hunter <jonathanh@nvidia.com>
Cc:     Laxman Dewangan <ldewangan@nvidia.com>,
        Mark Brown <broonie@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Navid Emamdoost <emamd001@umn.edu>,
        Qiushi Wu <wu000273@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
        mccamant@cs.umn.edu
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 5, 2020 at 1:09 AM Jon Hunter <jonathanh@nvidia.com> wrote:
>
>
> On 02/06/2020 05:55, Navid Emamdoost wrote:
> > the call to pm_runtime_get_sync increments the counter even
> > in case of failure leading to incorrect ref count.
> > Call pm_runtime_put if pm_runtime_get_sync fails.
> >
> > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> > ---
> >  drivers/spi/spi-tegra114.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
> > index 83edabdb41ad..dccd2ac1a975 100644
> > --- a/drivers/spi/spi-tegra114.c
> > +++ b/drivers/spi/spi-tegra114.c
> > @@ -974,6 +974,7 @@ static int tegra_spi_setup(struct spi_device *spi)
> >               dev_err(tspi->dev, "pm runtime failed, e = %d\n", ret);
> >               if (cdata)
> >                       tegra_spi_cleanup(spi);
> > +             pm_runtime_put(tspi->dev);
> >               return ret;
> >       }
> >
> > @@ -1398,6 +1399,7 @@ static int tegra_spi_probe(struct platform_device *pdev)
> >       ret = pm_runtime_get_sync(&pdev->dev);
> >       if (ret < 0) {
> >               dev_err(&pdev->dev, "pm runtime get failed, e = %d\n", ret);
> > +             pm_runtime_put(&pdev->dev);
> >               goto exit_pm_disable;
> >       }
>
> I am wondering if it is better we use put_sync() here to ensure that
> this happens before we exit the probe.

To be honest I am not sure when to use different flavors of
pm_runtime_put (like pm_runtime_put_noidle,
pm_runtime_put_autosuspend, pm_runtime_put_sync, pm_runtime_put,
pm_runtime_put_sync_suspend). I'd appreciate it if you could give me a
pointer on how to decide on this.

>
> Jon
>
> --
> nvpublic


-- 
Navid.