Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date:   Fri, 05 Jun 2020 12:32:14 +0530
From:   dikshita@codeaurora.org
To:     Hans Verkuil <hverkuil@xs4all.nl>
Cc:     Nicolas Dufresne <nicolas@ndufresne.ca>,
        linux-media@vger.kernel.org, stanimir.varbanov@linaro.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        vgarodia@codeaurora.org, majja@codeaurora.org, jdas@codeaurora.org,
        linux-media-owner@vger.kernel.org
Subject: Re: [RFC] METADATA design using V4l2 Request API
In-Reply-To: <ad61378b-e279-d161-adaa-17349adf183e@xs4all.nl>
References: <1588918890-673-1-git-send-email-dikshita@codeaurora.org>
 <d1179bc1-662b-615f-0f9b-67693fe8c906@xs4all.nl>
 <fb96e2c09346e7831a0af99c0fe9f94c@codeaurora.org>
 <7be1070ee7aad1f48fc6de63523da8e1bc952dc8.camel@ndufresne.ca>
 <ad61378b-e279-d161-adaa-17349adf183e@xs4all.nl>
Message-ID: <5356c146a340d951b8d492373f349199@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Hans, Nicolas,

On 2020-05-29 13:01, Hans Verkuil wrote:
> On 29/05/2020 04:18, Nicolas Dufresne wrote:
>> Le jeudi 28 mai 2020 à 16:18 +0530, dikshita@codeaurora.org a écrit :
>>>> not allowed. So I need to know more about this.
>>>> Regards,
>>>>        Hans
>>> 
>>> we need this for use cases like HDR10+ where metadata info is part of
>>> the bitstream.
>>> 
>>> To handle such frame specific data, support for request api on 
>>> capture
>>> plane would be needed.
>> 
>> I have a bit of a mixed impression here. Considering how large the 
>> ioctl
>> interface overhead is, relying on HW parser to extract this medata 
>> woud be the
>> last thing I would consider.
>> 
>> Instead, I'm quite convince we can achieve greater and likely 
>> zero-copy
>> perfromance by locating this header in userspace. So everytime I see 
>> this kind
>> of API, were the HW is *needed* to parse a trivial bit of bistream, I 
>> ended
>> thinking that we simply craft this API to expose this because the HW 
>> can do it,
>> but no further logical thinking or higher level design seems to have 
>> been
>> applied.
>> 
>> I'm sorry for this open critic, but are we designing this because the 
>> HW
>> designer exposed that feature? This is so low complexity to extract in
>> userspace, with the bonus that we are not forced into expanding the
>> representation to another form immediatly, as maybe the display will 
>> be able to
>> handle that form directly (where converting to a C structure and then 
>> back to
>> some binary format to satisfy DRM property seems very sub-optimal).
>> 
>> Nicolas
>> 
> 
> Nicolas raises good questions: it would help if you can give more
> detailed information
> about the hardware. We had similar discussions with Xilinx about
> HDR10+ (see this
> thread: https://www.spinics.net/lists/linux-media/msg163297.html).
> 
> There is no clear answer at the moment on how to handle dynamic HDR 
> metadata.
> It will help if we have some more information how different SoCs handle 
> this
> in hardware.
> 
> Regards,
> 
> 	Hans

As per Widevine Level 1 requirement, it needs “Hardware Protected Video 
Path”.
Hence, in case of secure bitstream decoding, we need decoder metadata 
delivered from HW.
CPU cannot parse secure bitstream and extract them.
Apart from this, there are other metadata like "histogram" which is not 
part of the bitstream
and generated by hardware

Thanks,
Dikshita