Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <87pnagf912.fsf@nanos.tec.linutronix.de> <87367a91rn.fsf@nanos.tec.linutronix.de>
 <CAJfpegvchB2H=NK3JU0BQS7h=kXyifgKD=JHjjT6vTYVMspY2A@mail.gmail.com> <1a1c32fe-d124-0e47-c9e4-695be7ea7567@redhat.com>
In-Reply-To: <1a1c32fe-d124-0e47-c9e4-695be7ea7567@redhat.com>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Fri, 5 Jun 2020 09:35:40 +0200
Message-ID: <CAJfpegvwBx49j9XwJZXcSUK=V9oHES31zB2sev0xwS4wfhah-g@mail.gmail.com>
Subject: Re: system time goes weird in kvm guest after host suspend/resume
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>, kvm@vger.kernel.org,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 4, 2020 at 10:14 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 04/06/20 21:28, Miklos Szeredi wrote:
> > time(2) returns good time, while clock_gettime(2) returns bad time.
> > Here's an example:
> >
> > time=1591298725 RT=1591300383 MONO=39582 MONO_RAW=39582 BOOT=39582
> > time=1591298726 RT=1591300383 MONO=39582 MONO_RAW=39582 BOOT=39582
> > time=1591298727 RT=1591300383 MONO=39582 MONO_RAW=39582 BOOT=39582
> > time=1591298728 RT=1591300383 MONO=39582 MONO_RAW=39582 BOOT=39582
> > time=1591298729 RT=1591300383 MONO=39582 MONO_RAW=39582 BOOT=39582
> >
> > As you can see, only time(2) is updated, the others remain the same.
> > date(1) uses clock_gettime(CLOCK_REALTIME) so that shows the bad date.
> >
> > When the correct time reaches the value returned by CLOCK_REALTIME,
> > the value jumps exactly 2199 seconds.
>
> clockid_to_kclock(CLOCK_REALTIME) is &clock_realtime, so clock_gettime
> calls ktime_get_real_ts64, which is:
>
>
>         do {
>                 seq = read_seqcount_begin(&tk_core.seq);
>
>                 ts->tv_sec = tk->xtime_sec;
>                 nsecs = timekeeping_get_ns(&tk->tkr_mono);
>
>         } while (read_seqcount_retry(&tk_core.seq, seq));
>
>         ts->tv_nsec = 0;
>         timespec64_add_ns(ts, nsecs);
>
> time(2) instead should actually be gettimeofday(2), which just returns
> tk->xtime_sec.  So the problem is the nanosecond part which is off by
> 2199*10^9 nanoseconds, and that is suspiciously close to 2^31...

Yep: looking at the nanosecond values as well, the difference is
exactly 2199023255552 which is 2^41.

Thanks,
Miklos