Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1927234ybg; Fri, 5 Jun 2020 00:53:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYWCSP5p0Q5RBDzBXHZyhy8ntYl9VnXjA/I/dAf0ydAuNDizQodC8Kt3avMRo0CbnapfQk X-Received: by 2002:a17:906:940d:: with SMTP id q13mr7639300ejx.534.1591343588447; Fri, 05 Jun 2020 00:53:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591343588; cv=none; d=google.com; s=arc-20160816; b=X4PeQ0EhPRNpZ7SIcnLIg2XBPJc46cLVNNZHOc1JICCgFsMuV9+WdYsOH6RmdecbB6 wUTScNnR9y6qgd537hZM0LCIOn3KSOeB4u/UhGC1U3XH/fPCUdRf7RTlI4sbk7Ny/bze k3cuYK+Jv9C8w7m7CgwUYDoRYiCKBAWQnNxuaPo6cUYMJ0NmCIY7n9fLdDfj6ZCuRAGX tQmAhhFXnhM3/LajHg+YUoxr7Tl67mgO2y1sA7pp80LTu0YS/eAdosaflbOd5EwzcO2Q /pErWM1DdQYbgriprGlLaYfbwQgvi4yxiC4CvL+3KIklaPQQ+eb+wKTb6ZGUkBKXchEu CReg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=M6Q61j11gpyPJEiocylhOnsFAOElRrkVnJySZG0sSRA=; b=v/d3VdHbfADbNKIV8uSrfuyYuFhBeGdA04bq/sFezhR+zCK8ttz6ilRU1b2C7lLjjj Kfw3nZkI1OuVb5q8Sla9J33hobP3w2vaB9dvD6xR97GCm0Ngc32by7AWxu48euSemnuZ A4I+zIMOKA9WF0oyOYrVM3gi7iLKsEVY1jevQEPK3lfaPQ96w/A0ySASIwi4kOD5Agx4 hilWe+20ZLRfkqOvGg7dJMYUasJaJyhPe5c9nkuYnwi2v9Qpj+a7uBiYbQcDCtLaKII+ t/lOTG4leEuLzSNZ3eV0wcocqckd/wLCVmZCcM4Atfw8MxUOCx7c9OELz92pUHXw7Oyy DGqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rn4si3086941ejb.124.2020.06.05.00.52.45; Fri, 05 Jun 2020 00:53:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726090AbgFEHut (ORCPT + 99 others); Fri, 5 Jun 2020 03:50:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:38160 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726024AbgFEHut (ORCPT ); Fri, 5 Jun 2020 03:50:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7D9E9AB7D; Fri, 5 Jun 2020 07:50:51 +0000 (UTC) Date: Fri, 5 Jun 2020 09:50:47 +0200 (CEST) From: Miroslav Benes To: Max Filippov cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Linus Torvalds , jeyu@kernel.org Subject: Re: [PATCH] kernel/modules: fix build without ARCH_HAS_STRICT_MODULE_RWX In-Reply-To: <20200604210115.16826-1-jcmvbkbc@gmail.com> Message-ID: References: <20200604210115.16826-1-jcmvbkbc@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1678380546-113731455-1591343447=:10354" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1678380546-113731455-1591343447=:10354 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Hi, On Thu, 4 Jun 2020, Max Filippov wrote: > On configurations with CONFIG_ARCH_HAS_STRICT_MODULE_RWX disabled kernel > build fails with the following message: > > kernel/module.c:3593:2: error: implicit declaration of function > ‘module_enable_ro’; > > Add empty module_enable_ro definition to fix the build. > > Fixes: e6eff4376e28 ("module: Make module_enable_ro() static again") > Signed-off-by: Max Filippov I think the problem should disappear once Jessica sends her pull request for modules tree. Unfortunate though. Miroslav --1678380546-113731455-1591343447=:10354--