Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1981157ybg; Fri, 5 Jun 2020 02:29:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbOTWNQKixt4DEe5Z+JQ8R6b9pPzqMHzvfQMnnT3Ih5epxGdEXmo0eUPZBHv7ZpvCN+GQK X-Received: by 2002:a17:906:8595:: with SMTP id v21mr7644208ejx.30.1591349384278; Fri, 05 Jun 2020 02:29:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591349384; cv=none; d=google.com; s=arc-20160816; b=i7tk67fYiAnelLYhDBuAznXNPTB5xEXWQG9LsieSDSYaWBGi1M5Me4L2md2TYGEsnG M2rbYz6++wlrR9ON5FtP7XcGHT2V8IiiocDZX33moJNppHirER7RaT3Vn0ZMo3FUZBCw ewFwa2JUdjaE9HSBMBBkAQtxifCu0hMW31zSgFTEUHLx/s00CuPUbDbNxkkZH3vMtRY+ BkL0arQDYM27JLOYD9rFcUFrEi9c+jmkYfjhYq+jl4Uy5noiy8NEBTpFCp+FzByMKwo1 XBZDKcbcjOV7Jr3M5gxTIP8cxqbcoD6qcrxQV7YsIvDI5vTxWfyqzP6NBe4Y3YDTKBHo zguA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=WDei8S9Y+fDxIX/wQTpCEb31Qbwh2m1zyvXT6rABXcc=; b=qfAcuAvh74atqzVzi71hzpoYQgDUeagRtw6QU+oWhpT4gtWU8Vj43fzK0nVbRKGFGa gGuGwQMtZWvwkci0zC8fyNJjDElhQ5rlpFl46nnKQ/jroLxlgLLlD9saPY47w36DBafR RpcE0tbagoVZna0aA3z7cZlP6qN89lGsBR5QB8JI3Nxnzaju8jkV7nkjnv4DJ7qs8k8/ 7pIdtYLANwoJaSNDbaWmhBq5LfcmiRp9FJZSijlmdp5IdG7vS1HQaC1YA762HIsO7IB/ Oecue7SmU0TombaMBiEKJhkZdyB1dOVC3dep/CzTVDr0bRJGtBtOMk8HodeQ6IatOk8Q f+Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SR+dJjrW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b11si3126877edw.203.2020.06.05.02.29.21; Fri, 05 Jun 2020 02:29:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SR+dJjrW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726301AbgFEJ1K (ORCPT + 99 others); Fri, 5 Jun 2020 05:27:10 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:49096 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726177AbgFEJ1K (ORCPT ); Fri, 5 Jun 2020 05:27:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591349228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WDei8S9Y+fDxIX/wQTpCEb31Qbwh2m1zyvXT6rABXcc=; b=SR+dJjrWL7WAL6f9JrBlI852a8ApBiHnX5wU+MkekCGoIlJ5gs0YN6f1fCiD94cRuoYKcc /ndzxUfDxvHUzLG7bYiX6sywLTFUQ3N4KGVli6FBIoZCZTFsRLXsoClVShocV3o14NZhal ufdQF1iCORjkBaqyH5hrmenVMDDtVaA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-81-BJJKE-YNPiGHcoYfv28bZA-1; Fri, 05 Jun 2020 05:27:04 -0400 X-MC-Unique: BJJKE-YNPiGHcoYfv28bZA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 99AE21854C44; Fri, 5 Jun 2020 09:27:02 +0000 (UTC) Received: from [10.36.114.72] (ovpn-114-72.ams2.redhat.com [10.36.114.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56ECE5C290; Fri, 5 Jun 2020 09:27:01 +0000 (UTC) Subject: Re: [PATCH 1/2] mm/page_idle.c: Skip offline pages To: SeongJae Park , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park References: <20200605092502.18018-1-sjpark@amazon.com> <20200605092502.18018-2-sjpark@amazon.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: Date: Fri, 5 Jun 2020 11:27:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200605092502.18018-2-sjpark@amazon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.06.20 11:25, SeongJae Park wrote: > From: SeongJae Park > > 'Idle page tracking' users can pass random pfn that might be mapped to > an offline page. To avoid accessing such pages, this commit modifies > the 'page_idle_get_page()' to use 'pfn_to_online_page()' instead of > 'pfn_valid()' and 'pfn_to_page()' combination, so that the pfn mapped to > an offline page can be skipped. > > Signed-off-by: SeongJae Park > Reported-by: David Hildenbrand > --- > mm/page_idle.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/mm/page_idle.c b/mm/page_idle.c > index 295512465065..057c61df12db 100644 > --- a/mm/page_idle.c > +++ b/mm/page_idle.c > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -30,13 +31,9 @@ > */ > static struct page *page_idle_get_page(unsigned long pfn) > { > - struct page *page; > + struct page *page = pfn_to_online_page(pfn); > pg_data_t *pgdat; > > - if (!pfn_valid(pfn)) > - return NULL; > - > - page = pfn_to_page(pfn); > if (!page || !PageLRU(page) || > !get_page_unless_zero(page)) > return NULL; > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb