Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1998179ybg; Fri, 5 Jun 2020 03:00:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzX80xYctveZbq2Yw7w75+hsqJlvUAfq0HgnF5OznZ6v97gPcxbPtuRaqoxb9j0qIOMjg4u X-Received: by 2002:a17:906:a402:: with SMTP id l2mr8455096ejz.14.1591351212974; Fri, 05 Jun 2020 03:00:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591351212; cv=none; d=google.com; s=arc-20160816; b=ZyX9+rXeGdEUKqZU1yT01GV23dWZ58RKfWy86HFU+2ssqobM1sJZH2685Y9b0+L4ep ziFmK4Alu2/DGRWk8BxEM3ALJspeVMUyBw2ZcO/PQJ+Je1+0AvvkS6HiFUd9XgL0lpmx u6lyxMXMsCZ27hpS7Ei5FqhRzolMpuWwhNWnUYVhDI0uG84rlG9pl3+ytRY7n2+24Zt+ fh+eNOR53nXutFEO+p563XbkL3NUSsL9JlghEnL1hMU5kv3/u0V4ko/cxBehKWHh6mon 3uGypKeH3yKKqy+9smGe0NtlMN3TLQpf0Iqn80yS+yvQGPE3pNT0iCdiQvTdn3Ua/7BM sIsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Kyl/BEGuFfrugkp+Z2z9i+KCWkNEl78cBMHfA1A4JQg=; b=TnS3Qp3e9eUcq9ty5ok13PVJ+ZkZyCMBRKgyqdaF13R7FUiy/YZ+Y48qY5nUEGgOuk GbClSYyD+SqGDx54agfRLh0OEes4UetIHU6ho416/qBS+9Sqn/CGehLqz/vum4bzkRWL WAQ0QE6Oz6bCii1XbLFIzcCz8XBTrrtI58OKwwVPRuG/fMSbVWgoq38n7EAi9jHtLMEa kjMDFczDLzUNGeOW59rOV6EhmU0USWTtovXvV/LH/XINOOvijieham9OTcW0medFc25H +R8ut/S4TFib6kIvcgLc/GsTxCDA4U0InzBsySx7xpLeBt7Yzj5aghJMWq7jHbrneTig +2jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oBpyFHAe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l9si3292835edn.352.2020.06.05.02.59.50; Fri, 05 Jun 2020 03:00:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oBpyFHAe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726302AbgFEJ5e (ORCPT + 99 others); Fri, 5 Jun 2020 05:57:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:44590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbgFEJ5e (ORCPT ); Fri, 5 Jun 2020 05:57:34 -0400 Received: from linux-8ccs (p57a23121.dip0.t-ipconnect.de [87.162.49.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DFD892075B; Fri, 5 Jun 2020 09:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591351054; bh=rfylPv3H3z+tdHudrRYNXqWRsJ0KNJa9SUb7O3OTitY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oBpyFHAekvsx8ocPNLR08b4BRt+CfNiYu38/QyeB7Y2IbyRiq7RGh1WSuyRFIDxxT sDc/jsOvoYluHCAuJM4aJkLCyjSonF700qSuQ9BQcA/DV5O9kDLvroZkVKIOLylLzN brDigqZNGBQF5CSgqIYgnHjRrL54oRpcfryFqXL4= Date: Fri, 5 Jun 2020 11:57:29 +0200 From: Jessica Yu To: Miroslav Benes Cc: Max Filippov , linux-kernel@vger.kernel.org, Josh Poimboeuf , Linus Torvalds Subject: Re: [PATCH] kernel/modules: fix build without ARCH_HAS_STRICT_MODULE_RWX Message-ID: <20200605095729.GB24474@linux-8ccs> References: <20200604210115.16826-1-jcmvbkbc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-OS: Linux linux-8ccs 4.12.14-lp150.12.61-default x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Miroslav Benes [05/06/20 09:50 +0200]: >Hi, > >On Thu, 4 Jun 2020, Max Filippov wrote: > >> On configurations with CONFIG_ARCH_HAS_STRICT_MODULE_RWX disabled kernel >> build fails with the following message: >> >> kernel/module.c:3593:2: error: implicit declaration of function >> ‘module_enable_ro’; >> >> Add empty module_enable_ro definition to fix the build. >> >> Fixes: e6eff4376e28 ("module: Make module_enable_ro() static again") >> Signed-off-by: Max Filippov > >I think the problem should disappear once Jessica sends her pull request >for modules tree. Yep, the pull request was sent today. So this should get resolved in the next day or two. Thanks, Jessica