Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp2030675ybg; Fri, 5 Jun 2020 03:55:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwp0QAoPKylWIJd7Cu5Tjq5wv8YyJomNz99C1OxoBXYKU+N/FIbEyjWmuZua0vQzPbjwlNy X-Received: by 2002:a17:907:b03:: with SMTP id h3mr8689319ejl.367.1591354502589; Fri, 05 Jun 2020 03:55:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591354502; cv=none; d=google.com; s=arc-20160816; b=njIQnYgJ01vrBb24FWowVSgXch8xA2X+hwyrTiL2sSMgkLYg1sHY0FVbpEzNRFk+6A pUVPr2AnLdTjF8wGCpkjp8K3xgAEB5ZqWcAGTfYf+0iunTE29lL4NWI3KLnW77BsRTnN L2ji9N8vMhR19cAWLMcv+N0rVV8YFZI3HXajlvUXzLhoqUSsr5E71FvMdjvr/YysR8Tp cl11GjjbUi+FuEBtcRjb7rFrtTO5orm3rF7YC3zbQ84fC8ek/YnNAorVCZasbXnsC8Hf E4cajKOYeObvW6USCsZNBstcEW23e4Bfp0eF+0bHqNE8jkEMD78Hw78tfVmxfpoPM9AO PUNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MoDVfj5Oy5+r+60D3umb9qH33B9022w8clomcBuZkxg=; b=F88j3uMb/e7cnJvPqrRnCGMBqEDwq29HVsxiYvxl/fuzzsQy2+3EvosAiNoXUKz4rl 1UAqd+NLT8AUPR1vpMa/l93aISb61Ye3ovzNOzocbu+9IztXpjsUeOl5PzUxY93IkIo3 TazOC3LfvrslSharin+uUVV4DWUew/Qmh5IzJjTArl+tQBH4RrgPcuYqcTO+voDXBGiu jY0RSqUrBiEQZTbKGWKtYFyDdgUWnH3DtvXnNqdLc8MFQnDpcz4zow0SypwgcatijD7I y1VSl2+FZ8Y5P24HK0qw1myPSXOhprziVTLMGMI6MJ80VmCwekxtIC/fWhmG6fkolz93 5b4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qe1Kvqeo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r23si3454971eji.483.2020.06.05.03.54.40; Fri, 05 Jun 2020 03:55:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qe1Kvqeo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726905AbgFEKwp (ORCPT + 99 others); Fri, 5 Jun 2020 06:52:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:52888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726507AbgFEKwp (ORCPT ); Fri, 5 Jun 2020 06:52:45 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0EC742067B; Fri, 5 Jun 2020 10:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591354364; bh=XeO7tDwju/KKDj9cqR21WNubY9Btw3JqGz5Uwz9OKbw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qe1KvqeoJ3GrXMBQtdvkR44KDnjq5QKYn/VkETjh2pBcVx3ZDQGOGTARRoku3uwLi 6LBFG2SquriXQ72zOOFCUuEAKpxBeOHmb6PimnlerU7in2u8Ye3UqEa+6FtQY+N9st TeEXUeHueqXJCRLpRNCxWK0yCG0yKubP6sMjgSzU= Date: Fri, 5 Jun 2020 11:52:42 +0100 From: Mark Brown To: Nicolas Saenz Julienne Cc: Florian Fainelli , linux-kernel@vger.kernel.org, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Scott Branden , lukas@wunner.de, Ray Jui , Rob Herring , "open list:SPI SUBSYSTEM" , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Martin Sperl Subject: Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support Message-ID: <20200605105242.GD5413@sirena.org.uk> References: <20200604212819.715-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MAH+hnPXVZWQ5cD/" Content-Disposition: inline In-Reply-To: X-Cookie: Air is water with holes in it. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --MAH+hnPXVZWQ5cD/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 05, 2020 at 10:46:57AM +0200, Nicolas Saenz Julienne wrote: > > -static irqreturn_t bcm2835_spi_interrupt(int irq, void *dev_id) > > +static inline irqreturn_t bcm2835_spi_interrupt_common(struct spi_controller > > *ctlr, > > + u32 cs) > Keep in mind the new 100 character limit. That's more about stopping people doing awful contortions to shut checkpatch up than saying that it's a particularly good idea to lengthen lines. --MAH+hnPXVZWQ5cD/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7aI/kACgkQJNaLcl1U h9BVmQf/W9KSnmOIyYg8dG9v7/Nw5sW+8xZrwv7u3lUTml6tEdkKhOHIetp1TWoR QSQkErpuKwkAquozYTfN67RuBNaHMOQLYKCLlqXiX7ZLXdZrLJOczzClOy71/Cn4 bTPXoYID265sBbycA3+v/fXd9ZtjXs8a2hhnl3XJLTpVJCgGcfz8guY9gxfLvxIN gYwHRQO6m7/QvpCZSW8TjeFJfbsYbgLTv8QVSD49zG9y7PkZsdZ5BH4Qq8JU/Qw8 KBJIlMPBi30TKFmIz5ZF0jyEDizUKoI1GLESuBkugr7Vy2xvOGBsgh3XT+YnBJWY xtaHN3xC6DFvqASDSztVTnCOsNSmvg== =wEcm -----END PGP SIGNATURE----- --MAH+hnPXVZWQ5cD/--