Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <15677f9958dfe4dfdbb3dda978c84a64427fa00f.camel@cyberus-technology.de>
Subject: Re: [PATCH] drm/i915/gvt: print actionable error message when gm
 runs out
From:   Julian Stecklina <julian.stecklina@cyberus-technology.de>
To:     Zhenyu Wang <zhenyuw@linux.intel.com>
Cc:     intel-gvt-dev@lists.freedesktop.org,
        Thomas Prescher <thomas.prescher@cyberus-technology.de>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Date:   Fri, 05 Jun 2020 13:08:32 +0200
In-Reply-To: <20200605045430.GS5687@zhen-hp.sh.intel.com>
References: <20200603123321.263895-1-julian.stecklina@cyberus-technology.de>
         <20200605045430.GS5687@zhen-hp.sh.intel.com>
Organization: Cyberus Technology GmbH
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2020-06-05 at 12:54 +0800, Zhenyu Wang wrote:
> On 2020.06.03 14:33:21 +0200, Julian Stecklina wrote:
> > +		gvt_err("vgpu%d: failed to allocate %s gm space from host\n",
> > +			vgpu->id, high_gm ? "high" : "low");
> > +		gvt_err("vgpu%d: destroying vGPUs, decreasing vGPU memory size
> > or increasing GPU aperture size may resolve this\n",
> > +			vgpu->id);
> 
> Currently we can't decrease vGPU mem size as defined by mdev type,
> so actually you may try different vGPU type.

Yes, that's what I meant.

>  And aperture size is
> also handled for supported vGPU mdev types, so assume user should
> already be awared of that too. I just don't want us to be too chatty. :)

Our users typically hit this particular error message when they haven't
configured the GPU aperture size in the system BIOS correctly. Many laptops we
see have the aperture set to 256MB and this is simply not enough.

I don't cling to the specific wording of the error message, but any hint in the
error message that this is not an obscure, internal error or bug, but something
that the user can actually fix, would be helpful.

Julian