Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp2062282ybg; Fri, 5 Jun 2020 04:46:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMN9Nhpo/qR0D62Zpk4G3lETH9Rt3iYVvzEzH8M/+Y0RoWnAHKqIaCId/zKRy1p7/AEd/w X-Received: by 2002:a17:906:1496:: with SMTP id x22mr8029351ejc.161.1591357612191; Fri, 05 Jun 2020 04:46:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591357612; cv=none; d=google.com; s=arc-20160816; b=WWBi8m2nXIty9ZrLIcrd5hTn3oBUnG8L77XKRJ8hMme96gydbxp7vMnd6+DMIwfBJL MyMkX7BgRyuRIJq92V/dHWquwiY7HMdzAxDAS+Cn1qN+eMjXqKW0Dk1jkZ1MDwZDFyk/ Y9TmHI3o4VvWmHd8x+/q2nijeXzmmJCuOKh6npxsU25Vz1irUkV6nLsWQG/z8NupQE+S 87NgF0z/G8YEv8AGG5570edN1tKUKWQzy2iD+MAPxKlv1ZgAkdKZNhfHxq4H9p4zexCF M++umuzrJFsj02RGXHnpU7j5xHo2iHYE4lVEEok5Gb2S+BKhvZCXhU7RIIJ3WX5l5gzh aU7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=GvsW7zdrUIqmvXgAJrllNLf1O1seE5aFbC1JusbrvcI=; b=D3yATNBwP4xtrtRy50zdM2FVepjZ6aUM0gfItW2jWZ/zmYDFX1Ow1ypBaRB93krgEU cX1/FwubN4HqiQeZRHJDsOBG7ejXiW1/6pavHyJ80oDXNGvPZShqreA77DTsx5tHu0qm FLGQqBTY9GEZIczv+wCC4Y488ja3LHjYVS9zvFDwVADeTj2ILiXhsi2R97pG11KmfcdU t4wjzFyzjG9j9SJJnvVXKfVIuVtDaMO3qM0LDnEYVfSO8LE+gw0P/hDRUqpMp3rIMM7y 7qj9vjWhYNPbfRA+IDMIbjtWmQKzAtApDWbNpUnEMj5sPUNOxr/Duyg6NEJ/QAp2W9cj VmLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=rYJr3ZgM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt16si4748836ejc.525.2020.06.05.04.46.29; Fri, 05 Jun 2020 04:46:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=rYJr3ZgM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726479AbgFELmP (ORCPT + 99 others); Fri, 5 Jun 2020 07:42:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbgFELmP (ORCPT ); Fri, 5 Jun 2020 07:42:15 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40677C08C5C2; Fri, 5 Jun 2020 04:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GvsW7zdrUIqmvXgAJrllNLf1O1seE5aFbC1JusbrvcI=; b=rYJr3ZgM4OLQq4cmCbWihqvWX1 cNYPHtzQjittlKB9+HDAOi7uZ1YQJZBxxuxGyXCYYEB1odBNw58jCW5h3rZ6Hx2eJh/wHADb8gGUz 4+1dzkdivSIJ0OZzNcFr5DYmt0iDJZlqLUDl87yzDBB60YC+cD0TnQ1G1M2+W6DQOS5HwJ+90wNFa eY+yHqVlmy5yrIzsk8hEOUQNtMT5Xe9PLeGh4Mb9MxYf9cR6cVSxsHM5swrBQlIsp5EuMQqyeRmeg NAuYYbDAklhTiprOyPo724hi+oUXjMhej9qLr7pLM4OAl0iCa6bHLGFdo0gHCOtJMZTj/bcoBES3f QgHNSQGw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhAjg-0003Rg-Rq; Fri, 05 Jun 2020 11:42:08 +0000 Date: Fri, 5 Jun 2020 04:42:08 -0700 From: Matthew Wilcox To: Markus Elfring Cc: Dan Carpenter , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jason Yan , hulkci@huawei.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , Christoph Hellwig , Jan Kara , Jens Axboe , Ming Lei Subject: Re: block: Fix use-after-free in blkdev_get() Message-ID: <20200605114208.GC19604@bombadil.infradead.org> References: <88676ff2-cb7e-70ec-4421-ecf8318990b1@web.de> <5fa658bf-3028-9b5c-30cc-dbdef6bf8f7a@huawei.com> <20200605094353.GS30374@kadam> <2ee6f2f7-eaec-e748-bead-0ad59f4c378b@web.de> <20200605111039.GL22511@kadam> <63e57552-ab95-7bb4-b4f1-70a307b6381d@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63e57552-ab95-7bb4-b4f1-70a307b6381d@web.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 05, 2020 at 01:40:37PM +0200, Markus Elfring wrote: > >> I am trying to contribute a bit of patch review as usual. > > > > We have asked you again and again to stop commenting on commit messages. > > I am going to continue with constructive feedback at some places. > > > > New kernel developers have emailed me privately to say that your review > > comments confused and discouraged them. > > Did these contributors not dare to ask me directly about mentioned details? > > Some developers found parts of my reviews helpful, didn't they? Overall you are a net negative to kernel development. Please change how you contribute.