Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Jun 2020 14:58:32 +0200
From:   Petr Mladek <pmladek@suse.com>
To:     Yannick Cote <ycote@redhat.com>
Cc:     live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
        joe.lawrence@redhat.com, linux-kernel@vger.kernel.org,
        mbenes@suse.cz, kamalesh@linux.vnet.ibm.com
Subject: Re: [PATCH v2 1/4] selftests/livepatch: simplify test-klp-callbacks
 busy target tests
Message-ID: <20200605125832.GA5099@linux-b0ei>
References: <20200603182058.109470-1-ycote@redhat.com>
 <20200603182058.109470-2-ycote@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200603182058.109470-2-ycote@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed 2020-06-03 14:20:55, Yannick Cote wrote:
> From: Joe Lawrence <joe.lawrence@redhat.com>
> 
> The test-klp-callbacks script includes a few tests which rely on kernel
> task timings that may not always execute as expected under system load.
> These may generate out of sequence kernel log messages that result in
> test failure.
> 
> Instead of using sleep timing windows to orchestrate these tests, add a
> block_transition module parameter to communicate the test purpose and
> utilize flush_queue() to serialize the test module's task output.
> 
> Suggested-by: Petr Mladek <pmladek@suse.com>

I am not sure if I deserve this. I suggested only few implementation details.

> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>

Looks good now:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr