Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp2130995ybg; Fri, 5 Jun 2020 06:27:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxx9q8kzt7CDrBjDkB6P3v2ABcrn2BRHgVcfVxN+1R6mbhrt77Uxg4e+l4U/juuWPnfpS3d X-Received: by 2002:a50:aca3:: with SMTP id x32mr9011910edc.194.1591363624782; Fri, 05 Jun 2020 06:27:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591363624; cv=none; d=google.com; s=arc-20160816; b=KeeFGTyaF2CmDyYOa/6La8OgxZiMhy6eM67pfIF3qseVTzqNqwa2KcVoWu79dZnuNn Hpd/dMCOD6oh+r9TbT/V4iK8LPoonIzVMbfE3XE3WmPfm+8e+mYxTTrj3S15VaLwFfGT 0SopVrQznzWgOkXBK5IGJKxy9JE7FokC3Z+YY+qGIbHhU4q1xxV3YXeRnuwde/m0R+vp eDs3m4FrKZfI8Lau7S2WxjBI/YK9w77mKHgzlG//HKDaxGWSu1cQYm7/UEkcNeapfba+ DsgwA6fVQIN2kCnaeBOpaRMwLFylexuVkjOm1Zopu2hDDl93KeoZh9wKhXxQK8MWUTw1 5qyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jPqXVXtc79WvvXrvoTaGf7nAStvx0qycYwpo7dn0l7I=; b=dnhsI/3qGI09sQYK2kR5Gycksoui1V0gtN9g++RlVWdvf6rEyL1m9xpER8pVB03/kI ddhkbDqrIvfDGA/IMLPAp9mLr8tkChbeEWOPMCN1DUgeRy/GDOKuquJ40ueDgQFHwtkN mPyMkCHnrz7KFBhVCYs6icGnQJIglLHjVWous2lmQ9ZcezdhsyoNyVx29E6iEmAx5apZ 2LIl4V93O7d8BjpAxP1UG9X0GBj2OaUVO/w0SEy8BaFSZCqoJ4SFPpwoEaJh+pwEaI8d uuliZqRbb+F8er1e5apu9miCir0L+xsVOLzE3t8aAfUIKB5L+wS/I7mnPaT5EmEGAfFA GYcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=po8SjU+x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pk14si3517351ejb.368.2020.06.05.06.26.41; Fri, 05 Jun 2020 06:27:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=po8SjU+x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbgFENYy (ORCPT + 99 others); Fri, 5 Jun 2020 09:24:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726894AbgFENYx (ORCPT ); Fri, 5 Jun 2020 09:24:53 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D2EEC08C5C2; Fri, 5 Jun 2020 06:24:53 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id 5so2730505pjd.0; Fri, 05 Jun 2020 06:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jPqXVXtc79WvvXrvoTaGf7nAStvx0qycYwpo7dn0l7I=; b=po8SjU+xeLGS/x5kQxzffs1xCB73Sg6n7CKyBKbx6rFCIqftfj+iLPDSGxs3gz/h5E 55cL4Euz5fojnDLCYjzMbz9jj6JisyyMvLR3bwt1FNhZQeB9H7V505d/TBPCHwOlEgra YV+r2rhgDzeAO2fxRfoq3ssckxu2VACyYNF/XS6h0ZKK1hQOpMEW+E02btINHF0jbksa d3qZgSMQU+f7nkfaXqZD/RTl9+0wy/vuF7yynwpk42lRWDSMYdslMbOhknpnmk296tOU UoDAdTP5gkYKcDvzWMOy8jNCQwZVql77xTqOXfDpXx2jc8wtuxYL+5H6QEIGZgYWn3mJ axFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=jPqXVXtc79WvvXrvoTaGf7nAStvx0qycYwpo7dn0l7I=; b=ETqfL/FZblo6OSv+Z2yLTG8EXGYyHtVlMo52ZDw8F9xtXX0tqiqAjiELsOnzXhAioU jcRvr22kIfLQxB4N72Y0aaijlGrj+j/zi2X28okNhrt3t/spAQCTua9xXorEhIYWPNMk n9nHFJMS8dtC5RO9kh7QPdemuQ2mdwILxhVbhiGMcLBoiTBiLqdUk2kytBLgeBCikPB6 Q32LckUYOI7hNTMXD5OshmutLF6HS/275suRvOZMHljJTxwxYgMDXLSEV8gm/ZyivYPE f327g/0PKpbowvTsIjJ6DbSV3VrWtZs3uir0RgjxuSOhctYVFPjo+bVqdAYJLp3Mjtlj 0ySw== X-Gm-Message-State: AOAM531yv1y1e94wec6N/7RB0lVYN2sUia2Xk14zdeQtYr2vzWoEzsP4 NeuYPy8K02+LzEFietUm5wg= X-Received: by 2002:a17:902:7487:: with SMTP id h7mr9913280pll.155.1591363492420; Fri, 05 Jun 2020 06:24:52 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id r1sm6609677pgb.37.2020.06.05.06.24.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Jun 2020 06:24:51 -0700 (PDT) Date: Fri, 5 Jun 2020 06:24:50 -0700 From: Guenter Roeck To: Josh Poimboeuf Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Jessica Yu , Joe Lawrence , Miroslav Benes , Linus Torvalds Subject: Re: [PATCH v4 11/11] module: Make module_enable_ro() static again Message-ID: <20200605132450.GA257550@roeck-us.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 10:24:53AM -0500, Josh Poimboeuf wrote: > Now that module_enable_ro() has no more external users, make it static > again. > > Suggested-by: Jessica Yu > Signed-off-by: Josh Poimboeuf > Acked-by: Miroslav Benes Apparently this patch made it into the upstream kernel on its own, not caring about its dependencies. Results are impressive. Build results: total: 155 pass: 101 fail: 54 Qemu test results: total: 431 pass: 197 fail: 234 That means bisects will be all but impossible until this is fixed. Was that really necessary ? Guenter