Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp2173605ybg; Fri, 5 Jun 2020 07:24:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGdyqHfB24g8fpH4ncDEkMDx7BpaVfS72vL90CXSdu6hKxsEUy8/CARbuahdG+ObZ94KjS X-Received: by 2002:a50:b0a1:: with SMTP id j30mr9644834edd.387.1591367076981; Fri, 05 Jun 2020 07:24:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591367076; cv=none; d=google.com; s=arc-20160816; b=m+DurW+sFeh3dh+rJHtEhzhkyu5z7QvACMR+k6ZLSLWAjm12hqhm+GW1VUURFB+QjQ tkbIL5Kg/+3X58Jijw9+45ganemBTD+CqoyuVWFaNt3tg9kZioCcWmVyhq5wm6EWPR3t C5pi8qN+GZAQtEIuc27VnMZpbpNpbdAemyIfeeUsk59KVuBqhLd7mflp4mqaS4i2Y4Vn UAUqypqn26n/qP+oPQVP9pF7Za66FKW8fHaK/Ik5j/iH+krNLOQprQk13yvuI5H7Pl5r 8LG2u4Ns+cFp6Wi/5sKLIFaj9Fl75gzcYKOgve6GdpLz7GfiX+/hL1gELDZRrUqVWcKL QeNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=yb8hAKaD7nfu3HLxpH5/ttVSan7O8CV+Of71cNBmqWY=; b=BYF5LlD+rMMTlbQd+bRT2j1xECoymlZYz7CYwu3wlU613K5CQ9s3VEb/nPAh3afHJh 9xMHKKSuc5BkphLJ++43PQQI8vaLdO0Ak94XSelW9Tr+Gacq2xtihAy8as8gV+O72WjD E3fwW18pLPjGHTDgdGj4q7vW1NmkNK5tEYr8BJzMYUz6S+/TdrDp+d6rZHwQ8fgn61KH R1v3t2U9AUusYbni/a1xApg8cYcfpR/PexnwABqpLYn37MjI4uroY9VH6YaccQteiwf6 8I/PW9g4YGiiwOsyL0IKRcTk0atwjj1cEq0tlnwlg2x+tAsAVZBib2xeokUta72E0jaM kVOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B1bANglD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j21si3449020ejc.497.2020.06.05.07.24.14; Fri, 05 Jun 2020 07:24:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=B1bANglD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729032AbgFEOVZ (ORCPT + 99 others); Fri, 5 Jun 2020 10:21:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:51462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728935AbgFEOUP (ORCPT ); Fri, 5 Jun 2020 10:20:15 -0400 Received: from linux-8ccs.fritz.box (p57a23121.dip0.t-ipconnect.de [87.162.49.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F392A208A9; Fri, 5 Jun 2020 14:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591366814; bh=lQhl9VjPpQqPHD07ccAprin/eMBfjjoE6H6u38WkXG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B1bANglDGNNAxIm0D9lBYOGI2a3GiqmxrciDb1YXY62MpCrwmyvnZ0UUHn99RQxRC funpZ/+Xjg/7isnDOsQkO1gbdu7SXGgfi1ab41YnAwhfM8JG4vMPvUhHKmDIJfZCaw MR5vvR3PNQleUjcEPg3nh34HLCQ+Y0eA0bL7IeMw= Date: Fri, 5 Jun 2020 16:20:10 +0200 From: Jessica Yu To: Guenter Roeck Cc: Josh Poimboeuf , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Joe Lawrence , Miroslav Benes , Linus Torvalds Subject: Re: [PATCH v4 11/11] module: Make module_enable_ro() static again Message-ID: <20200605142009.GA5150@linux-8ccs.fritz.box> References: <20200605132450.GA257550@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200605132450.GA257550@roeck-us.net> X-OS: Linux linux-8ccs 4.12.14-lp150.12.61-default x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Guenter Roeck [05/06/20 06:24 -0700]: >On Wed, Apr 29, 2020 at 10:24:53AM -0500, Josh Poimboeuf wrote: >> Now that module_enable_ro() has no more external users, make it static >> again. >> >> Suggested-by: Jessica Yu >> Signed-off-by: Josh Poimboeuf >> Acked-by: Miroslav Benes > >Apparently this patch made it into the upstream kernel on its own, >not caring about its dependencies. Results are impressive. > >Build results: > total: 155 pass: 101 fail: 54 >Qemu test results: > total: 431 pass: 197 fail: 234 > >That means bisects will be all but impossible until this is fixed. >Was that really necessary ? Sigh, I am really sorry about this. We made a mistake in handling inter-tree dependencies between livepatching and modules-next, unfortunately :-( Merging the modules-next pull request next should resolve the module_enable_ro() not defined for !ARCH_HAS_STRICT_MODULE_RWX build issue. The failure was hidden in linux-next since both trees were always merged together. Again, it doesn't excuse us from build testing our separate trees more rigorously.