Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp2265960ybg; Fri, 5 Jun 2020 09:31:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtCHDSsUyh4ThSZxVIJ0DPMEewlGi/IFPZPTJcSCL8AJjZ8/wYi2eWMZtZfcpExRYlyxZW X-Received: by 2002:a17:906:e247:: with SMTP id gq7mr9301442ejb.107.1591374716919; Fri, 05 Jun 2020 09:31:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591374716; cv=none; d=google.com; s=arc-20160816; b=kiahP60DDHsBMBzqed4vvbfwupu/4LIK64+9b+7hNVdizVUdPe11G0lU8jbHzPlXNR A08raSjS5kTAERcyPqxgg6RTxxWHkzMeOxUyqTVwIxUzZMCMGz45tnoFWupPbfHAevS4 BLc30SxIqcI/t7pIMfuRBYmX4oNSA15vUugfJ+L9CP1i7+UnhvpNLrd6McCRFg6Vy/mJ SezxPHKwSofX0ZAkyysXtM0+uQHOtdo6ySAWe+48I1DelTv/aaP6TcsuzNZ40YhgSyyf 1LpOQjP6GQbmSGDoahzVBvYkcvOIUNiu3gQbJO8L3v59gf/vQrVUhs+u1N4U1uqQA8XD Ifnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=GQFydgePOocQu3btyVs/kadHJxlM7zf0jsKl5sc8/Uw=; b=DU+VHT3KRU57GWshxWhf9l/z+ZwqYyWAi7JEs/JlZ/OhhRJ2WJvnKMjbHlceFACeXF BcQjF+KGZKh1RYpYRqD/ogfqNNPIzf+xXmoW0HgCGTumTxg96Xv3l9tHwltJ2XZORBRe tDCeAnFYCJBP+Ndas273yf5hiQKkniEzn9dsbbY7zZTwn1O38n1ekoKkGugSNZTy6umM 2JRi5sdh+JAkOOCkY5U+S9GfyrazX/mtgHTRwyijGiwo0aPJgAo3KHokaVzwJW+7kniA rJewioBXRfIpe1fClsVVmytWdOxop2WPh6npHaXzIZFS0kNxdfr7DCQklAiHTcRBJ4PZ A5dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BIYaazuO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si3715213ejw.702.2020.06.05.09.31.33; Fri, 05 Jun 2020 09:31:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BIYaazuO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726876AbgFEQ1J (ORCPT + 99 others); Fri, 5 Jun 2020 12:27:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728138AbgFEQ1H (ORCPT ); Fri, 5 Jun 2020 12:27:07 -0400 Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A1B8C08C5C2 for ; Fri, 5 Jun 2020 09:27:07 -0700 (PDT) Received: by mail-oi1-x242.google.com with SMTP id 25so7766437oiy.13 for ; Fri, 05 Jun 2020 09:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GQFydgePOocQu3btyVs/kadHJxlM7zf0jsKl5sc8/Uw=; b=BIYaazuOnrhe77bys+7h1TZcEGy4/RV6AqtwKjOULq4WDQyi+BTcvp0rJQ6n2ievEr DtC7ooUnjoTDiJc8ogHbzCqVCWaMULJBus72RTTHYTbZMhFtaopcDG6gzbGjc0gyAkKZ eE1WU9AMl2kk8N6bVPgMLHqEsubDfg0QMCwoNVjjD0tG5xvQf7d0o8dU8botxv/BCh3Y zcPNcvsiIu60CizeOM5CaEUuDADsYbIF30G3VFus6fg1NEUfBxLtzhBSTbHFKreyo/gb T0oJg3ks95Rqvt5SXCgiNHDMclWIykdXpTqn2o6xW/v+vDCOB/9rP7/pPCX4wLq8Cizw twtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GQFydgePOocQu3btyVs/kadHJxlM7zf0jsKl5sc8/Uw=; b=rA8iuqn4RlNbW6NDvGjswPV9m2iZcT9rsfGPIYi1NmH2cM/yZBz4NlGyxBy3lUc5Jx MxQXgqbBkBnbYwYFFO8WEmGsfhXYKjzlHBOXagkJSOzQwIpCt/6U3c7t0T/4isg3LG2s 2Uskvhc+lT4CjG5XOwPJVwL6vh0ynQLGa7+IV4X81FiqAWm9cE8QXa03f5MVw5d1dg7G 2Q5RFQcdyFE6+UrweAMyjRwKDVpk/xbrBappwgDXVCMf12steujrhVDQ5Jc8v81onLZA urzV7rc81rI3Am6ibqAuvwK8rHkMc2wP9vEKMBgM8bWGzqLmnezPtl+neq95Ojn3+rrf LxIw== X-Gm-Message-State: AOAM531JsGcpfdzPhFyxnaukVVdakM9xhHrFFMiJnn6W8VeTYGZ4qxDw VPUXmflz/q/zQAETVdwQFYs= X-Received: by 2002:aca:3c82:: with SMTP id j124mr2455122oia.62.1591374426634; Fri, 05 Jun 2020 09:27:06 -0700 (PDT) Received: from frodo.hsd1.co.comcast.net ([2601:284:8204:6ba0::aaac]) by smtp.googlemail.com with ESMTPSA id z13sm813894ooa.28.2020.06.05.09.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 09:27:05 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, linux-kernel@vger.kernel.org, akpm@linuxfoundation.org, gregkh@linuxfoundation.org Cc: linux@rasmusvillemoes.dk, Jim Cromie Subject: [PATCH 00/16] dynamic_debug: cleanups, 2 features Date: Fri, 5 Jun 2020 10:26:29 -0600 Message-Id: <20200605162645.289174-1-jim.cromie@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Patchset starts with 7 "cleanups"; - it changes section name from vague "__verbose" to "__dyndbg" - cleaner docs, drop obsolete comment & useless debug prints, refine verbosity, fix a BUG_ON, ram reporting miscounts. It adds a few query parsing conveniences; accept combined file:line & file:func forms file inode.c:100-200 # file & line-range file inode.c:start_* # file & function Then it expands flags: Adds 'u' user flag, allowing user to compose an arbitrary set of callsites by marking them with 'u', without altering current print-modifying flags. Adds 'PFMLTU' flags, which negate their lower-case counterparts. Extends flags-spec with filter-flags, which select callsites for modification based upon their current flags. This lets user activate the set of callsites marked with 'u' in a batch. echo 'u+p' > control This was previously submitted before events overtook. v1: https://lkml.org/lkml/2019/10/29/989 v2: https://lkml.org/lkml/2019/11/27/547 Jim Cromie (16): cleanups: dyndbg-docs: eschew file /full/path query in docs dyndbg: drop obsolete comment on ddebug_proc_open dyndbg: refine debug verbosity dyndbg: rename __verbose section to __dyndbg dyndbg: fix overcounting of ram used by dyndbg dyndbg: fix a BUG_ON in ddebug_describe_flags dyndbg: make ddebug_tables list LIFO for add/remove_module new features: -parsing conveniences dyndbg: refactor parse_linerange out of ddebug_parse_query dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100' -flags extensions --internal rework dyndbg: refactor ddebug_read_flags out of ddebug_parse_flags dyndbg: combine flags & mask into a struct, use that dyndbg: add filter parameter to ddebug_parse_flags dyndbg: extend ddebug_parse_flags to accept optional filter-flags dyndbg: prefer declarative init in caller, to memset in callee --expose the features dyndbg: add user-flag, negating-flags, and filtering on flags dyndbg: allow negating flag-chars in modflags .../admin-guide/dynamic-debug-howto.rst | 75 +++-- include/asm-generic/vmlinux.lds.h | 6 +- include/linux/dynamic_debug.h | 5 +- kernel/module.c | 2 +- lib/dynamic_debug.c | 282 ++++++++++-------- 5 files changed, 225 insertions(+), 145 deletions(-) -- 2.26.2