Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp2781048ybg; Sat, 6 Jun 2020 01:08:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+A9KDMska5h5s5meVGYhcOUdOUfEcyb3kDuI/1f8/NMjcuQ3ZpXTF1dMZ4CN9pOjwMDZZ X-Received: by 2002:a17:907:20f4:: with SMTP id rh20mr12127319ejb.55.1591430933154; Sat, 06 Jun 2020 01:08:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591430933; cv=none; d=google.com; s=arc-20160816; b=iz9R+E+UXx6SWT3Mk7qJMGYdtTkbpFX/R4fx1Bhz+moAu7p4N3XeWg4aH6Or7yJr7T VtV7TTBUmvReJGUWQ+OFJQwqw7dlukEAyHI5mBA0GfR88Lbb/NrfJ8qokYLuki3HxFT5 bIq1YvvjB9A1zkFK2bx2Iwf6JoMM4nHrg01NI6pGb8YoTrpo0FEaw0BxbnPY0Z0xW30v 4OfOG62oQOGOAKwSaJilsxJ9lt/YmtFx5Et+Vp4GuC2TIjF+w53JaLfqacB4hm7NwvZN DZ1abvpzVkjo3C5MA47XmxdMZfczC/9PHKR80zWIFwQrSBEKNW6L0XsmLlmrrB4RXFdl zBcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=Q0KLSmWYYUBpFcXi5MMemPdl7pEA14YgBau4jZ4UeRw=; b=bYe+o1erbV3AjNLCBEPvnrNZEln1hbbDt1LxJkwWwCfgtig/2VJc3NfYX+Vp8a5awq i88mhbavgo/CKhiocccMYA+/g7NfrnPn01t41zgta+QG5GxxxCoK+OWDEJ1iKXIdhBzj hGfYtTrMfqsCPWB+nziAL+ZH37aps5Sy36fR0sJTNf7gejJDWjnddyoDN4+WM7H/L+61 ecBEiNcQgTYX1IZ0QhAyzdTko9ue3PNHtGU0mpCuEoFo0SwG7iT+oUejhQ3cmla3wrc1 IF7MBnmZsX8KM5Z6UpuMD7JK73UGI7IEauQ9BMm5pUNN8MatJaDJwnaAu4I/S8SfaeM3 nQbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j21si5059879ejm.613.2020.06.06.01.08.29; Sat, 06 Jun 2020 01:08:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728605AbgFFIGk convert rfc822-to-8bit (ORCPT + 99 others); Sat, 6 Jun 2020 04:06:40 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:46589 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbgFFIGf (ORCPT ); Sat, 6 Jun 2020 04:06:35 -0400 Received: from [192.168.1.164] ([37.4.249.202]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M89XH-1jcGuL2Rud-005Eie; Sat, 06 Jun 2020 10:06:14 +0200 Subject: Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders To: Maxime Ripard Cc: Eric Anholt , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org References: <020de18840a1075b2671736c6cc2e451030fad74.1590594512.git-series.maxime@cerno.tech> <20200602155421.niyvpwqc42xh5c7v@gilmour> <6cd190e0-c81c-8e47-3ca8-22360de9b46d@i2se.com> <20200605143536.i6cc2v57eupmlvtn@gilmour.lan> From: Stefan Wahren Autocrypt: addr=stefan.wahren@i2se.com; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tClZlcnNpb246IEdudVBHIHYy CgptUUlOQkZ0NmdCTUJFQUN1Yi9wQmV2SHhidkplZnlaRzMySklObW4yYnNFUFgyNVY2ZmVq bXlZd21DR0tqRnRMCi9Eb1VNRVZIRHhDSjQ3Qk1YbzM0NGZIVjFDM0FudWRnTjFCZWhMb0J0 TEh4bW5lQ3pnSDNLY1B0V1c3cHRqNEcKdEp2OUNRRFp5MjdTS29FUHh5YUk4Q0YweWdSeEpj NzJNOUk5d21zUFo1YlVIc0x1WVdNcVE3SmNSbVBzNkQ4ZwpCa2srOC95bmdFeU5FeHd4SnBS MXlsajVianhXREh5WVF2dUo1THpaS3VPOUxCM2xYVnNjNGJxWEVqYzZWRnVaCkZDQ2svc3lp by9ZaHNlOE4rUXN4N01RYWd6NHdLVWtRUWJmWGcxVnFrVG5BaXZYczQyVm5Ja211NWd6SXcv MHQKUkp2NTBGUmhIaHhweUtBSThCOG5oTjhRdng3TVZrUGM1dkRmZDN1R1lXNDdKUGhWUUJj VXdKd05rLzQ5RjllQQp2ZzJtdE1QRm5GT1JrV1VSdlArRzZGSmZtNitDdk92N1lmUDF1ZXdB aTRsbitKTzFnK2dqVklXbC9XSnB5MG5UCmlwZGZlSDlkSGtnU2lmUXVuWWN1Y2lzTXlvUmJG OTU1dENna0VZOUVNRWRZMXQ4aUdEaUNnWDZzNTBMSGJpM2sKNDUzdWFjcHhmUVhTYUF3UGtz bDhNa0NPc3YyZUVyNElOQ0hZUUR5WmljbEJ1dUNnOEVOYlI2QUdWdFpTUGNRYgplbnpTektS Wm9POUNhcUlEK2ZhdkxpQi9kaHptSEErOWJnSWhtWGZ2WFJMRFp6ZThwbzFkeXQzRTFzaFhp ZGRaClBBOE51SlZ6RUl0MmxtSTZWOHBaRHBuMjIxcmZLaml2UlFpYW9zNTRUZ1pqak1ZSTdu bko3ZTZ4endBUkFRQUIKdENCVGRHVm1ZVzRnVjJGb2NtVnVJRHgzWVdoeVpXNXpkRUJuYlhn dWJtVjBQb2tDTndRVEFRZ0FJUVVDWElkYwo0Z0liQXdVTENRZ0hBZ1lWQ0FrS0N3SUVGZ0lE QVFJZUFRSVhnQUFLQ1JDVWdld1BFWkR5MjFPVEQvOUdpWkxkCnRSWWNteVJKZ2x0aVFRekFp UWRjSUQ3OGxHb1dwL3grci92Y1U2YjZqdVl1ZVR3Z1Iwclc3djdsMklSQnlEN24KSEp4YSt0 SVNvUVpCZ2hvbE1JZmI5TXRoR09KTENZNzdrL1FoQWhuMzJOR1prZWp3OXR6a3MvNDBtclpT VVQ4NApaeWJzUVhyTE0vSFI2VElJL0RlUEIwbktEM0ppcHBzMlVIUUQ5cUQySWpFd1NRUGxI akNPckVaaDQ1UFo3bTkrClo5M0x6aVRlc1dabFlRdUxpSndzNHJLcHRIVzFkL3dSZWxzaG1t NlFxY0wybDRDL2U0MGVEQjlncTRkU1poOVgKUEVZbGxpeU5RaDdhMkxTZHVtRTFyK2NTd0lq RS91ZHRSdmRPOWFLb0psT2JVSzVkTmpTUEg3d0tUYndkWGRZRApHUHdEaFhkNThOQXdyK1BY QmxQajB0STFMQ3ErTEJ4ZUt6aFdYK0dWcTlEb2pWanlVREV4Rk5Ga1h1b0M3ZzhtClY5VDB0 ZUJpdVpSbm91WEt3VjJGcHRaT0hIN0JVRVd0a0t0aGgxZXRmT1dwaWdCemtVN2JQc2ZJWVQr cnk5dGIKMW9KK3Y0MVBOYXFaRW1QVXBKeHZmek5UN3Ayd01lRDdaajlmMHJ1YlJQdExBSjJR R2pyRkhzdVh3QU9xcHl6ZQoxOEVidHNZazBOMHp1SEVoY2orUEJJQmZoMFlJWWQ1MW9mNkdJ aU95UjlxMFhYdHBsVUo3VDIvSDF1UXFrWGxwCitnVzRWa2lmc2NJckl1eWZueFpXMTJlSXZq NnlicVdMN2FZS0dZbVQ2aUxDUGJIWXlZY2F5bDRFa0ZjckNGN0UKZTBXVC9zY1ZNaE8vNVgv SGFOQTVIQngvcjUycGdMY3Y0aTlNeExRbVUzUmxabUZ1SUZkaGFISmxiaUE4YzNSbApabUZ1 TG5kaGFISmxia0JwTW5ObExtTnZiVDZKQWpnRUV3RUNBQ0lGQWx0NmdCTUNHd01HQ3drSUJ3 TUNCaFVJCkFna0tDd1FXQWdNQkFoNEJBaGVBQUFvSkVKU0I3QThSa1BMYmpic1AvamdqYVNz NUh0bGtBSXZXUytGcm15N2MKaG5jT0F4TFRWL0Q2UkV3SU95R0poRkt3d29pck55UTJnOXZV YTNZQ1lDZjFmSjh3RWhhS09COWQwTHBNUm5MNApkRVQ4ZDgyMzhFL3BLK0hxTktpSXNKaHM2 SnNLOFpnalZRR3JtbWZua0dyWisxdjBIQnV4ZGljZ0duUC9XdHVBClVsOGw2Mi9BTGJheXlq KzYxQ2xyc0V0UklhcU82N0xJWXdQaVBEUkkrWGlNek5pR3pIRi8xUTZHUjAyUkg2YTMKRjg5 ejhhUHhjSGkxWnZDdDJ5a3o2VUVjaHpQMHI1Z3FGSisvTC9VcHU4ME1YaVk0djVlSWFCNTJn VlBnaXlNQQpsTDJkRHMxbUladm5yUkxSWTJ0YjNtQVlOa1Y1QjVJRFQzcGtXeTZrS281T0Nn SytZZFlPUjhGTloyb04ydDhPCnJLK1ZudGFLN01NU0tIbG1ZL3NPd3RSbEVoMU9CbXJjQ3dH d21wLzA1R2tSNDZmL0lzaFJWZUZPUmF3K0dBcXQKUDIrQ0ZhMkNOQS9JSG5aTm95aWtsRHpQ UUhVVUdzck5wcERyaFg5Sm1oQm1nMXYyeXdIMU5YdTFpRGZQMUJBdwpLZ29rdDVmNVVhUkY5 c0FBNTN2V0V2YlVVTjllZXNGR0x6UFdkSkdRNWhwZC9WSDVJUXk5U0JyaC93SWNla3E1Cm4w a042cGJUSHhHRTUyU2kvTVZJa05UdURaM2FwbjJqbERaNHBPdHBCWEkydlAzYlBPK05pcUJa anNVM3R4TGkKV2R2MkZqeXp6NlhMUndlV1JZVkw1SGE2TER0eG9yMnZ1NlVQMDdwOXh6MXhS WmFPRFczb1lsSEZ6WXBhNFc1ZwpMSGIybEVrSXVVZlNjaWNHYmpqQXRDbFRkR1ZtWVc0Z1Yy Rm9jbVZ1SUR4emRHVm1ZVzR1ZDJGb2NtVnVRR2x1CkxYUmxZMmd1WTI5dFBva0NOd1FUQVFn QUlRVUNYSWRlaHdJYkF3VUxDUWdIQWdZVkNBa0tDd0lFRmdJREFRSWUKQVFJWGdBQUtDUkNV Z2V3UEVaRHkyeUhURC85VUY3UWxEa0d4elE3QWFDSTZOOTVpUWY4LzFvU1VhRE51Mlk2SQpL K0R6UXBiMVRiVE9yM1ZKd3dZOGEzT1d6NU5MU09MTVdlVnh0K29zTW1sUUlHdWJEM09EWko4 aXpQbEcvSnJOCnQ1elNkbU41SUE1ZjNlc1dXUVZLdmdoWkFnVERxZHB2K1pIVzJFbXhuQUox dUxGWFhlUWQzVVpjQzVyMy9nL3YKU2FNbzl4ZWszSjVtTnVEbTcxbEVXc0FzL0JBY0ZjK3lu TGh4d0JXQld3c3Z3UjhiSHRKNURPTVd2YUt1RHNrcApJR0ZVZS9LYjJCK2pyYXZRM1RuNnMv SHFKTTBjZXhTSHo1cGUrMHNHdlArdDlKNzIzNEJGUXdlRkV4cmlleThVCkl4T3I0WEFiYWFi U3J5WW5VL3pWSDlVMWkyQUlRWk1XSkFldkN2VmdRL1UrTmVSaFh1ZGU5WVVtRE1EbzJzQjIK VkFGRUFxaUYyUVVIUEEybThhN0VPM3lmTDRyTWswaUh6TElLdmg2L3JIOFFDWThpM1h4VE5M OWlDTHpCV3UvTgpPbkNBYlMremx2TFphaVNNaDVFZnV4VHR2NFBsVmRFamY2MlArWkhJRDE2 Z1VEd0VtYXpMQU1yeDY2NmpINWt1ClVDVFZ5bWJMMFR2Qis2TDZBUmw4QU55TTRBRG1rV2tw eU0yMmtDdUlTWUFFZlFSM3VXWFo5WWd4YVBNcWJWK3cKQnJoSmc0SGFONkM2eFRxR3YzcjRC MmFxYjc3L0NWb1JKMVo5Y3BIQ3dpT3pJYUFtdnl6UFU2TXhDRFhaOEZnWQpsVDR2MjNHNWlt SlAyemdYNXMrRjZBQ1VKOVVRUEQwdVRmK0o5RGEycitza2gvc1dPbloreWNvSE5CUXZvY1pF Ck5BSFFmN2tDRFFSYmVvQVRBUkFBMkhkMGZzRFZLNzJSTFNESGJ5ME9oZ0RjRGxWQk0yTSto WVlwTzNmWDFyKysKc2hpcVBLQ0hWQXNRNWJ4ZTdIbUppbUhhNEtLWXMya3YvbWx0L0NhdUNK Ly9wbWN5Y0JNN0d2d25Lem11WHp1QQpHbVZUWkM2V1I1TGtha0ZydEhPelZtc0VHcE52NVJj OWw2SFlGcExrYlNrVmk1U1BRWkp5K0VNZ01DRmdqclpmClZGNnlvdHdFMWFmN0hOdE1oTlBh TEROMW9VS0Y1aitSeVJnNWl3SnVDRGtuSGp3QlFWNHBndzIvNXZTOEE3WlEKdjJNYlcvVExF eXBLWGlmNzhJaGdBelh0RTJYck0xbi9vNlpINzFvUkZGS096NDJsRmR6ZHJTWDBZc3FYZ0hD WAo1Z0l0TGZxemoxcHNNYTlvMWVpTlRFbTFkVlFyVHFueXMwbDE4b2FsUk5zd1lsUW1uWUJ3 cHdDa2FUSExNSHdLCmZHQmJvNWRMUEVzaHRWb3dJNm5zZ3FMVHlRSG1xSFlxVVpZSXBpZ21t QzNTd0JXWTFWNmZmVUVta3FwQUFDRW4KTDQvZ1Vnbjd5US81ZDBzZXFuQXEycFNCSE1VVW9D Y1R6RVFVV1ZraUR2M1JrN2hURm1oVHNNcTc4eHYyWFJzWApNUjZ5UWhTVFBGWkNZRFVFeEVs RXNTbzlGV0hXcjZ6SHlZY2M4cURMRnZHOUZQaG1RdVQyczlCbHg2Z0kzMjNHCm5FcTFsd1dQ SlZ6UDRqUWtKS0lBWHdGcHYrVzhDV0xxekRXT3ZkbHJEYVRhVk1zY0ZUZUg1VzZVcHJsNjVq cUYKUUdNcGNSR0NzOEdDVVcxM0gwSXlPdFF0d1dYQTRueStTTDgxcHZpQW1hU1hVOGxhS2FS dTkxVk9WYUY5ZjRzQQpFUUVBQVlrQ0h3UVlBUUlBQ1FVQ1czcUFFd0liREFBS0NSQ1VnZXdQ RVpEeTIrb1hELzljSEhSa0JaT2ZrbVNxCjE0U3Z4MDYyUHRVMEtWNDcwVFNucC9qV29ZSm5L SXczRzBtWElSZ3J0SDJkUHdwSWdWanNZeVJTVk1LbVNwdDUKWnJEZjlOdFRiTldnazhWb0xl WnpZRW8rSjNvUHFGclRNczNhWVl2N2U0K0pLNjk1WW5tUSttT0Q5bmlhOTE1dApyNUFaajk1 VWZTVGx5VW15aWMxZDhvdnNmMWZQN1hDVVZSRmNSamZOZkRGMW9ML3BEZ01QNUdaMk93YVRl am15CkN1SGpNOElSMUNpYXZCcFlEbUJuVFlrN1B0aHk2YXRXdllsMGZ5L0NxYWpUS3N4Nytw OXh6aXU4WmZWWCtpS0IKQ2MrSGUrRURFZEdJRGh2TlovSVFIZk9CMlBVWFdHUytzOUZOVHhy L0E2bkxHWG5BOVk2dzkzaVBkWUl3eFM3SwpYTG9LSmVlMTBEamx6c1lzUmZsRk9XMFpPaVNp aElDWGlRVjF1cU02dHpGRzlndFJjaXVzNVVBdGhXYU8xT3dVClNDUW1mQ09tNGZ2TUlKSUE5 cnh0b1M2T3FSUWNpRjNjcm1vMHJKQ3ROMmF3WmZnaThYRWlmN2Q2aGp2MEVLTTkKWFpvaUFa WVpEKy9pTG01VGFLV042b0dJdGkwVmpKdjhaWk9aT2ZDYjZ2cUZJa0pXK2FPdTRvclRMRk16 MjhhbwpVM1F5V3BOQzhGRm1kWXNWdWE4czZnTjFOSWE2eTNxYS9aQjhiQS9pa3k1OUFFejRp RElScmdVek1FZzhBazdUCmZtMUtpWWVpVHRCRENvMjVCdlhqYnFzeXhrUUQxbmtSbTZGQVZ6 RXVPUEllOEp1cVcyeEQ5aXhHWXZqVTVoa1IKZ0pwM2dQNWIrY25HM0xQcXF1UTJFNmdvS1VN TEFia0NEUVJiZmw5REFSQUFzRExjYStMbFAydm5mdEVHaHBjQQpCR1ZOUUVGbkdQckNhdVU2 SGhOODA1V3RQVHRtc1JPdUp6cWdVVDBtcHFXSWZacTZzTXd5dkhLOVRzL0tIM0paClVWYlJD M3oyaDNLZmhIL0RhZjk1cGQ2bVBjL2g5dkYvT3kzK2VUV2hnR25QNmNBNWtsUitmTzFXaEc4 VnJpWHYKck5lUkcyMHN6emplSG9jblNJY1Q1WHVaUjB1REhPaUd4T2l6MXNNUkZUR3h6R095 MTlSOXJ2dTYzdGlJM2Q3dgpnYzc1T0NBZGtlQi9TZUNFbGFSdzBUZjdMWmJQampzRjI2M0JZ bk1mNGtrTkVLdnFXY1UyaWNNcCtxZXpqeW5CCnB2ZXVlMHJDVFFCWUFRbG9GQ1ZUR0hyV1dB NkQ0VzVPMkFmSWRJYzF1MUpDWnAyZjVMV1ZvVUZUVklyUW5RUVUKU0hDaWZyOU1aeExUdFBK ZFU1Mm9TUHczZGs0aExQOGlKSUx1dnYvYXZhakNzUVlIRXR3WXNiZUZaeGl1TGdscApBN1lj Sk5ObXBnQ3BNRDR3VWh2bEN0QUtOQlFXeXIyOTc2OThFUVRuNDZlQmVVNkttMkNpaFhrZ3dD eWY4ZXlLCkxFM3NYZXdhcTVrZ1pXdk5xNml1NXFZSVJCOXl3K2NYYzYwZE9aRE9scTkzWDVT QVJZemFvZXBrSHo0cmtMa1AKUG8rdENIeUhRUHNHblBYYzlXVDgwREM5Tm5KR2R2VWx5NXJk TUk0eHBaeWdlb2tqd293VlFsUFV1Y1M2TXluNwpmOHc4Y2dmQjdDMklBSWNEeDJwUC9IendY dmtDT1FOQTdtVjFsTTA4bitnVmtUcnpweGlwNURicTRDSW9ZeDJNCkpaVDhiR1JINlhqY1VE S2EwOVFoeVpzQUVRRUFBWWtFUkFRWUFRZ0FEd1VDVzM1ZlF3SWJBZ1VKQThKbkFBSXAKQ1JD VWdld1BFWkR5MjhGZElBUVpBUWdBQmdVQ1czNWZRd0FLQ1JCVnhETFBjVk1NamNkc0QvMFJo QXN1UVlPeQpyMTNCbDNOaFhrWUFaR3AyWkZER3VrZTdPU2tWOG9qT09UZFR5ei9jT1JHQ2J5 ZEQrRGd2cUZ5VmRuT1hLZ08wCmxKbUd3ckdlTGRnZ0F2aDBpaHJwNU8wWVVKOWJCU1htR01t UVRZSC9BbUxUR2FkYnVqQ1dqNWZGVWtDeXd4aW0KSHV5MFBiMjRwelR2UzUwR1k1WStxSDBG SE5haWdka2tpV04zcnVnN0haRXUvQ3lsUFpqT1h6K0QxUVBNckV4dwo3ZC9NS2FiVis5YU5i UVlabGRJajk4UXd2VUYxS1N6YThqbFVJdnBoUnEyN0FUOGZER1lHUGZERU1nMmNCT2FlCkty N29uUXM0YjdhV082aWZEbHhRVHB6c3pvK0FuODA3Tk1TdFZFRmYrczNBaFZEM2U3bmY4SkJh dmJWckFlMGsKb20yNm96elBubnh6K2xxVlZ0dzZVazRYTUl6dGl4L0h3SFl3dUNuY1VYWndL MEkzeUFKd2pZd29vck9DaEozUwpFVWJKUVB0R3NneFJERXhWQkZlNk5MUC82MnhQOU82dGFj d09kYjBNbVAxYjM5cFJBVEM3YmdkMWxkVUxpNzVaCmxKckowL1NpVkVyb3FOWXk3OXRmbWdB WjJVeFptczlTckV5Nm85UVNmc24xYVh2K01QTDlKYUNHbWtQNnpiTFEKTm5kajBKY2FRbmtD MHZneWRPMUJtNk11OTZQOXVmbEtaY0FTNndtTE01SWRIT3lqTDg4d0h3anVjakFPQnRjdwpw MG9HVG5WT25Sc05ZU084VzhZWi9LZGJ1Nzg1ZGF6TXFKMmlOakFEdUJiZG02TjRqNUVkTW5r TG4wQklmUEpwCmRnbTR2bDJVcExqd1JHci9NM3dtbTVwdnMrNnVCN2hrL0ZKaUQvNGxsRU5Q NGVNMWg3U200aitWcTZOMSt6VEIKSVhKQWViSXFhc0RwNXlaUzdYcnk0STM2bjg1WEVZZkcw MWx0QXlob05WMkRPOFNJUlFwdWkydHErOVJQM1JLMQpKREJ4eEVKWTJFTzVKWjhNeGFQSFEw RFQwNWxSRmpLMkFsaGRFSXRqTGpwSjNmVW05c3FMeE1XeHpQNlV6M2lpCjJ1YTR1bnJ0Nk9D VHFRd2lqRi8zYlRXaXd2VkFBSG5NRlVpb1hzaEhhb2hWRGNWZm5lSU1mVjBiUUNYWWkzTnAK WTB2MFp3Y2lGSCtnU0M3cUQ2WE51aHBWR1NMNElpbGlGeS9TemNhSkV6QUhlTERTaFpQMkNX ZG5DNHZnbDM3dApocHg4aDU1WWhKbjZIU3VVelBnaGFLdFZCMmsrajdaZXlaK1NGeHA3SXVi SEN3TEhsUWhUNzVSd1EzaUF4S242CjBxajUxY1lUbnF4ZFpYVzZmSDNQa3VNellVNUdwcVIv MU9sNWMvd2ZJNmc2QW04eUtXLzBFVUx0K0tuNExGc1MKbTdZM201SDV2MTJVNkpCWXZWK3Ix M2paaW9zNEVFREU5M0Q1c05IMk1JeVJ6Q0RxMXpkZHQ0WHV5S0ZqUEtXMQo5aWJaRGZGVjdL dUNzdnVMMjNzQmMxc0NNb3ArRTFtVC9ReE9JQTZvRFQxTVFzdHdPVnVReURDdi9PdktTZ2Z6 CjhGWEdMNkFQY2xqQ3FqOEFKaHhReXN4ZG9pUVA4bS92dStialdHR3Z4dzVzMWxncGlSRFRS VVBnY0pKTmFHWTIKVklEclpRaTROU2lOUTBOSWkrZGp1NGZOTW1DcFFxZzh0YkMzY0FhNnl3 bTZvUUIxU0JobURYMmUxMWdSbGx1SQpPblRHUEUwSFRvM2w3MmxoYmc9PQo9cVpNVgotLS0t LUVORCBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCg== Message-ID: <197a3164-828b-510e-47a7-f18ce1300d9d@i2se.com> Date: Sat, 6 Jun 2020 10:06:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200605143536.i6cc2v57eupmlvtn@gilmour.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Content-Language: en-US X-Provags-ID: V03:K1:4GY4dLMLfpuTJ5ZYwV/QbelUAStEcVpnB+DioeLib8h9jU8wW2V NUkYnde/l25nkj8HKHxUfF7yYkIQx9q+ilOzoeEwdRR3pU6mGJ39wb+RVqZNyjzhhVdWx// 2aRnZEZJT2hWz8/adUqlL47oR1e7wxXyqgqtEGPm1wX8KtbcTg1Urht7D7qRtWNGS8xH1JY /PRT3QnOqfwxGYeaZCwSA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:b6wZ2B4kMlI=:92vNNL/IOZG3OHnfHIEoXm MVnS3Se80cQyvy3NUyAfW3ycuFrm+/43QTM4BFDOiXNOZcxg1fw+xPtAFGsmf62Eeg9vmyBcL aVj4Y/x3bqDQDSbteUCJsw1zNBdbBO71smP0VAEUnFtQo94NuwLQlybB5c/rfeWSppV5cVRBA JS9uBmi2lBZWbcn1o62fZUbgjgvOQCsV/cC0Nk5ZGB7rOJS03BlFQuEnyNWYE1GbQc4w7gKLu 4xhyYl6cRvyDYmmcMhn4+j9scE5LbyCByphu6h3SBJeH6jQFcsSRqfi7wxfWXaOAqzsTpSdYU Q27SHpvxJkMciPm1knKez1NDmwzfV8fUXElk0thBtH1S5jmKbKNBGZW00uwOlpswzMxOEx+3d XkcjTpiIRbE8nUZddu72Q/lXzVLMiygoGHTP1RoVHATe+rh/cK7VMAxmm6iz5FCfxyd083e4m Aq729NXfkxBmAUerdwcf9VSPxV+wCzmNpKUlYEy7ntDf9Z9e3+rHqsWnBz4jI3AkTzs61kK8Z UiOGSeOX1r/KlXXFbfTngDf+oIJPZniwLbMojPsUT9qNJ1QKtSAhJDbJwHI0thJah4cyiiTfD 1HffjU0EEaGOCRbfTs99TSdsZIIWS9JWZ/9vg8ql8LjlOVpru9t0Z2scYLq/vueK8icEQLrUX y0sQ1Wl0F/JaKeAFKw6ku2BECEaIsxVEiuVJzQjVPVfl8DXgyKcRUV7m8IWZLISqbsFpU2bPu 9Q/z25U8IEStvmWzAamSqio0z/qt32c2+H+nHAYxlBB11l7vZ7j3WFBNWdyQVeSMUANckRzOV pkxDrXETe7YDnx/iwha3v6dm0ZQeceI/K8WbriqwUg4/MkAAJ/yO4aR2mk8TPFF55x72s6K Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, Am 05.06.20 um 16:35 schrieb Maxime Ripard: > Hi Stefan, > > On Wed, Jun 03, 2020 at 07:32:30PM +0200, Stefan Wahren wrote: >> Am 02.06.20 um 17:54 schrieb Maxime Ripard: >>> On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: >>>> On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: >>>>> the vc4_hdmi driver has some custom structures to hold the data it needs to >>>>> associate with the drm_encoder and drm_connector structures. >>>>> >>>>> However, it allocates them separately from the vc4_hdmi structure which >>>>> makes it more complicated than it needs to be. >>>>> >>>>> Move those structures to be contained by vc4_hdmi and update the code >>>>> accordingly. >>>>> @@ -1220,7 +1219,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data) >>>>> struct drm_device *drm = dev_get_drvdata(master); >>>>> struct vc4_dev *vc4 = drm->dev_private; >>>>> struct vc4_hdmi *hdmi; >>>>> - struct vc4_hdmi_encoder *vc4_hdmi_encoder; >>>>> + struct drm_encoder *encoder; >>>>> struct device_node *ddc_node; >>>>> u32 value; >>>>> int ret; >>>>> @@ -1229,14 +1228,10 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data) >>>>> if (!hdmi) >>>>> return -ENOMEM; >>>>> >>>>> - vc4_hdmi_encoder = devm_kzalloc(dev, sizeof(*vc4_hdmi_encoder), >>>>> - GFP_KERNEL); >>>>> - if (!vc4_hdmi_encoder) >>>>> - return -ENOMEM; >>>>> - vc4_hdmi_encoder->base.type = VC4_ENCODER_TYPE_HDMI0; >>>>> - hdmi->encoder = &vc4_hdmi_encoder->base.base; >>>>> - >>>>> hdmi->pdev = pdev; >>>>> + encoder = &hdmi->encoder.base.base; >>>>> + encoder->base.type = VC4_ENCODER_TYPE_HDMI0; >>>> Wait, does this patch build? >>> All those patches were build tested, so yep >>> >>>> setting struct drm_encoder->base.type = VC4_* seems very wrong, when >>>> previously we were setting struct vc4_hdmi_encoder->base.type (struct >>>> vc4_encoder->type). >>> So the structure layout now is that vc4_hdmi embeds vc4_hdmi_encoder as >>> encoder. So &hdmi->encoder is a pointer to vc4_hdmi_encoder. >>> vc4_hdmi_encoder's base is since that patch a struct vc4_encoder. and >>> vc4_encoder's base is a drm_encoder. >>> >>> so encoder being a drm_encoder is correct there. >>> >>> However, drm_encoder's base is drm_mode_object that does have a type >>> field, which is an uint32_t, which will accept a VC4_ENCODER_TYPE_* just >>> fine... >>> >>> Now, drm_encoder_init will then kick in and call drm_mode_object_add >>> which will override it to a proper value and since the clock select bit >>> in the PV is the same for both HDMI0 and HDMI1, everything works just >>> fine... >>> >>> Good catch, I'll fix it. And I guess it's a good indication we don't >>> need a separate HDMI0 and HDMI1 encoder type. >>> >> FWIW this is the first patch which breaks X on my Raspberry Pi 3 B. >> >> Here are the bisect results: >> >> 587d6e4a529a8d807a5c0bae583dd432d77064d6 bad (black screen, no heartbeat) >> >> b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8 good >> >> 2c6a651cac6359cb0244a40d3b7a14e72918f169 good >> >> 1705c3cb40906863ec0d24ee5ea5092f5ee2e994 bad (black screen, but heartbeat) >> >> 601527fea6bb226abd088a864e74b25368218e87 good >> >> 2165607ede34d229d0cbce916c70c7fb6c0337be good >> >> f094f388fc2df848227e2ae648df2c97872df42b good >> >> 020de18840a1075b2671736c6cc2e451030fad74 bad (black screen, but heartbeat) >> >> 4c4da3823e4d1a8189e96a59a79451fff372f70b good >> >> 020de18840a1075b2671736c6cc2e451030fad74 is the first bad commit >> commit 020de18840a1075b2671736c6cc2e451030fad74 >> Author: Maxime Ripard >> Date:?? Mon Jan 6 17:17:29 2020 +0100 >> >> ??? drm/vc4: hdmi: rework connectors and encoders >> ??? >> ??? the vc4_hdmi driver has some custom structures to hold the data it >> needs to >> ??? associate with the drm_encoder and drm_connector structures. >> ??? >> ??? However, it allocates them separately from the vc4_hdmi structure which >> ??? makes it more complicated than it needs to be. >> ??? >> ??? Move those structures to be contained by vc4_hdmi and update the code >> ??? accordingly. >> ??? >> ??? Signed-off-by: Maxime Ripard > So it looks like there was two issues on the Pi3. The first one was > causing the timeouts (and therefore likely the black screen but > heartbeat case you had) and I've fixed it. > > However, I can indeed reproduce the case with the black screen / no > heartbeat you mentionned. My bisection however returns that it's the > patch "drm/vc4: hdmi: Implement finer-grained hooks" that is at fault. > I've pushed my updated branch, if you have some spare time, it would be > great if you could confirm it on your Pi. yesterday i checked out your latest rpi4-kms branch, but i was still facing similiar issues with my Raspberry Pi 3 and multi_v7_defconfig (heartbeat stops, splashscreen freeze, heartbeat is abnormal fast). So i tried to bisect but the offending commit didn't cause an issue the second time. By accident i noticed that a simple reboot seems to hang for at least 8 minutes (using b0523c7b1c9d0edcd the base of your branch). This usually take a few seconds. So i consider this base on linux-next as too unstable for reliable testing. Is it possible to rebase this on something more stable like linux-5.7 or at least drm-misc-next? This should avoid chasing unrelated issues. Regards Stefan > > Thanks! > Maxime