Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 6 Jun 2020 22:36:47 +0800
From:   Gao Xiang <hsiangkao@aol.com>
To:     Vasily Averin <vvs@virtuozzo.com>
Cc:     linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Gao Xiang <xiang@kernel.org>
Subject: Re: [PATCH] lib/lz4: smatch warning in LZ4_decompress_generic()
Message-ID: <20200606143646.GB10839@hsiangkao-HP-ZHAN-66-Pro-G1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e109dba0-eaa8-aa21-3b97-f999c76a72a4@virtuozzo.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
References: <20200606143646.GB10839.ref@hsiangkao-HP-ZHAN-66-Pro-G1>
Content-Length: 1540
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

(I'm not sure whether my email was finally sent out since
 I haven't seen it in lore yet. Resend with my another email...)

On Sat, Jun 06, 2020 at 04:28:02PM +0300, Vasily Averin wrote:
> Found by smatch:
> lib/lz4/lz4_decompress.c:150 LZ4_decompress_generic() warn: maybe use && instead of &
> It was realy incorrectly copied from
> https://github.com/lz4/lz4/commit/45f8603aae389d34c689d3ff7427b314071ccd2c
> line 1431

Simply no.

> 
> Fixes: 2209fda323e2 ("lib/lz4: update LZ4 decompressor module")
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
> ---
>  lib/lz4/lz4_decompress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/lz4/lz4_decompress.c b/lib/lz4/lz4_decompress.c
> index 0c9d3ad..f7f7dca 100644
> --- a/lib/lz4/lz4_decompress.c
> +++ b/lib/lz4/lz4_decompress.c
> @@ -147,7 +147,7 @@ static FORCE_INLINE int LZ4_decompress_generic(
>  		    * strictly "less than" on input, to re-enter
>  		    * the loop with at least one byte
>  		    */
> -		   && likely((endOnInput ? ip < shortiend : 1) &
> +		   && likely((endOnInput ? ip < shortiend : 1) &&

I'd like to say, this is not my mistake (even not an issue).
If you notice the latest LZ4 upstream
https://github.com/lz4/lz4/blob/dev/lib/lz4.c#L1865

Or some related change, the lz4 author Cyan did it on purpose.
https://github.com/lz4/lz4/commit/1a191b3f8d26b50a7c1d41590b529ec308d768cd

I think we could follow the latest LZ4 upstream in order to
avoid further maintainence overhead. That's my own thought
anyway.

Thanks,
Gao Xiang