Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 6 Jun 2020 22:47:20 +0800
From:   Changbin Du <changbin.du@gmail.com>
To:     Changbin Du <changbin.du@gmail.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf trace: add default value for opt 'call-graph'
Message-ID: <20200606144720.44brke7t3ej7ovho@mail.google.com>
References: <20200503040056.29683-1-changbin.du@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200503040056.29683-1-changbin.du@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Arnaldo,
Have you checked this one? thanks.

On Sun, May 03, 2020 at 04:00:56AM +0000, Changbin Du wrote:
> The documentation says the default value of call-graph.record_mode is 'fp'.
> But actually we never can omit value of call-graph parameter. This patch
> can fix this issue.
> 
> Meanwhile, this patch adds a short name '-g' for opt 'call-graph' since it's
> very useful.
> 
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---
>  tools/perf/builtin-trace.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 01d542007c8b..21a9656021a0 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -4754,9 +4754,9 @@ int cmd_trace(int argc, const char **argv)
>  		     "Trace pagefaults", parse_pagefaults, "maj"),
>  	OPT_BOOLEAN(0, "syscalls", &trace.trace_syscalls, "Trace syscalls"),
>  	OPT_BOOLEAN('f', "force", &trace.force, "don't complain, do it"),
> -	OPT_CALLBACK(0, "call-graph", &trace.opts,
> +	OPT_CALLBACK_DEFAULT('g', "call-graph", &trace.opts,
>  		     "record_mode[,record_size]", record_callchain_help,
> -		     &record_parse_callchain_opt),
> +		     &record_parse_callchain_opt, "fp"),
>  	OPT_BOOLEAN(0, "libtraceevent_print", &trace.libtraceevent_print,
>  		    "Use libtraceevent to print the tracepoint arguments."),
>  	OPT_BOOLEAN(0, "kernel-syscall-graph", &trace.kernel_syscallchains,
> -- 
> 2.17.1
> 

-- 
Cheers,
Changbin Du