Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp3758030ybg; Sun, 7 Jun 2020 09:38:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzivR6sZTaRF/5RdnE7MV6YJ3rfddBalh9u2P+oJ3RwFaTCJIP5OHkr6U/J7LHU/aBFCV07 X-Received: by 2002:a05:6402:129a:: with SMTP id w26mr19054286edv.41.1591547926772; Sun, 07 Jun 2020 09:38:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591547926; cv=none; d=google.com; s=arc-20160816; b=o79nwX9snQhQsHFWFQoU5x1pl6+UocmKFuBO5blejMyhy0iz/lMrNQMC+YAWtztKiH EW97255il1gdq/++XWM5AooMsoYz/uuF96NC1GwucVackROuJXO3t1ABNNI+8zTJoApD aTy6D9g+TDs001hlbwQNxJWWN87WCroVPY2L5SKgCAYvfOn/dJLw4yEVRflLPVeq4QCw DRhdmktCWUQwGltcPFsWvQTQU1Qo3hKxXxqEYPHDXTpj7ptsfEa1yMrm5KVWZwovinNr +i7PFmA0taXfhg8oQcBp4b3AOkvLFi9j0QlcjOE1RTXhTFZE1Uy4Bq+pij1jI0Aw3Pjb OdVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=84DAZD1d3HzPukrFPEi8ZgUMWd0Yjo/jieeMkqRqDhY=; b=oao7fMkRMT9ak9aV7JgPIZG6VU+v/dqycOxZRD8Pc1wVp00X2R7lMm3lBq9F0Ag5Bl n5LjspcwaxQ61jyZwTPJSUB+QuS9PdBD0DfU1DFyLHeIzyIjW/wyD6JHaGrecGnW+Akd JBeoIYqbGVPfgLbomeSRvt04uR0ll4muCJZwifHzmE50Gz1iivTiRkDKNB7cXYzRtODu csPKiIccQVMQMZiGFDY1ZhaBaYFNZIIzofPpwzHAaEj/oH5eW/PRuzCjqikYxwQmSxbW MFx1GnZbDPoS23e6Jma/t1D+OlkrMLwEJoJfrYZvSGQNy1MnlNH+IGW0LGh2+D6BFP1G rbfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m3si6770970ejx.210.2020.06.07.09.38.23; Sun, 07 Jun 2020 09:38:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726732AbgFGQea (ORCPT + 99 others); Sun, 7 Jun 2020 12:34:30 -0400 Received: from mga07.intel.com ([134.134.136.100]:58842 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726646AbgFGQe3 (ORCPT ); Sun, 7 Jun 2020 12:34:29 -0400 IronPort-SDR: UFC7Ab1xN9mMIw+3cO9GT6fLGmIBJT4aLikBO+OucFtE6gIEWtvtT0tJ2/TxGqNdSbKIIK411G 961vTGiXO+YQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2020 09:34:28 -0700 IronPort-SDR: Fyk1InqYMPYgh1T0kcnxxfilbZ5XgWp5wHXXAKKqigkdTzUJ4X4gN7NUquJyqONUiDLVB/kR+a Tw6xi5oUdIhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,484,1583222400"; d="scan'208";a="258486290" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.152]) by fmsmga007.fm.intel.com with ESMTP; 07 Jun 2020 09:34:28 -0700 Date: Sun, 7 Jun 2020 09:34:28 -0700 From: Sean Christopherson To: kernel test robot Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "Rafael J. Wysocki" , Pavel Machek , kbuild-all@lists.01.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Brad Campbell Subject: Re: [PATCH] x86/cpu: Reinitialize IA32_FEAT_CTL MSR on BSP during wakeup Message-ID: <20200607163428.GB24576@linux.intel.com> References: <20200605200728.10145-1-sean.j.christopherson@intel.com> <202006060421.fTpTXYbe%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202006060421.fTpTXYbe%lkp@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 06, 2020 at 05:08:38AM +0800, kernel test robot wrote: arch/x86/kernel/cpu/centaur.c: In function 'init_centaur': > >> arch/x86/kernel/cpu/centaur.c:219:2: error: implicit declaration of function 'init_ia32_feat_ctl' [-Werror=implicit-function-declaration] > 219 | init_ia32_feat_ctl(c); > | ^~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > -- > arch/x86/kernel/cpu/zhaoxin.c: In function 'init_zhaoxin': > >> arch/x86/kernel/cpu/zhaoxin.c:110:2: error: implicit declaration of function 'init_ia32_feat_ctl' [-Werror=implicit-function-declaration] > 110 | init_ia32_feat_ctl(c); > | ^~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors Blech, zhaoxin.c an centaur.c don't include asm/cpu.h, and I (obviously) don't have them enabled in my configs. I'll wait a day or two more before sending v2. diff --git a/arch/x86/kernel/cpu/centaur.c b/arch/x86/kernel/cpu/centaur.c index 426792565d86..c5cf336e5077 100644 --- a/arch/x86/kernel/cpu/centaur.c +++ b/arch/x86/kernel/cpu/centaur.c @@ -3,6 +3,7 @@ #include #include +#include #include #include #include diff --git a/arch/x86/kernel/cpu/zhaoxin.c b/arch/x86/kernel/cpu/zhaoxin.c index df1358ba622b..05fa4ef63490 100644 --- a/arch/x86/kernel/cpu/zhaoxin.c +++ b/arch/x86/kernel/cpu/zhaoxin.c @@ -2,6 +2,7 @@ #include #include +#include #include #include "cpu.h"